ADD TO: https://wiki.blender.org/wiki/Tools/CodeReview#Guidelines_for_Reviewers * The differential text should be usable as the git commit message (see the guidelines for details). * Be explicit when some changes are to be addressed before committing, without the need for a review iteration. * If the patch is not "green-light" the author is expected to give the patch another iteration. * If the patch needs agreement on the design task first, put the patch on hold.
Note: [https://developer.blender.org/T72400 T72400]
Currently it is only possible via “Close” patch, which sounds negative. But a new state can be introduced. * **Wait for reviewers:** ** Developers are expected to reply to patches 3 working days. * Prefer tagging modules (instead of individual people) for reviewers. * In the future: ** We will have CI (compile + tests) ** Maybe support a "merge" button * Get newer developers doing code review. ** We assign them review, unless they have a good reason not to, they should consider it part of their work for BF to do these code reviews to the best of their ability. ** Encourage developers to review different areas of the code-base for better bus-factor. ** Encourage pairing for review - 30-45min sessions. * (TODO): patch review playbook: e.g: specialized feature that doesn’t fit, split into multiple patches.. Needs design task… etc. ADD TO: https://wiki.blender.org/wiki/Process/Contributing_Code#Guidelines ** If more detailed explanation is needed, use design task, and/or Wiki. ** Use a horizontal separator (`---`) to separate non-commit-message-related text, so it's obvious what the text isn't intended to be included in the commit log. NOTE: the "Contributing Code" page is becoming a wall of text, mixing suggestions/advice with policy, we could have a "Requirements" section separate from "Guidelines". Or have a "Contributing Code Advice" page that's closer to our "New Developer Advice" Page. This way, we can keep the "Rules" much shorter - to avoid mixing this in with general suggestions/advice. Organizational changes could be handled separately though.