Maniphest T21043

Using operator redo clears edited text (lack of text editor global undo push)
Closed, Archived
Actions

Assigned To
None
Authored By
Gerwin Damsteegt (dreampainter)
Feb 8 2010, 9:37 PM
Tags
  • User Interface
  • BF Blender
Subscribers
Gerwin Damsteegt (dreampainter)
Matt Ebb (broken)
Sergey Sharybin (sergey)
Ton Roosendaal (ton)

Description

in standard blend file, add "add_mesh_torus.py" to the text editor, then run it.
then change one of the parameters. the text "add_mesh_torus.py" will disappear from the text editor. if you changed something to the file, say added "# hello" somewhere and put the text cursor in an other place in the text, then perform the same trick, the cursor will jump back. seems like blender performs an undo too much.


windows xp sp3

nvidia geforce GTX 280M

r26712

Event Timeline

Gerwin Damsteegt (dreampainter) edited a custom field.Feb 8 2010, 9:37 PM
Matt Ebb (broken) added a comment.Apr 26 2010, 6:57 AM

Hi, I think this isn't due to changing parameters after they're defined, it's more about the text editor - it isn't doing global undo pushes on changes to the text editor, it's using its own internal undo system. When an operator does it's 'redo' while tweaking parameters, it's clearing that undo buffer.

Anyway, the particular problem reported here is more about the text editor's data manipulation operators (new text block, open text, etc) not doing undo pushes when these ones really should. I've fixed this in SVN, but the issue of losing edited text still remains...

I'll change the title of this report to reflect this.

Matt Ebb (broken) added a comment.Jun 9 2010, 6:58 AM

This also is apparent just using normal ctrl-z undo - closed a duplicate report where this is mentioned:
https://projects.blender.org/tracker/index.php?func=detail&aid=22326&group_id=9&atid=498

Sergey Sharybin (sergey) added a comment.Sep 14 2010, 6:41 PM

Closed duplicate http://projects.blender.org/tracker/?func=detail&atid=498&aid=23807&group_id=9

Ton Roosendaal (ton) added a comment.Nov 12 2010, 6:44 PM

Hi,

This is an annoyance already since 2.3-something when global undo was added. It's not a simple bug, but an issue with how the undo systems have been implemented in Blender. It has been clearly marked on our todo in wiki, and is on the agenda to solve.

http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors

Ton Roosendaal (ton) changed the task status from Unknown Status to Archived.Nov 12 2010, 6:44 PM