Maniphest T31574

Screw seams to not work
Closed, Resolved

Assigned To
Campbell Barton (campbellbarton)
Authored By
Benoit Donat-Bouillud (ladeheria)
May 23 2012, 10:31 PM
Tags
  • BF Blender
  • Modeling
Subscribers
Benoit Donat-Bouillud (ladeheria)
Campbell Barton (campbellbarton)
Philipp Oeser (lichtwerk)

Description

Screw tool modeling issue :

When using a screw axis (reference edge for screw), the operation always give the same result (as if the orientation of the reference edge was not take into account).

Here is what you should get : http://www.etude-blender.fr/images/screw45d.gif

Here is what you actually get, regardless the inclination of the reference edge : http://www.etude-blender.fr/images/screw2.gif

OS : Win 7
Blender Build : R46913
Also tested on Linux 64 r46952

Event Timeline

Benoit Donat-Bouillud (ladeheria) edited a custom field.May 23 2012, 10:31 PM

*seems to not work

Philipp Oeser (lichtwerk) added a comment.Jun 11 2012, 6:25 PM

confirmed.

bmo_spin_exec() was missing a multiplication of the rotation matrix by the "dvec"

attached a patch that solves this

Philipp Oeser (lichtwerk) attached 1 file(s): F19816: svn_diff_bmo_dupe.c.Jun 11 2012, 6:25 PM
Philipp Oeser (lichtwerk) added a comment.Jun 11 2012, 6:41 PM

some more info:
this page describes the screw tool in detail
http://wiki.blender.org/index.php/Doc:2.4/Manual/Modeling/Meshes/Editing/Duplicating/Screw

from that page:
If the two “free” ends are aligned vertically, the result is as seen above. If they are not, the vertical component of the translation vector remains equal to the vertical component of the vector joining the two “free” vertices, while the horizontal component generates an enlargement (or reduction) of the screw as shown in (Enlarging screw (right) obtained with the profile on the left). In this example the open line serves as the profile as well as defining the translation.

this patch fixes the behaviour of "screw" when the “free” ends are NOT alligned vertically (like Benoit also pointed out)

Benoit Donat-Bouillud (ladeheria) added a comment.Jun 11 2012, 6:48 PM

Thank you very much for this fix.

Campbell Barton (campbellbarton) added a comment.Jun 13 2012, 6:07 PM

fixed r47840.
closing.

PS - incorrectly credited the patch to Benoit Donat-Bouillud, sorry Philipp Oeser!

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved.Jun 13 2012, 6:08 PM