Maniphest T37599

Crash making linked objects local and undo
Closed, Resolved

Assigned To
Sergey Sharybin (sergey)
Authored By
richard b (richie967)
Nov 24 2013, 3:01 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
koil (koilz)
richard b (richie967)
Sergey Sharybin (sergey)

Description

System Information
Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650

Blender Version
Broken: Blender 2.69.0 r60995

Steps to Redo
when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes,

Any ideas?

undo steps set to 32

Revisions and Commits

rB Blender
D372
rBAC Blender Add-ons Contrib
D372

Related Objects

Event Timeline

richard b (richie967) created this task.Nov 24 2013, 3:01 PM
richard b (richie967) raised the priority of this task from to 90.
richard b (richie967) updated the task description.
richard b (richie967) added a project: BF Blender.
richard b (richie967) edited a custom field.
richard b (richie967) added a subscriber: richard b (richie967).
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Nov 24 2013, 3:11 PM

Please add all the requested information about system information, blender version, steps to redo, etc, not just a title.

richard b (richie967) added a comment.Nov 24 2013, 3:24 PM

Hi brecht,

here is some more information....

System Information
Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650

Blender Version
Broken: Blender 2.69.0 r60995

when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes,

Any ideas?

undo steps set to 32{F32136}

Brecht Van Lommel (brecht) renamed this task from blender crashes when doing an undo 'ctrl & z'... This happens shortly after linking in an object, making it local ,moving it around, then pressing undo to Crash making linked objects local and undo.Nov 25 2013, 8:29 PM
Brecht Van Lommel (brecht) lowered the priority of this task from 90 to 50.
Brecht Van Lommel (brecht) updated the task description.

I can confirm the crash with the above steps, linking in all objects in this file.

Sergey Sharybin (sergey) claimed this task.Feb 17 2014, 10:11 AM

@Brecht Van Lommel (brecht), i couldn't really reproduce the crash. Do have:

Warning: LIB ERROR: object lost from scene: 'Scene'
LIB ERROR: object lost from scene: 'Scene'

messages in the console after the undo tho. Will have a look into this issue, but wouldn't mind having some details about crash..

Brecht Van Lommel (brecht) added a comment.EditedFeb 17 2014, 2:08 PM
thread #25: tid = 0x14d564, 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641, stop reason = EXC_BAD_ACCESS (code=1, address=0x114)
  frame #0: 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641
  frame #1: 0x0000000100b0fe08 blender`do_makeDispListCurveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, dispbase=0x000000010563da88, derivedFinal=0x00000001065e2120, forRender=0, forOrco=0, renderResolution=0) + 552 at displist.c:1396
  frame #2: 0x0000000100b0fbce blender`BKE_displist_make_curveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, forOrco=0) + 222 at displist.c:1612
  frame #3: 0x0000000100bf1224 blender`BKE_object_handle_update_ex(eval_ctx=0x000000010563f898, scene=0x0000000106501008, ob=0x00000001065e1c08, rbw=0x0000000000000000) + 1508 at object.c:2945
  frame #4: 0x0000000100c4924d blender`scene_update_object_func(pool=0x0000000113ad2128, taskdata=0x0000000113aabc98, threadid=6) + 285 at scene.c:1320
  frame #5: 0x0000000100dcf2b8 blender`task_scheduler_thread_run(thread_p=0x0000000105721098) + 104 at task.c:137
  frame #6: 0x00007fff85424899 libsystem_pthread.dylib`_pthread_body + 138
  frame #7: 0x00007fff8542472a libsystem_pthread.dylib`_pthread_start + 137
  frame #8: 0x00007fff85428fc9 libsystem_pthread.dylib`thread_start + 13

cu->bevobj->data and so bevcu is NULL. It's easy to add a NULL check but that doesn't seem like the right solution.

It should be possible to reproduce this if you follow these steps:

  • New file
  • File > Link, go to Objects, press A to select all, click Link
  • L key to make local > Selected Objects
  • G key to move, enter to confirm.
  • Ctrl + Z to undo
Sergey Sharybin (sergey) added a comment.Feb 27 2014, 12:27 PM

@Brecht Van Lommel (brecht), managed to reproduce now. Checking for NULL is not the right solution at all, we need to understand why object data is got lost.

Sergey Sharybin (sergey) added a comment.Feb 27 2014, 12:46 PM

@Brecht Van Lommel (brecht), the issue is actually caused by linked curve pointing to a local object which screws up the file loading. As far as i can tell it's not really supported situation so guess proper solution would be to disallow making IDs local if they're used by other datablocks?

Brecht Van Lommel (brecht) added a comment.Feb 27 2014, 4:15 PM

Right, either that or making the other datablocks local automatically, but to me it seems better to refuse and let the user then use Selected Objects & Data. So yes, I think we should disallow it.

Sergey Sharybin (sergey) edited this Maniphest Task.Feb 28 2014, 12:09 PM
Campbell Barton (campbellbarton) added a subscriber: koil (koilz).Mar 24 2014, 6:09 AM

◀ Merged tasks: T39354.

Sergey Sharybin (sergey) edited this Maniphest Task.Mar 28 2014, 12:15 PM
Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved.Mar 28 2014, 12:15 PM

Closed by commit rB6e5e3b73f37f.

Sergey Sharybin (sergey) edited this Maniphest Task.May 12 2014, 4:45 PM