Maniphest T38913

Game engine crash with Arraymod + cap-object
Closed, Archived
Actions

Assigned To
Aaron Carlisle (Blendify)
Authored By
Karja Krähwald (karja)
Mar 2 2014, 12:30 AM
Tags
  • Modifiers
  • Game Engine
Subscribers
Aaron Carlisle (Blendify)
Alexey (Inwader77)
Jennifer Godin (jenniferblender)
Jorge Bernal (lordloki)
Karja Krähwald (karja)
Patrice Bertrand (PatB)
Porteries Tristan (panzergame)
1 More Subscribers

Description

System Information
Windows 7 64, HD 5770

Blender Version
Broken: 2.69 release & hash: 4789793

Short description of error
Game engine cant handle Array modifier cap objects (start or end cap).

Exact steps for others to reproduce the error

GE_Arraycaps.blend689 KBDownload
Press P

Steps:

  • add any mesh object
  • give it an array-modifier
  • add another mesh object
  • select this new mesh as cap in the array modifier
  • press P to start the game engine

I get a crash with this setup.

Related Objects

Event Timeline

Karja Krähwald (karja) created this task.Mar 2 2014, 12:30 AM
Karja Krähwald (karja) raised the priority of this task from to 90.
Karja Krähwald (karja) updated the task description.
Karja Krähwald (karja) added projects: BF Blender, Game Engine, Modifiers.
Karja Krähwald (karja) edited a custom field.
Karja Krähwald (karja) added a subscriber: Karja Krähwald (karja).
Jennifer Godin (jenniferblender) added a subscriber: Jennifer Godin (jenniferblender).Mar 2 2014, 3:03 AM

Can confirm it on Mac OSX 10.9.2

Crash log attached.

Crash.txt53 KBDownload

Thomas Dinges (dingto) lowered the priority of this task from 90 to 50.Mar 2 2014, 2:04 PM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).

Crash confirmed on Windows x64.

Brecht Van Lommel (brecht) removed a project: BF Blender.Mar 3 2014, 6:13 PM
Patrice Bertrand (PatB) added a subscriber: Patrice Bertrand (PatB).Mar 8 2014, 10:23 PM

Hello,
I gave it a try, and have pinpointed the bug, but only partially solved. Tried to upload the patch, but ended up with a new Task. Sorry, I don't master the process. See comments associated with task T39056. I copy hereunder:

Crash is in CcdPhysicsController.cpp:UpdateMesh
In 4 places in this module array caps cause RAS_Polygon *poly to be incorrect.
This patch fixes the crash by skipping in such cases,
but the result is that caps are not accounted for in collisions.
So some more work is probably needed.

It seems there is a correspondance of faces after modifier applied to original faces of object. But in the case of caps, the original face does not belong to the object, it belongs to another object. I think it may be the only case where a modifier takes bits of another object. In the correspondance, the faces that have been generated from the caps have a corresponding original face of -1. In the code, this translates to:
RAS_Polygon* poly= meshobj->GetPolygon(origi);
with origi being -1.
GetPolygon() simply does `
return m_Polygons[num] which results in m_Polygons[-1], giving an incorrect pointer, which later crashes.

So it may be that fixing this correctly would imply deeper changes to derived mesh handling, beyond my capacity.
Hope someone more proficient can take it from there.

Alexey (Inwader77) added a subscriber: Alexey (Inwader77).Aug 10 2014, 4:02 PM
Sakari Niittymaa (niitty) added a subscriber: Sakari Niittymaa (niitty).EditedAug 15 2014, 8:56 AM

Still crashes in Blender 2.71. Windows 7 (x64). Any fix for this. Caps are very useful in digital meters and such...

Jorge Bernal (lordloki) lowered the priority of this task from 50 to Normal.May 18 2015, 6:54 AM
Jorge Bernal (lordloki) added a subscriber: Jorge Bernal (lordloki).
Porteries Tristan (panzergame) added a subscriber: Porteries Tristan (panzergame).Oct 20 2015, 6:41 PM

Can't reproduce the exact bug in 2.76.1, there's no negative index (i checked in the function), but the object mesh is not converted to physics mesh.

Porteries Tristan (panzergame) mentioned this in T39056: Pinpointing crash related to T38913 and incomplete fix: crash avoided but array caps still not accounted for in collisions. .Oct 20 2015, 6:43 PM
Aaron Carlisle (Blendify) changed the task status from Unknown Status to Resolved.Oct 20 2015, 6:59 PM
Aaron Carlisle (Blendify) claimed this task.
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).

Neither I or @Porteries Tristan (panzergame) can reproduce this anymore marking as resolved

Porteries Tristan (panzergame) added a comment.Oct 20 2015, 7:02 PM

@Aaron Carlisle (Blendify): The bug changed, it's why i can't reproduce the original/exact bug, but an other is created and can be put in this bug report.

Aaron Carlisle (Blendify) added a comment.Oct 20 2015, 7:35 PM

Please feel free to reopen

Porteries Tristan (panzergame) changed the task status from Resolved to Unknown Status.Oct 20 2015, 7:36 PM
Aaron Carlisle (Blendify) removed Aaron Carlisle (Blendify) as the assignee of this task.Oct 20 2015, 7:46 PM
Aaron Carlisle (Blendify) changed the task status from Unknown Status to Unknown Status.Jun 29 2019, 2:20 AM
Aaron Carlisle (Blendify) claimed this task.

This task is being closed because the BGE has been removed in Blender 2.8.