Maniphest T39412

Stroke Method Shortcut Creates error message
Closed, Resolved

Assigned To
Antonis Ryakiotakis (psy-fi)
Authored By
Fasit (ygtsvtr)
Mar 25 2014, 1:42 PM
Tags
  • Sculpt, Paint & Texture
Subscribers
Antonis Ryakiotakis (psy-fi)
Bastien Montagne (mont29)
Fasit (ygtsvtr)

Description

System Information
win 7 64 bit nvidia 250 gts

Blender Version
Broken: 2.70 GSOC 2013 Texture paint build from graphicall.

hash : d74d7ef
branch: soc-2013-paint

Worked: 2.70

when sculpting if you press "a" shortcut you get a error message

open the build and goto sculpt mode press "a".

Revisions and Commits

rB Blender
rBAC Blender Add-ons Contrib

Event Timeline

Fasit (ygtsvtr) created this task.Mar 25 2014, 1:42 PM
Fasit (ygtsvtr) assigned this task to Antonis Ryakiotakis (psy-fi).
Fasit (ygtsvtr) raised the priority of this task from to 90.
Fasit (ygtsvtr) updated the task description.
Fasit (ygtsvtr) added a project: Sculpt, Paint & Texture.
Fasit (ygtsvtr) edited a custom field.
Fasit (ygtsvtr) added a subscriber: Fasit (ygtsvtr).
Antonis Ryakiotakis (psy-fi) added a comment.Mar 25 2014, 1:53 PM

This is weird...it works here. Have you installed a plug-in maybe? like pie menus for instance? I have made some naming changes in the branch so some plug-ins will break.

Bastien Montagne (mont29) lowered the priority of this task from 90 to 30.Mar 25 2014, 2:07 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).
Fasit (ygtsvtr) added a comment.Mar 25 2014, 3:05 PM

I dont have pie menus but i have sculpt tools addon and mesh exctract. I will try process of elimination and see which one causes it..

Fasit (ygtsvtr) added a comment.EditedMar 25 2014, 3:33 PM

It seems the addons was not the problem but my custom brushes.

I disabled the addons it made no difference, still got error.

I enable the addons but set blender to factory settings.I get no error like this.

This loads the default brushes bundled with blender. However my startup file contains my custom created brushes. I presume the old brush settings which dont contain the new stroke settings are causing the problems...

As I guess there wont be a workaround for this.

I will open my Startup file with this build and save it as a new startup file and see if this fixes the issue.

No change unfortunately, I will have to recreate the brushes when the branch will be merged to Blender Trunk

I was wrong again the problem is caused by my custom keymaping .Sorry about that. I need to find what is causing this, because I havent changed the "a" key.

It seems the default stroke method is also "a" key, however there is also another task assaigned to "a" key, when in curve stroke mode it selects all points of the curve . Other than this I have found no other explanation for a conflict. So its up to you if you would like to close this or investigate the reason, I will update my key config with the new settings after the merge. Cheers.

Antonis Ryakiotakis (psy-fi) added a comment.Mar 26 2014, 3:26 PM

It must be due to the keymap storing all old property names then. So if they change the keymap conflicts with the new names. I'm not sure if we have an automatic conversion for that but my guess is that we do not. I must ask about how to provision for that.

Antonis Ryakiotakis (psy-fi) added a comment.Mar 26 2014, 10:35 PM

It looks like this won't be easy to solve.

Generally the name changes are made because different paint systems support different sets of stroke modes (for instance, in trunk, texture painting does not support drag dot or anchored brushes)

To fix this I will possibly make a dynamic enum that will choose the set accordingly. This I will also do in trunk so these properties can be the same across paint systems.

For you this will mean that you will have to update the naming of that operator but only once. And I will have to be more careful about naming changes from now on :).

Antonis Ryakiotakis (psy-fi) edited this Maniphest Task.Mar 26 2014, 11:05 PM
Antonis Ryakiotakis (psy-fi) changed the task status from Unknown Status to Resolved.Mar 26 2014, 11:05 PM

Closed by commit rB0adc1ba209c2.

Antonis Ryakiotakis (psy-fi) added a comment.Mar 26 2014, 11:21 PM

Hi,

It should be fixed now. To use the same keymap across branches just enter stroke_method as the property (and make sure you have a soc-paint and master branch made from commits later than tonight)

Fasit (ygtsvtr) added a comment.Mar 27 2014, 12:52 AM

Thanks a lot Psy-fi :)

Antonis Ryakiotakis (psy-fi) edited this Maniphest Task.May 12 2014, 4:45 PM