Maniphest T39627

HSL color sliders acting funky
Closed, Resolved

Assigned To
Antonis Ryakiotakis (psy-fi)
Authored By
Timo Takala (Timo)
Apr 6 2014, 11:15 PM
Tags
  • User Interface
  • BF Blender
Subscribers
Antonis Ryakiotakis (psy-fi)
Bastien Montagne (mont29)
Timo Takala (Timo)

Description

System Information
Mac OS X Lion 10.7.5

Blender Version
Broken: buildbot 2014-04-06 43fb105
Worked: ?

Short description of error
HSL color sliders work fine when you first add a color. But when you try to change the color, it shifts abruptly.

Exact steps for others to reproduce the error

  1. Open new blend file.
  2. Change Color Picker Type to HSL in User Preferences - System.
  3. Change some color value, for example Material diffuse color.
  4. Change that same color value again. Notice how the color jumps as soon as the slider moves a little bit.

Something else to try:

  1. Change the HSL color value to something easy to remember, for example: HSL: 0.5, 0.5, 0.5.
  2. Confirm.
  3. Go back to the same color. The color has changed to HSL: 0.5, 0.667, 0.75.

My guess is that Blender converts the HSL to HSV, then replaces the color numbers in the color picker with converted values. When user opens the same color picker again, numbers have changed, but the color is unchanged. When one of the sliders is moved Blender refreshes the color with these new numbers, thus causing the abrupt change of color.

One more thing to try:

  1. As previously, change the color to HSL: 0.5, 0.5, 0.5.
  2. Change Color Picker Type back to HSV in User Pref.
  3. Go back to the same color. The color values have again changed to HSL: 0.5, 0.667, 0.75.
  4. Move one of the sliders. Color changes as it should.

Revisions and Commits

rB Blender
Abandoned
rBAC Blender Add-ons Contrib

Related Objects

Event Timeline

Timo Takala (Timo) created this task.Apr 6 2014, 11:15 PM
Timo Takala (Timo) raised the priority of this task from to 90.
Timo Takala (Timo) updated the task description.
Timo Takala (Timo) added a project: BF Blender.
Timo Takala (Timo) edited a custom field.
Timo Takala (Timo) added a subscriber: Timo Takala (Timo).
Bastien Montagne (mont29) assigned this task to Antonis Ryakiotakis (psy-fi).Apr 7 2014, 9:16 AM
Bastien Montagne (mont29) added a project: User Interface.
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Antony, think this is for you?

Bastien Montagne (mont29) lowered the priority of this task from 90 to 50.Apr 7 2014, 9:17 AM
Antonis Ryakiotakis (psy-fi) edited this Maniphest Task.Apr 7 2014, 8:21 PM
Antonis Ryakiotakis (psy-fi) lowered the priority of this task from 50 to Normal.Apr 8 2014, 5:20 PM
Antonis Ryakiotakis (psy-fi) edited this Maniphest Task.Apr 11 2014, 2:13 PM
Antonis Ryakiotakis (psy-fi) changed the task status from Unknown Status to Resolved.Apr 11 2014, 2:13 PM

Closed by commit rB2d655d370d84.

Timo Takala (Timo) added a comment.Apr 11 2014, 9:08 PM

I compiled a fresh Blender. Now I got a slightly different behavior with the HSL sliders :)

If I change material diffuse color
0.5, 0.5, 0.5 becomes 0.5, 0.903, 0.523.

If I change some color in User Preferences
0.5, 0.5, 0.5 becomes 0.5, 0.665, 0.749.

Then again, it is very much possible that i messed something up with my build, so I'll try with a buildbot build tomorrow.

Antonis Ryakiotakis (psy-fi) added a comment.Apr 11 2014, 10:46 PM

No, you are right, pushed a fix for that right now, thanks!

Antonis Ryakiotakis (psy-fi) edited this Maniphest Task.May 12 2014, 4:47 PM
Brecht Van Lommel (brecht) mentioned this in T56741: Color Picker Value Bug.Dec 11 2018, 7:57 PM