Maniphest T47169

Improve Curve extrude
Closed, ResolvedTO DO

Assigned To
Deep Majumder (dmcoder)
Authored By
Campbell Barton (campbellbarton)
Jan 12 2016, 1:43 PM
Tags
  • Good First Issue
  • BF Blender
  • Modeling
Subscribers
Ali Jaya Meilio LIE (alijaya)
André Lourenço (alourenco)
C.G.Vedant (Chipe1)
Campbell Barton (campbellbarton)
Deep Majumder (dmcoder)
Duarte Farrajota Ramos (duarteframos)
Evan Wilson (EAW)
6 More Subscribers
Tokens
"Like" token, awarded by Schiette."Love" token, awarded by duarteframos.

Description

Ability to extrude contiguous selected segments of 2d curves. (currently it duplicates the points only)

See: https://www.youtube.com/watch?v=Bs4IAxU2c3U

Python reference implementation: P312

Revisions and Commits

Abandoned
rB Blender
Abandoned
D6982

Event Timeline

Campbell Barton (campbellbarton) created this task.Jan 12 2016, 1:43 PM
Campbell Barton (campbellbarton) raised the priority of this task from to Normal.
Campbell Barton (campbellbarton) updated the task description.
Campbell Barton (campbellbarton) added a project: Good First Issue.
Campbell Barton (campbellbarton) edited a custom field.
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) updated the task description.Jan 12 2016, 1:54 PM
C.G.Vedant (Chipe1) added a subscriber: C.G.Vedant (Chipe1).Jan 17 2016, 8:05 PM
C.G.Vedant (Chipe1) added a comment.Jan 17 2016, 8:08 PM

This is stupid, but I don't understand what to do.
There is a code and a video demonstrating it. The task looks easy and I am willing to do it if it isn't taken

Yousif Rehab (loufis) added a subscriber: Yousif Rehab (loufis).Mar 17 2016, 2:30 PM
Sam Bickley (samb96) claimed this task.Apr 5 2016, 3:31 AM
Sam Bickley (samb96) added a subscriber: Sam Bickley (samb96).

I'd like to work on this as long as nobody else is.

Sam Bickley (samb96) mentioned this in D1918: T47169 Improve Curve extrude.Apr 12 2016, 4:43 AM
Sam Bickley (samb96) added a revision: D1918: T47169 Improve Curve extrude.Apr 12 2016, 4:45 AM
Tom Corwine (tcorwine) added a subscriber: Tom Corwine (tcorwine).Nov 1 2016, 9:43 PM
Karthikeyan Iyer (karthik24iyer) added a subscriber: Karthikeyan Iyer (karthik24iyer).Nov 14 2016, 5:11 PM

I would like to work on this bug if no one else has

Duarte Farrajota Ramos (duarteframos) awarded a token.Jan 31 2017, 6:23 PM
Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).
Duarte Farrajota Ramos (duarteframos) added a comment.Jan 31 2017, 6:30 PM

Very welcome improvement, certainly handy!

Campbell Barton (campbellbarton) removed Sam Bickley (samb96) as the assignee of this task.Mar 3 2017, 3:06 PM
raja kedia (decoda) claimed this task.Mar 28 2017, 2:13 PM
raja kedia (decoda) added a subscriber: raja kedia (decoda).

I would like to work with this.

Campbell Barton (campbellbarton) removed raja kedia (decoda) as the assignee of this task.Mar 30 2017, 2:45 AM

@raja kedia (decoda), thats fine - but I've been removing assignments from quick hacks.
Too often people loose interest and don't un-assign.

Erdem Derebasoglu (derebaba) added a subscriber: Erdem Derebasoglu (derebaba).Sep 15 2017, 3:53 PM

The video shows that you can already do it. Doesn't it mean the task is done? Or is there more to it?

Duarte Farrajota Ramos (duarteframos) added a comment.Sep 16 2017, 3:40 AM

It may be working but it is not committed to master nor included in any official release.
This is indeed a useful improvement though, would be nice to have for 2.8. Is that feasible?

André Lourenço (alourenco) added a subscriber: André Lourenço (alourenco).Jan 23 2018, 3:29 AM
Ali Jaya Meilio LIE (alijaya) added a subscriber: Ali Jaya Meilio LIE (alijaya).May 16 2018, 3:27 AM
Ali Jaya Meilio LIE (alijaya) added a comment.May 16 2018, 3:36 AM

Hi, I just want to make sure, so we need to implement this operator in C code right? And for the operation behaviour, there's something that's not clear.
Is it only working for continuous selection or it can work in any condition? If we select disjoint selection, what will happen? And should be the edge produced by the extrude be straight, or it keeps the handle like before, or there's some adjustment for the handle?
From the python code above, I can see that he use subdivision operator to create a new node, and if I remember correctly, the subdivision change the handle position. I wonder if it's a wanted behaviour.

Matthew (Loading_M_) added a subscriber: Matthew (Loading_M_).May 3 2019, 5:31 PM
Matthew (Loading_M_) added a comment.May 3 2019, 5:48 PM

This behavior does not appear to be present in the latest build, so I would like to take this on as an early issue. Is there anything in particular I should be aware of when working on this task.

Campbell Barton (campbellbarton) added a comment.May 6 2019, 6:26 AM

Tested on a bezier curve and this is still duplicating points.

@Ali Jaya Meilio LIE (alijaya), the python code is just a proof of concept, it's logic shouldn't be copied directly to C.

George Vogiatzis (Gvgeo) mentioned this in T63009: Quick Hacks cleanup.May 6 2019, 8:13 AM
Matthew (Loading_M_) added a revision: D4812: Curve extrude operator.May 6 2019, 8:32 PM
Matthew (Loading_M_) claimed this task.EditedMay 6 2019, 8:34 PM

I have created and tested a patch that implements the requested functionality: D4812

Dalai Felinto (dfelinto) removed Matthew (Loading_M_) as the assignee of this task.Dec 23 2019, 4:37 PM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.
Aaron Carlisle (Blendify) changed the subtype of this task from "Report" to "To Do".Feb 12 2020, 7:17 AM
Aaron Carlisle (Blendify) edited projects, added BF Blender, Modeling; removed Tracker Curfew.
Deep Majumder (dmcoder) added a subscriber: Deep Majumder (dmcoder).Feb 26 2020, 2:54 PM

I would like to work on this feature

Pieter Schiettecatte (Schiette) awarded a token.Feb 26 2020, 2:57 PM
Pieter Schiettecatte (Schiette) added a subscriber: Pieter Schiettecatte (Schiette).
Deep Majumder (dmcoder) added a comment.Mar 1 2020, 7:41 AM

How do I test my code (other than checking that it works) and how do I submit my code for review?

Erdem Derebasoglu (derebaba) removed a subscriber: Erdem Derebasoglu (derebaba).Mar 1 2020, 11:15 AM
Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Mar 1 2020, 4:23 PM
Deep Majumder (dmcoder) claimed this task.Mar 1 2020, 4:43 PM

I have submitted code for this in D6980

Germano Cavalcante (mano-wii) added a revision: D6982: Improve Curve extrude.Mar 1 2020, 9:19 PM
Germano Cavalcante (mano-wii) closed this task as Resolved by committing rB38685b5a3976: Edit Curve: Improve Curve extrude.Mar 31 2020, 5:55 PM
Germano Cavalcante (mano-wii) added a commit: rB38685b5a3976: Edit Curve: Improve Curve extrude.