Maniphest T47813

Cycles Standalone not respecting integrator sample_clamp_direct
Closed, Resolved
Actions

Assigned To
Thomas Dinges (dingto)
Authored By
Jeff Witthuhn (witthuhn)
Mar 16 2016, 3:33 AM
Tags
  • Cycles
Subscribers
Jeff Witthuhn (witthuhn)
Sergey Sharybin (sergey)
Tautvydas Andrikys (esminis)
Thomas Dinges (dingto)

Description

System Information
Windows 8.1 64-bit

Blender Version
Broken: Latest git from the Cycles standalone repository. At this commit https://developer.blender.org/rCae057c51edfc85661574b0db5cf411b5d145ffbb

Short description of error
Cycles standalone does not clamp sampled values, regardless of the integrator's sample_clamp_direct value.

Cycles does respect this value when set through the blender UI in 2.77RC2. Only cycles standalone has this issue.

Exact steps for others to reproduce the error
Attached a short xml file to reproduce this in Cycles standalone. It contains a cube with an emission shader of strength 10, and sample_clamp_direct set to 0.5. This should produce a render of a gray cube, but instead it will render white.

scene_cube_test.xml996 BDownload

Revisions and Commits

rC Cycles
rC5722030a8e74 Fix T47813: Cycles Standalone not respecting integrator sample_clamp_direct
rB Blender
rB9604db76505f Fix T47813: Cycles Standalone not respecting integrator sample_clamp_direct

Related Objects

Event Timeline

Jeff Witthuhn (witthuhn) created this task.Mar 16 2016, 3:33 AM
Jeff Witthuhn (witthuhn) raised the priority of this task from to 90.
Jeff Witthuhn (witthuhn) updated the task description.
Jeff Witthuhn (witthuhn) added a project: Cycles.
Jeff Witthuhn (witthuhn) edited a custom field.
Jeff Witthuhn (witthuhn) added a subscriber: Jeff Witthuhn (witthuhn).
Thomas Dinges (dingto) claimed this task.Mar 16 2016, 4:27 PM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).

Will check.

Thomas Dinges (dingto) lowered the priority of this task from 90 to Normal.Mar 16 2016, 4:27 PM
Jeff Witthuhn (witthuhn) added a comment.Apr 6 2016, 1:21 PM

I took a closer look at this and it seems the problem was that the scene's Film::use_sample_clamp must be set to true for either direct or indirect clamp to work, it defaults to false and isn't exposed through the XML api.

Thomas Dinges (dingto) added a comment.Apr 6 2016, 2:35 PM

Yes, that is the reason, but it's not clear yet to me how to properly fix this. Ideally we reshuffle some code, so setting this flag happens in /render and not in the exporter (Blender or XML).

Sergey Sharybin (sergey) merged a task: T48121: Blender Cycles standalone does not properly read/enable sample clamping from XML.Apr 12 2016, 11:18 AM
Sergey Sharybin (sergey) added subscribers: Sergey Sharybin (sergey), Tautvydas Andrikys (esminis).
Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved by committing rB9604db76505f: Fix T47813: Cycles Standalone not respecting integrator sample_clamp_direct.Apr 13 2016, 10:40 AM
Sergey Sharybin (sergey) added a commit: rB9604db76505f: Fix T47813: Cycles Standalone not respecting integrator sample_clamp_direct.
Sergey Sharybin (sergey) added a commit: rC5722030a8e74: Fix T47813: Cycles Standalone not respecting integrator sample_clamp_direct.