Maniphest T48704

Measureit by Antonioya (fix current review bugs)
Closed, ResolvedPATCH

Assigned To
Antonio Vazquez (antoniov)
Authored By
Brendon Murphy (meta-androcto)
Jun 22 2016, 1:40 AM
Tags
  • Add-ons (Community)
Subscribers
Antonio Vazquez (antoniov)
Brendon Murphy (meta-androcto)
Campbell Barton (campbellbarton)

Description

Hi, This is the task for measureit addon by @Antonio Vazquez (antoniov)
This addon provider render able measure tools in the 3d view.
BA Thread: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools
Git hub: https://github.com/Antonioya/blender/tree/master/measureit
File: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools
Thanks

Related Objects

Mentioned In
rBAcf4ac00ea0aa: add mesureit to release "warning temporary status" pending T48704
rBAC22c38f1877df: initial commit: measureit by Antonioya: T48704

Event Timeline

Brendon Murphy (meta-androcto) created this task.Jun 22 2016, 1:40 AM
Brendon Murphy (meta-androcto) claimed this task.
Brendon Murphy (meta-androcto) raised the priority of this task from to 90.
Brendon Murphy (meta-androcto) lowered the priority of this task from 90 to 50.
Brendon Murphy (meta-androcto) updated the task description.
Brendon Murphy (meta-androcto) added a project: Add-ons (Community).
Brendon Murphy (meta-androcto) edited a custom field.
Brendon Murphy (meta-androcto) added subscribers: Brendon Murphy (meta-androcto), Antonio Vazquez (antoniov).
Brendon Murphy (meta-androcto) renamed this task from Measureit by Antonioya (New Addons Contrib to Measureit by Antonioya (New Addons Contrib).Jun 22 2016, 1:49 AM
Brendon Murphy (meta-androcto) mentioned this in rBAC22c38f1877df: initial commit: measureit by Antonioya: T48704.Jun 29 2016, 7:00 AM
Brendon Murphy (meta-androcto) renamed this task from Measureit by Antonioya (New Addons Contrib) to Measureit by Antonioya (Promote Addons Release).Jul 3 2016, 11:25 AM
Brendon Murphy (meta-androcto) added a comment.Jul 26 2016, 12:09 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).EditedJul 27 2016, 9:25 AM

Checked over the addon,

Blocking Issues

  • Saving an image is using the "//" prefix which isn't expanded, call bpy.path.abspath() on the path before passing to save_render. (Currently Im getting an error Error: MeasureIt: Unable to save temporary render image. Define a valid render path)
  • try/except is used in a way which can hide real bugs (measureit_geometry.py:92 has ~540 lines of code in a try block, where failing on a non index error will pass) ... in general this should be avoided since a mistake in the code, or a minor API change can cause an error which will silently fail.

General Issues

Brendon Murphy (meta-androcto) reassigned this task from Brendon Murphy (meta-androcto) to Antonio Vazquez (antoniov).Jul 27 2016, 10:00 AM
Brendon Murphy (meta-androcto) mentioned this in rBAcf4ac00ea0aa: add mesureit to release "warning temporary status" pending T48704.Aug 3 2016, 2:48 AM
Brendon Murphy (meta-androcto) added a comment.Aug 3 2016, 2:54 AM

@Antonio Vazquez (antoniov)
measureit is committed to release.

note: there are some pending issues here. I have discussed with antoniov & he is aware of issues & will attend to these after gp2 work is finalized & during bcon3.
added warning to bl info 'warning': 'Temporary: pending review fixes T48704',
thanks & welcome.

Brendon Murphy (meta-androcto) renamed this task from Measureit by Antonioya (Promote Addons Release) to Measureit by Antonioya (fix current review bugs).Aug 3 2016, 2:55 AM
Antonio Vazquez (antoniov) added a comment.Aug 10 2016, 11:31 AM

I have done several commits to Addon repo with the fixes. I have tested in Windows but I would like someone using other OS will test, especially the render option with "//" prefix.

Brendon Murphy (meta-androcto) changed the task status from Unknown Status to Resolved.Aug 10 2016, 11:39 AM

thanks @Antonio Vazquez (antoniov) & welcome to addons project
closing as resolved