Maniphest T48847

I can't use the Keyboard Shortcuts "]" (select: "After Current Frames") in Dope Sheet Editor or Graph Editor
Closed, Resolved

Assigned To
Bastien Montagne (mont29)
Authored By
Jefferson Rausseo (jefrau)
Jul 14 2016, 1:24 AM
Tags
  • BF Blender
Subscribers
Bastien Montagne (mont29)
Danni Coy (danni)
Jefferson Rausseo (jefrau)

Description

System Information
GNU/Linux Manjaro 64bits
Nvidia 8600 GT

Blender Version
Broken: 2.77 91bda21
Worked: 2.77a Official Build

Short description of error
If I try to use the Keyboard Shortcuts "]" (select: "After Current Frames") in Dope Sheet Editor or Graph Editor it does not work, but the Keyboard Shortcuts "[" (select: "Before Current Frames") is fine.


Exact steps for others to reproduce the error

  1. Open the .blend file.
  2. Press "[", is fine.
  3. Press "]", without selection.

Revisions and Commits

rB Blender

Related Objects

Mentioned Here
rB56d2f4c20a8e: Fix T49252: Crash when image textures used with true displacement
rB16cb9391634d: Fix T48911: Fix T48847: Issues with some shortcuts on non-US latin keyboards…
T48911: When two keymaps are configured on the system and the current isn't the first one Blender use both
rB3d7cf808b8ee: Add copy/make_local to movieclip datablock.
rBe20d306ffa8a: Cleanup: pep8
rB91bda21cfe25: Fix T48845: Crash when right-clicking on a curve property

Event Timeline

Jefferson Rausseo (jefrau) created this task.Jul 14 2016, 1:24 AM
Bastien Montagne (mont29) lowered the priority of this task from 90 to 30.Jul 15 2016, 4:01 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

I don’t understand what the two screenshots are for here?

Anyway, please give us your keyboard layout, that kind of shortcut only works fine with US qwerty keyboard iirc. At least here on my french keyboard, ] works OK but [, which is same key as 5, is eaten/replaced by 5 (that’s a 'hack' to make layer switching work with all keyboard layouts). As a rule of thumb, any shortcut which needs a modifier key (shift or alt-gr) on a given layout is likely to not work, Blender is designed by default for English QWERTY layout.

Jefferson Rausseo (jefrau) added a comment.Jul 15 2016, 5:24 PM

Keyboard layout: Generic 105-Key INTL.

I have not modified the keyboard layout in Blender. With the version 2.77a Build Official works fine, but my compilation 91bda21 not works fine.

I removed the folder "./config/blender/2.77" and still does not work fine.

Bastien Montagne (mont29) added a comment.Jul 15 2016, 5:49 PM

Not aware of a Generic 105-Key INTL layout… please make a screenshot of your keybaord's layout.

Anyway, this shall not have anything to do with blender configuration… Can you try to enable event debugging (--debug-events commandline option) and attach here as text file what's printed in console when you hit [ and ] ?

Jefferson Rausseo (jefrau) added a comment.Jul 15 2016, 6:13 PM

Run with --debug-evets:

In Blender 2.77a Official Build:
I press "Alt Gr + [" -> wm_handlers_do_intern: handled! 'ACTION_OT_select_leftright'
I press "Alt Gr + ]" -> wm_handlers_do_intern: handled! 'ACTION_OT_select_leftright'

In Blender 2.77 compile 91bda21:
I press "Alt Gr + [" -> wm_handlers_do_intern: handled! 'ACTION_OT_select_leftright'
I press "Alt Gr + ]" -> Nothing happens.

Bastien Montagne (mont29) added a comment.Jul 23 2016, 10:57 AM

You should get more than that with --debug-events option, all key events would be printed out in console - would allow us to see what events is actually generated by your 'altgr-]' (my bet would be, it generates a '+' event instead). Please attach here as text file what's printed out by Blender in console when you hit those two keys.

But again, altgr-keys shortcuts are rather fragile and not always working with Blender, that’s known limitation more than a bug.

Bastien Montagne (mont29) added a comment.Jul 29 2016, 3:42 PM

OK… so turned out release builds were not printing out same things as debug builds (thanks Sergey for finding that out). As been fixed today in master, so please redo the check with build of tomorrow and attach here console output. ;)

Jefferson Rausseo (jefrau) added a comment.Jul 30 2016, 2:53 PM

With my compilation (e20d306):

  • Dope sheet: Not work

  • Text editor: Work

With Buildbot (3d7cf80):

  • Dope sheet: Not work

  • Text editor: Work

With 2.77a Official Release:

  • Dope sheet: Work

Bastien Montagne (mont29) changed the task status from Unknown Status to Unknown Status.Sep 2 2016, 9:59 AM
Bastien Montagne (mont29) claimed this task.

Text editor is using utf8 value of the event, while shortcuts handling uses its type. As you can see in your logs, type of altgr-] is PLUS, when altgr-[ generates expected LEFT_BRACKET event. This is entirely handled through X11 system, we try to be smart and fallback to ascii value to generate our own Blender event type in case 'keytype' fails, but all in all, it boils down to: altgr-key (or shift-key) combinations are not designed for shortcuts, they may work in some cases, but there is no way for us to guarantee it.

In other words, either you use US keyboard layout with Blender, or accept to not be able to use pre-defined shortcuts using keys not directly accessible on your layout (i.e. without any shift or altgr trick), or define your own shortucts…

Bastien Montagne (mont29) added a comment.Sep 2 2016, 4:27 PM

On second thoughts, this shall be fixable, and is kind of same issue as T48911… have patch for it, so will merge this report together :)

Bastien Montagne (mont29) changed the task status from Duplicate to Resolved by committing rB16cb9391634d: Fix T48911: Fix T48847: Issues with some shortcuts on non-US latin keyboards….Sep 3 2016, 5:53 PM
Bastien Montagne (mont29) added a commit: rB16cb9391634d: Fix T48911: Fix T48847: Issues with some shortcuts on non-US latin keyboards….
Danni Coy (danni) added a subscriber: Danni Coy (danni).Sep 15 2016, 10:51 AM

Commit 16cb9391634dcc50ee674852b80c70ccb5f05c43
Changes the behaviour of blender under X11 for non qwerty layouts in a really significant way.

Previously blender used the hardware keysim so that keys stayed in the same place no matter which keyboard layout is being used after this commit blender looks up the current layout keycode.

In an application like blender which is designed to be used with one hand on the keyboard and the other on a mouse/tablet the physical position of the key is *way* more important than what is printed on it and the current layout is designed to be ergonomic on a qwerty keyboard, the more the layout deviates from qwerty the less ergonomic it gets.

In my case I would be forced to choose between learning a much less ergomic layout from scratch, constantly switching keyboard layouts every time I want to enter text or rebinding practically every key in the application.

Danni Coy (danni) added a comment.Sep 15 2016, 12:04 PM

ok it seems that commit 56d2f4c20a8efcc839afbe31a3de2da15c34b54f
similtaneously fixes the problem then breaks it again in a different way.

could somebody try to explain to me what this commit is trying to do...