Maniphest T53481

Showing linked scene in 2.8, crashes on load
Closed, Resolved
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Campbell Barton (campbellbarton)
Dec 6 2017, 7:02 AM
Tags
  • BF Blender: 2.8
  • Code Quest
Subscribers
• <SPAMMER> (JeoJohn)
Campbell Barton (campbellbarton)
Julian Eisel (Severin)

Description

There is a bug in 2.8x where saving with an active linked scene crashes on reload.
There isn't much to redo this error

In the attached file:

  • Open link_dst.blend
  • Switch the scene to Scene Link
  • Save, Load (crash)

7ca8af4cc82010c85fa6d7f663977117eb23b6f9

test.tar.bz2140 KBDownload

See P567 for the crash log, although Im not sure this points to the root cause.

From looking into this it seems readfile.c expects the view_layer pointer in the workspace to exist in the scene - which isn't the case when the scene is linked.

Revisions and Commits

rB Blender
rBd59b74adb38f Fix T53481: Linked scene crashes on load

Related Objects

Event Timeline

Campbell Barton (campbellbarton) created this task.Dec 6 2017, 7:02 AM
Campbell Barton (campbellbarton) updated the task description.Dec 6 2017, 7:04 AM
Campbell Barton (campbellbarton) updated the task description.
Campbell Barton (campbellbarton) updated the task description.Dec 6 2017, 7:09 AM
Dalai Felinto (dfelinto) assigned this task to Julian Eisel (Severin).Dec 6 2017, 1:00 PM
• <SPAMMER> (JeoJohn) added a subscriber: • <SPAMMER> (JeoJohn).Dec 7 2017, 9:10 AM
This comment was removed by Campbell Barton (campbellbarton).
Sergey Sharybin (sergey) lowered the priority of this task from 90 to 50.Dec 7 2017, 3:05 PM
Campbell Barton (campbellbarton) moved this task from Backlog to General Bugs on the BF Blender: 2.8 board.Jan 24 2018, 2:34 AM
Julian Eisel (Severin) added a comment.EditedJan 29 2018, 10:16 PM

This raises the question on how view-layers should be handled when linking scenes. Should we link view-layers with them? If so how can we do this (since view-layers aren't IDs)?
I don't recall if we ever discussed this.

EDIT - NVM, read next comment.

Julian Eisel (Severin) added a comment.Feb 23 2018, 10:49 AM

Bah... I'm a moron :| View-layers belong to the scene data-block, so we can read them just fine when linking. NVM then, this is not an issue...

Note that this is a symptom of T54140.

Campbell Barton (campbellbarton) claimed this task.May 22 2018, 12:33 PM
Campbell Barton (campbellbarton) added a project: Code Quest.
Campbell Barton (campbellbarton) moved this task from Tasks to Spring Bugs on the Code Quest board.
Campbell Barton (campbellbarton) added a subscriber: Julian Eisel (Severin).
Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rBd59b74adb38f: Fix T53481: Linked scene crashes on load.May 23 2018, 12:55 PM
Campbell Barton (campbellbarton) added a commit: rBd59b74adb38f: Fix T53481: Linked scene crashes on load.