Maniphest T54336

Extend property of Lasso select tool in Node editor does not work
Closed, Resolved
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Ludvik Koutny (rawalanche)
Mar 16 2018, 12:22 PM
Tags
  • BF Blender
Subscribers
Ludvik Koutny (rawalanche)
Philipp Oeser (lichtwerk)

Description

System Information
Windows 10, GTX1080Ti

Blender Version
Broken: 2.79a
Worked: Probably never

Short description of error
Extend property of Lasso select tool in Node editor section of input mapping preferences has no effect. When disabled, lasso selection still remains additive.

EDIT:
It appears same is the case for Mask Editing mode of UV/Image editor.

Revisions and Commits

rB Blender
rBd78894eb3e1b Fix T54336: Extend property of Lasso select tool in Node editor does not work
D3360rB54f2e58452bb Fix T54336: Extend property of Lasso select tool in Node editor does not work

Related Objects

Event Timeline

Ludvik Koutny (rawalanche) created this task.Mar 16 2018, 12:22 PM
Ludvik Koutny (rawalanche) updated the task description.Mar 16 2018, 5:03 PM
Philipp Oeser (lichtwerk) claimed this task.Apr 23 2018, 3:10 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm this, atm. this is just not implemented, but is a nice TODO.

Will look at this shortly.

Philipp Oeser (lichtwerk) added a comment.May 13 2018, 9:59 AM

D3360 should do it for the Node Editor, will look into Mask shortly

Philipp Oeser (lichtwerk) mentioned this in D3361: Fix Extend property of Lasso select tool in Mask editor not working.May 13 2018, 11:17 AM

D3361 should do it for Masks

Ludvik Koutny (rawalanche) added a comment.EditedMay 13 2018, 7:20 PM

I would strongly suggest to have just one global border and lasso selection implementation which is referenced by all the editors, rather than having unique implementation for each editor and trying to keep its codebase manually in sync. There are quite a few more inconsistencies of lasso and border selection keymap properties between the different editor. This bug report is just a small example of it.

Philipp Oeser (lichtwerk) added a comment.May 15 2018, 10:36 AM

@Ludvik Koutny (rawalanche): could you report the other inconsistencies as well? (just post into this report, I'll take care of them -- and see if it makes sense generalize some code here)

Ludvik Koutny (rawalanche) added a comment.May 15 2018, 10:48 AM
In T54336#502722, @Philipp Oeser (lichtwerk) wrote:

@Ludvik Koutny (rawalanche): could you report the other inconsistencies as well? (just post into this report, I'll take care of them -- and see if it makes sense generalize some code here)

Will do, but doing inspection of the entire input editor takes a while, so it won't be sooner than in a few days :)

Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved by committing rB54f2e58452bb: Fix T54336: Extend property of Lasso select tool in Node editor does not work.May 24 2018, 8:36 AM
Philipp Oeser (lichtwerk) added a commit: rB54f2e58452bb: Fix T54336: Extend property of Lasso select tool in Node editor does not work.
Philipp Oeser (lichtwerk) added a commit: rBd78894eb3e1b: Fix T54336: Extend property of Lasso select tool in Node editor does not work.