Maniphest T54341

Particle Instance doesn't preserve edge data
Closed, ResolvedTO DO
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Serge Lyatin (SergeL)
Mar 16 2018, 9:11 PM
Tags
  • BF Blender
  • Modifiers
Subscribers
Philipp Oeser (lichtwerk)
Serge Lyatin (SergeL)
Sergey Sharybin (sergey)
Steffen Dünner (SteffenD)
Sybren A. Stüvel (sybren)

Description

System Information
Win10 64bit

Blender Version
Broken: 2.79a

Short description of error
Plane with smooth Subsurf is corrected with creases to keep angles sharp. If Subsurf is placed after Instancer, then creases won't work. Bevel weight and sharp edges also don't work.

Exact steps for others to reproduce the error

Crease.blend85 KBDownload

Revisions and Commits

rB Blender
rB288d7794d4c6 Fix T54341: Particle Instance Modifier doesn't preserve edge data

Related Objects

Event Timeline

Serge Lyatin (SergeL) created this task.Mar 16 2018, 9:11 PM
Steffen Dünner (SteffenD) added a subscriber: Steffen Dünner (SteffenD).Mar 16 2018, 9:17 PM
Philipp Oeser (lichtwerk) claimed this task.Apr 20 2018, 1:04 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to Normal.
Philipp Oeser (lichtwerk) added subscribers: Sergey Sharybin (sergey), Philipp Oeser (lichtwerk).

This is a limitation to the current Particle Instance modifier (not a bug though).

It doesnt handle calculating/copying edges/edgedata itself, but instead uses the more generic CDDM_calc_edges here (which has no clue of the original meshes edgedata)

It could be done though [modifiers like e.g. Array can handle this nicely], think this is a nice TODO, will put on my desk and have a look later.
Unless @Sergey Sharybin (sergey) thinks this is a waste of time and will be part of rewrite/overhaul anyways?

Philipp Oeser (lichtwerk) edited a custom field.Apr 20 2018, 1:04 PM
Sergey Sharybin (sergey) added a comment.Apr 20 2018, 1:41 PM

@Philipp Oeser (lichtwerk), this is something what we should support indeed. Mind looking into this? Shouldn't be hard to add support :)

Philipp Oeser (lichtwerk) added a subscriber: Sybren A. Stüvel (sybren).May 3 2018, 3:56 PM

@Sergey Sharybin (sergey): got it working, will post patch tomorrow (just saying, so @Sybren A. Stüvel (sybren) is not porting this modifier over in 2.8 before we merge?)

Sybren A. Stüvel (sybren) added a comment.May 3 2018, 5:46 PM

I'll leave porting the Particle Instance modifier to @Philipp Oeser (lichtwerk) then ;-)

Maybe poke me at T54737 once it's either ported or fixed up enough for me to port?

Philipp Oeser (lichtwerk) added a comment.May 3 2018, 10:58 PM

possible fix: D3199

Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved by committing rB288d7794d4c6: Fix T54341: Particle Instance Modifier doesn't preserve edge data.May 4 2018, 9:24 AM
Philipp Oeser (lichtwerk) added a commit: rB288d7794d4c6: Fix T54341: Particle Instance Modifier doesn't preserve edge data.