Maniphest T54438

Sequencer Scene preivew Color Management is broken
Closed, Resolved
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Clément Foucault (fclem)
Mar 27 2018, 3:36 PM
Tags
  • Video Sequencer
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Dalai Felinto (dfelinto)
Sergey Sharybin (sergey)

Description

Blender 2.8
Failling : dff7f55cd069a15493db00aef8f28f4f3be24b8f
Working : unknown

seq_eevee.blend137 KBDownload

Final display space is kind of broken for the scene preview strip.

Draw manager is outputing linear color into a byte buffer (could be float buffer if we want).
This byte buffer has the color management of the sequencer scene applied to it.

So maybe it would be a good idea to just output the byte buffer to the right display space? or keep a linear buffer and color manage in sequencer?
I don't know which color space should be use in this case, the scene that contains the sequencer or the scene of the strip?

This is tricky to debug because of this bug T54437

Related Objects

Mentioned In
T60632: Blender Render scene looks different in view port vs. Video Sequence Editor
Mentioned Here
T54437: Sequencer preview uses last updated scene
rBdff7f55cd069: GPUFramebuffer: Fix compiler warning about return value.

Event Timeline

Clément Foucault (fclem) lowered the priority of this task from 90 to 50.Mar 27 2018, 3:36 PM
Clément Foucault (fclem) created this task.
Sergey Sharybin (sergey) reassigned this task from Sergey Sharybin (sergey) to Clément Foucault (fclem).Mar 28 2018, 11:01 AM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Byte buffer is supposed to be in display space, which is sRGB for current OpenGL in master. If you want to output linear space, do so to the float buffer. If you want to keep using byte buffer, apply OCIO GLSL on it.

This is nothing i can fix here, you're violating the existing design.

Christopher_Anderssarian added a project: Video Sequencer.Mar 28 2018, 4:14 PM
Brecht Van Lommel (brecht) edited projects, added BF Blender; removed BF Blender: 2.8.Dec 11 2018, 3:09 PM
Richard Antalik (ISS) mentioned this in T60632: Blender Render scene looks different in view port vs. Video Sequence Editor.Feb 22 2019, 8:21 PM
Brecht Van Lommel (brecht) reassigned this task from Clément Foucault (fclem) to Jeroen Bakker (jbakker).Jun 6 2019, 5:29 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

@Jeroen Bakker (jbakker), can you check if is fixed or needs additional work? This is quite an old report.

Jeroen Bakker (jbakker) changed the task status from Unknown Status to Resolved.Jun 7 2019, 8:52 AM

Solved with recent changes.