Maniphest T54558

Make Single User on an action or world in Outliner with the view Blender File crash blender
Closed, ResolvedBUG

Assigned To
Dalai Felinto (dfelinto)
Authored By
alexis echemendia (aluba)
Apr 10 2018, 3:29 PM
Tags
  • BF Blender (2.82)
  • Datablocks and Libraries
  • Add-ons (BF-Blender)
  • User Interface
Subscribers
alexis echemendia (aluba)
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Johnny Varila (zoni527)
Joshua Leung (aligorith)
Kaspar Kuldkepp (kasparkuldkepp)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system and graphics card
Windows 10
Nvidia 970m

Blender Version


2.79b

Short description of error
Navigate to outliner select the view type as Blender File-> Actions
right click in one action and select "Make Single User" Blender crash!!!.

Exact steps for others to reproduce the error
right click in one action and select "Make Single User" Blender crash!!! (Select the filter "Blender File" in the outliner).

Related Objects

Mentioned In
T71673: Making action single user from Blender File -menu crashes blender
Mentioned Here
rB9ca2cbdcea6a: Outliner: Don't show id operations (make single user) when not supported
rBdd4e0cd3e30a: DNA/RNA: add 'py_instance' for ID types

Event Timeline

alexis echemendia (aluba) created this task.Apr 10 2018, 3:29 PM
Philipp Oeser (lichtwerk) claimed this task.Apr 10 2018, 3:35 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Confirmed [wont happen in e.g. the DopeSheet though...]
Will look into it tomorrow

Philipp Oeser (lichtwerk) reassigned this task from Philipp Oeser (lichtwerk) to Campbell Barton (campbellbarton).Apr 11 2018, 12:11 PM
Philipp Oeser (lichtwerk) added a subscriber: Campbell Barton (campbellbarton).

@alexis echemendia (aluba) : this is current master, right? [2.79b official release wont crash here...]

git bisects this down to rBdd4e0cd3e30a8865798 (which isnt in 2.79b)

1   rna_AnimData_action_editable  rna_animation.c      99    0x29aab2a 
2   RNA_property_editable         rna_access.c         1820  0x2984257 
3   id_single_user                library.c            691   0x27c6005 
4   singleuser_action_cb          outliner_tools.c     497   0x1adfbe3 
5   outliner_do_libdata_operation outliner_tools.c     267   0x1adf3b4 
6   outliner_do_libdata_operation outliner_tools.c     271   0x1adf419 
7   outliner_do_libdata_operation outliner_tools.c     271   0x1adf419 
8   outliner_id_operation_exec    outliner_tools.c     1237  0x1ae190c 
9   WM_menu_invoke_ex             wm_operators.c       1145  0x1a21fb6 
10  WM_menu_invoke                wm_operators.c       1164  0x1a22103 
11  wm_operator_invoke            wm_event_system.c    1143  0x1a0aa29 
12  wm_operator_call_internal     wm_event_system.c    1336  0x1a0b113 
13  WM_operator_name_call_ptr     wm_event_system.c    1384  0x1a0b303 
14  ui_apply_but_funcs_after      interface_handlers.c 798   0x1d7a2c6 
15  ui_popup_handler              interface_handlers.c 10210 0x1d93b45 
16  wm_handler_ui_call            wm_event_system.c    465   0x1a090f2 
17  wm_handlers_do_intern         wm_event_system.c    2100  0x1a0ccfc 
18  wm_handlers_do                wm_event_system.c    2184  0x1a0cf98 
19  wm_event_do_handlers          wm_event_system.c    2464  0x1a0db12 
20  WM_main                       wm.c                 508   0x1a01a0c

note (not sure it's really related): before that commit I still get following Warning: No AnimData to set action on

BLI_assert failed: /lichtwerk/01_projects/0000_HACK_BlenderSourceDevelopment/HACK_Produktion/11_Git/blender/source/blender/blenkernel/intern/idcode.c:308, BKE_idcode_to_index(), at '0'
./bin/blender(BLI_system_backtrace+0x26) [0x2bff3f6]
./bin/blender(BKE_idcode_to_index+0x356) [0x27b2afb]
./bin/blender(DAG_id_type_tag+0x7a) [0x275fe3b]
./bin/blender() [0x275cd0e]
./bin/blender(DAG_id_tag_update_ex+0xca) [0x275fb3b]
./bin/blender(DAG_id_tag_update+0x2f) [0x275fdbe]
./bin/blender() [0x29afae3]
./bin/blender() [0x29896b7]
./bin/blender(RNA_property_update+0x50) [0x29897e7]
./bin/blender(id_single_user+0xe1) [0x27d4b2f]
./bin/blender() [0x1af4136]
./bin/blender() [0x1af38da]
./bin/blender() [0x1af393f]
./bin/blender() [0x1af393f]
./bin/blender() [0x1af5e56]
./bin/blender(WM_menu_invoke_ex+0xe1) [0x1a364da]
./bin/blender(WM_menu_invoke+0x2c) [0x1a36627]

Would do futher investigation myself, but for now I've hit my time limit and would kindly ask @Campbell Barton (campbellbarton) to take over? (feel free to throw back at me though)

Joshua Leung (aligorith) added a subscriber: Joshua Leung (aligorith).Apr 11 2018, 11:43 PM

Testing this here, it isn't specifically limited to actions only. Doing the same on World datablocks will also cause problems. It appears that tselem->id here is invalid.

Kaspar Kuldkepp (kasparkuldkepp) added a subscriber: Kaspar Kuldkepp (kasparkuldkepp).Oct 12 2018, 10:12 AM

Yes I have the same problem with 2.8 every time.

When duplicating collection and then trying to make any object to single user blender crashes and closes quick.

Every way and time.

Tried with new document etc.

Win10 2.80.24 and the newest version aswell.

Philipp Oeser (lichtwerk) reassigned this task from Campbell Barton (campbellbarton) to Dalai Felinto (dfelinto).Nov 19 2019, 3:50 PM
Philipp Oeser (lichtwerk) raised the priority of this task from 50 to High.
Philipp Oeser (lichtwerk) edited projects, added BF Blender (2.82), Datablocks and Libraries, Add-ons (BF-Blender), User Interface; removed BF Blender.
Philipp Oeser (lichtwerk) added subscribers: Johnny Varila (zoni527), Dalai Felinto (dfelinto).
Philipp Oeser (lichtwerk) renamed this task from Make Single User on an action in Outliner with the view Blender File crash blender to Make Single User on an action or world in Outliner with the view Blender File crash blender.Nov 19 2019, 3:52 PM
Dalai Felinto (dfelinto) changed the task status from Unknown Status to Resolved.Nov 19 2019, 6:30 PM

Fixed on rB9ca2cbdcea6a8e46a07348ae35cdecfb0637eb9f.