Maniphest T54649

Multi-Object-Mode: Edit MetaBall Tools
Closed, Resolved

Assigned To
Campbell Barton (campbellbarton)
Authored By
Campbell Barton (campbellbarton)
Apr 16 2018, 12:58 PM
Tags
  • Code Quest
Subscribers
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Nick Milios (semaphore)
Philippe Schmid (Quetzal)

Description

Select Menu:

  • MBALL_OT_select_all rB0a893c0901d6fba0501ea4b341c5b9c0747be2af
  • MBALL_OT_select_random_metaelems rBf897d953727074c6916c3a15b21a072cbc5ffa8a
  • MBALL_OT_select_similar rB5f8d3694958a8ff8ea08d5df60155dfa5796e1fa

Note: Selection pick is not working either.

MetaBall Menu:

  • MBALL_OT_delete_metaelems rB6bee49eca45eb260e040b24a6fc58810f8a1907b
  • MBALL_OT_duplicate_metaelems rB046ec863ffc35e2daae105e4b5911076f1aade1d

Related Objects

StatusSubtypeAssignedTask
ConfirmedTO DONone
ResolvedCampbell Barton (campbellbarton)

Event Timeline

Campbell Barton (campbellbarton) lowered the priority of this task from 90 to Normal.Apr 16 2018, 12:58 PM
Campbell Barton (campbellbarton) created this task.
Campbell Barton (campbellbarton) updated the task description.Apr 16 2018, 2:15 PM
Nick Milios (semaphore) added a subscriber: Nick Milios (semaphore).May 10 2018, 6:04 PM

Done all the above.

The right click select is not working
i tried chanege

ED_mball_select_pick

like

EDBM_select_pick, ED_armature_edit_select_pick, ED_lattice_select_pick, ED_curve_editfont_select_pick

but i failed.

Also the following functions uses old code.

hide_metaelems_exec
reveal_metaelems_exec
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).May 11 2018, 12:52 PM

@Nick Milios (semaphore)

The patches overall are fine, but we need to skip the for loop when there is no selected elements. There is no equivalent of totvertsel/edge/face in metaballs. You need to add this (as its own patch), so we can proceed with the other patches? It should be straight forward.

The right click select may be a different issue, but let's focus on the other operators first?

Nick Milios (semaphore) added a comment.May 11 2018, 5:15 PM

@Dalai Felinto (dfelinto)

In MetaBall there is a double list mb->editelems of nodes type MetaElem and foreach of them a bitmask flag for ml->flag in first bit to check if it is selected..

To be clear...

Do you want me to edit struct MetaBall and add an int totelemsel?
Find all references functions that changes totvertsel and change all respective functions on mball to change the new totelemsel accordingly?
Then submit it as a pach and then re submit all aabove paches to check it?

Campbell Barton (campbellbarton) updated the task description.May 12 2018, 10:19 PM
Dalai Felinto (dfelinto) added a comment.May 13 2018, 1:11 PM

@Nick Milios (semaphore) that's what I meant yes, but Campbell just implemented BKE_mball_is_any_selected and BKE_mball_is_any_unselected, so you are good to update them (not re-submit as new patches, but update the existent ones).

Philippe Schmid (Quetzal) added a subscriber: Philippe Schmid (Quetzal).EditedMay 28 2018, 3:42 PM

I made a differential two weeks ago for MBALL_OT_select_all, but just realized that it didn't get linked back to the parent task, so if it's still current, there it is: D3347 .

hmm... I mentioned the wrong task, that's why.

Dalai Felinto (dfelinto) updated the task description.Nov 2 2018, 8:16 PM
Dalai Felinto (dfelinto) updated the task description.Nov 2 2018, 8:21 PM
Dalai Felinto (dfelinto) updated the task description.Nov 7 2018, 2:35 AM
Dalai Felinto (dfelinto) updated the task description.Nov 7 2018, 3:17 AM
Dalai Felinto (dfelinto) changed the task status from Unknown Status to Resolved.Nov 7 2018, 3:20 AM

I will address the selection issues and bugs separately. But overall as far as the main multi-objects operators is concerned, this is done.

Dalai Felinto (dfelinto) updated the task description.Nov 9 2018, 7:45 PM