Maniphest T54811

COW Operators: Edit Armature
Closed, ResolvedTO DO
Actions

Assigned To
Sergey Sharybin (sergey)
Authored By
Joshua Leung (aligorith)
Apr 25 2018, 2:02 PM
Tags
  • Code Quest
  • Dependency Graph
Subscribers
Joshua Leung (aligorith)

Description

Instructions

See T54810 for more details

Notes

Prior to bb92edd1c802b521d766f46bf09b7e4b352f8398, it was impossible to test/work on any of these, as editmode bone drawing would not refresh at all when Copy on Write was enabled.

After this commit, all editbone operators should just work (COW isn't actually performed here now, since the edit bones list is just copied directly to the copies). Several of the operators have been tested (marked with *) and work fine, so we've marked all the others as working too. -- @Joshua Leung (aligorith) 2018/05/03

editors/armature

Edit Bone Operators:

  • ARMATURE_OT_bone_primitive_add (*)
  • ARMATURE_OT_align
  • ARMATURE_OT_calculate_roll (*)
  • ARMATURE_OT_roll_clear
  • ARMATURE_OT_switch_direction
  • ARMATURE_OT_subdivide
  • ARMATURE_OT_parent_set
  • ARMATURE_OT_parent_clear
  • ARMATURE_OT_select_all (*)
  • ARMATURE_OT_select_mirror
  • ARMATURE_OT_select_more
  • ARMATURE_OT_select_less
  • ARMATURE_OT_select_hierarchy
  • ARMATURE_OT_select_linked
  • ARMATURE_OT_select_similar
  • ARMATURE_OT_shortest_path_pick
  • ARMATURE_OT_delete
  • ARMATURE_OT_dissolve
  • ARMATURE_OT_duplicate (*)
  • ARMATURE_OT_symmetrize
  • ARMATURE_OT_extrude (*)
  • ARMATURE_OT_hide (*)
  • ARMATURE_OT_reveal (*)
  • ARMATURE_OT_click_extrude (*)
  • ARMATURE_OT_fill
  • ARMATURE_OT_merge
  • ARMATURE_OT_separate
  • ARMATURE_OT_split
  • ARMATURE_OT_autoside_names
  • ARMATURE_OT_flip_names

TODO: These still need checking by hand, as they don't necessarily operate on editbones

  • ARMATURE_OT_layers_show_all
  • ARMATURE_OT_armature_layers - This updates as slowly with and without tweaks. But I've added an update tag for good measure
  • ARMATURE_OT_bone_layers

Related Objects
Search...

StatusSubtypeAssignedTask
 ArchivedTO DOJoshua Leung (aligorith)T54810 Port operators to use COW (Parent Task)
 ResolvedTO DOSergey Sharybin (sergey)T54811 COW Operators: Edit Armature

Event Timeline

Joshua Leung (aligorith) lowered the priority of this task from 90 to Normal.Apr 25 2018, 2:02 PM
Joshua Leung (aligorith) created this task.
Joshua Leung (aligorith) added a parent task: T54810: Port operators to use COW (Parent Task).
Joshua Leung (aligorith) updated the task description.Apr 25 2018, 2:04 PM
Joshua Leung (aligorith) updated the task description.
Joshua Leung (aligorith) updated the task description.Apr 25 2018, 2:07 PM
Joshua Leung (aligorith) added a project: Dependency Graph.Apr 25 2018, 2:11 PM
Joshua Leung (aligorith) mentioned this in T54810: Port operators to use COW (Parent Task).Apr 25 2018, 2:43 PM
Joshua Leung (aligorith) updated the task description.May 3 2018, 4:25 PM
Joshua Leung (aligorith) moved this task from Tasks to Doing on the Code Quest board.May 3 2018, 5:37 PM
Joshua Leung (aligorith) updated the task description.
Joshua Leung (aligorith) assigned this task to Sergey Sharybin (sergey).May 3 2018, 5:59 PM
Joshua Leung (aligorith) updated the task description.
Joshua Leung (aligorith) updated the task description.
Joshua Leung (aligorith) updated the task description.May 7 2018, 6:07 PM
Joshua Leung (aligorith) mentioned this in rBf998bad211ae: Fix: Last of the operators from T54811 now work with Copy on Write.May 11 2018, 5:44 PM
Joshua Leung (aligorith) updated the task description.May 11 2018, 5:44 PM
Joshua Leung (aligorith) moved this task from Doing to Reviewing on the Code Quest board.
Joshua Leung (aligorith) moved this task from Reviewing to Done on the Code Quest board.
Dalai Felinto (dfelinto) changed the task status from Unknown Status to Resolved.May 14 2018, 10:21 AM
Philipp Oeser (lichtwerk) mentioned this in D15969: Fix T101046: missing DEG update changing bone layers in editmode.Sep 14 2022, 1:17 PM
Philipp Oeser (lichtwerk) mentioned this in rBc350d97a2f69: Fix T101046: missing DEG update changing bone layers in editmode.Sep 23 2022, 12:09 PM
Philipp Oeser (lichtwerk) mentioned this in rB0ecc1d788cb9: Fix T101046: missing DEG update changing bone layers in editmode.Sep 30 2022, 2:40 PM
Philipp Oeser (lichtwerk) mentioned this in rB3dce2469eea5: Fix T101046: missing DEG update changing bone layers in editmode.Oct 3 2022, 9:25 PM