Maniphest T56250

Brush cycling with shortcuts broken
Closed, Resolved

Assigned To
Campbell Barton (campbellbarton)
Authored By
Julien Kaspar (JulienKaspar)
Aug 6 2018, 12:34 PM
Tags
  • BF Blender: 2.8
  • User Interface
  • Blender Studio
Subscribers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Erick Tukuniata (erickblender)
Julien Kaspar (JulienKaspar)
Roel Koster (kostex)

Description

Blender Version
Broken: 2.8 d890ad37a82

Short description of error
When cycling through brushes in the same category using shortcuts - for example the smooth, scrape & flatten brushes in Sculpt Mode with "S" - it only uses the second or third brush and locks it. Cycling through them is only working if you do it manually by clicking the icons in the toolbar.

Revisions and Commits

rB Blender

Related Objects

Mentioned Here
rBd890ad37a826: Fix horrible invalid mesh freeing in weightvg modifiers.

Event Timeline

Julien Kaspar (JulienKaspar) created this task.Aug 6 2018, 12:34 PM
Julien Kaspar (JulienKaspar) moved this task from Tasks to Spring Bugs on the Code Quest board.
Roel Koster (kostex) added a subscriber: Roel Koster (kostex).Aug 7 2018, 1:04 PM

I think it's the same issue I have in sculpt mode.. I've tracked it down to commit d79df6c0
the changes to space_toolsystem_common.py got result in not being able to cycle through brush presets.
Commenting them out fixes that (for the time being)
Did not investigate source further. Maybe committer Campbell knows more ;-)

Bastien Montagne (mont29) assigned this task to Campbell Barton (campbellbarton).Aug 8 2018, 9:52 AM
Bastien Montagne (mont29) lowered the priority of this task from 90 to Normal.
Bastien Montagne (mont29) added subscribers: Campbell Barton (campbellbarton), Bastien Montagne (mont29).

@Campbell Barton (campbellbarton) that’s probably for you?

Bastien Montagne (mont29) added a project: User Interface.Aug 8 2018, 9:52 AM
Julien Kaspar (JulienKaspar) added a comment.Aug 20 2018, 1:38 PM

This bug actually bothers me a lot during my workday. Not being able to rely on the shortcuts and having to click through the popups in the toolbar slows me down quite a bit.
Would be great if someone fixes this one soon.

Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Aug 20 2018, 2:30 PM

@Julien Kaspar (JulienKaspar) It is brothering everybody sculpting in Blender 2.8 and it exposes the downside of the new system, it makes me wondering again why are we hiding some other brushes, when we have a lot space where we can have them all exposed? It would easier to just click on the brush and select it, in stead of click and drag. Please @Campbell Barton (campbellbarton) the new tool system need more love in sculpt mode to make it more user friendly.

Julien Kaspar (JulienKaspar) added a comment.Aug 20 2018, 3:21 PM

@Erick Tukuniata (erickblender) That is a different issue though. This task is just the bug report that the shortcut cycling doesn't work anymore.

Erick Tukuniata (erickblender) added a comment.Aug 20 2018, 3:51 PM
In T56250#528867, @Julien Kaspar (JulienKaspar) wrote:

@Erick Tukuniata (erickblender) That is a different issue though. This task is just the bug report that the shortcut cycling doesn't work anymore.

Yes i know that what i mean is if every brushes were plainly exposed in the UI, some of us will be happy with minimal key shortcut or no shortcut at all.
I don't know if you encounter this problem, sometimes working with grab brush, switch to another brush, work for awhile and go back to grab brush, without any visual warning you will get the thumb brush and this happened to me so many times, some other time with crease brush and pinch/magnify

Julien Kaspar (JulienKaspar) added a comment.Aug 20 2018, 3:59 PM

@Erick Tukuniata (erickblender) Yes. Yes I am encountering this problem because it is due to this bug. But it makes no sense to unpack a discussion between a couple of people about changing the design decisions of the toolbar within a simple bug report. There are separate tasks for this to comment in :D

Brecht Van Lommel (brecht) edited projects, added Blender Studio; removed Code Quest.Sep 28 2018, 4:31 PM
Brecht Van Lommel (brecht) moved this task from To Do to In Progress on the Blender Studio board.Sep 28 2018, 4:34 PM
Julien Kaspar (JulienKaspar) added a subscriber: Brecht Van Lommel (brecht).Oct 16 2018, 11:25 AM

@Brecht Van Lommel (brecht) @Campbell Barton (campbellbarton) Are there any plans on fixing this bug any time soon?
I heard at some point that there is more work being put into how the tools for the brushes work and maybe also on how you cycle between them? Is that why this task is on a lesser priority?

This bug has been slowing me down for quite a bit now but especially for the Blender Conference it would be a blessing if this issue could be fixed, even if just temporarily.

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rB569dfe5784aa: Fix T56250: brush cycling with shortcuts is broken..Oct 16 2018, 8:34 PM
Brecht Van Lommel (brecht) added a commit: rB569dfe5784aa: Fix T56250: brush cycling with shortcuts is broken..