Maniphest T56547

Properties are not aligned in single column format
Closed, Resolved

Assigned To
Campbell Barton (campbellbarton)
Authored By
Alexander Gavrilov (angavrilov)
Aug 26 2018, 10:17 AM
Tags
  • BF Blender: 2.8
Subscribers
Alexander Gavrilov (angavrilov)
Campbell Barton (campbellbarton)
Justin Jones (jjones780)
William Reynish (billreynish)

Description

Blender Version

Broken: 2.8

Short description of error

Properties of different types have different input field width in single column format, causing an untidy buggy-looking appearance.

Specifically the difference seems to be between enum/pointer vs numeric/prop_search:

In this example it doesn't look that bad, but if you try to mix properties of different types more closely, it looks awful (example from D3588):

Interestingly, the check box property also does not align in a column, but the difference is so big it actually looks better than the small discrepancy between enum and others.

Revisions and Commits

rB Blender

Related Objects

StatusSubtypeAssignedTask
ResolvedCampbell Barton (campbellbarton)
ResolvedCampbell Barton (campbellbarton)

Event Timeline

Alexander Gavrilov (angavrilov) assigned this task to Campbell Barton (campbellbarton).Aug 26 2018, 10:17 AM
Alexander Gavrilov (angavrilov) lowered the priority of this task from 90 to 50.
Alexander Gavrilov (angavrilov) created this task.
Alexander Gavrilov (angavrilov) added a subtask: T56511: prop_search is misaligned..
Alexander Gavrilov (angavrilov) edited projects, added BF Blender: 2.8; removed BF Blender.
Alexander Gavrilov (angavrilov) added subscribers: William Reynish (billreynish), Campbell Barton (campbellbarton).Aug 26 2018, 10:27 AM
William Reynish (billreynish) added a comment.Aug 26 2018, 3:39 PM

Yes, this is a new issue that seems to have been introduced next to the prop_search alignment fix

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rBffbe5985c64f: Fix T56547: Single column properties not aligned.Aug 27 2018, 5:02 PM
Campbell Barton (campbellbarton) added a commit: rBffbe5985c64f: Fix T56547: Single column properties not aligned.
Justin Jones (jjones780) added a subscriber: Justin Jones (jjones780).Aug 30 2018, 10:17 AM

The NDOF ( i.e. space mouse ) menu has been adversely affected by this change ( T56547) and the earlier (T56511 ).
The menu can be brought up without a space mouse: edit->User Preferences->Input
In the Window section look for the "Call Menu" item with "NDOF Menu" key and change it to your preferred key.
Here's the affected menu:

If I comment out line 819 of blender/source/blender/editors/interface/interface_layout.c
i.e. //uiItemL(sub, NULL, ICON_BLANK1);
the NDOF menu will appear normal


Sorry, I don't have a proper fix to suggest at this time.

Campbell Barton (campbellbarton) added a comment.Aug 30 2018, 12:46 PM

@Justin Jones (jjones780), fixed the issue w/ ndof menu rB41d1af9a1151331171f25c3c799254b70a28d371