Maniphest T56717

Repeatedly adding a cylinder to a scene causes a crash
Closed, Resolved
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Jay Edwards (JayE01)
Sep 7 2018, 10:04 PM
Tags
  • BF Blender
  • BF Blender: 2.8
Subscribers
Alessio Monti di Sopra (a.monti)
Antonio Vazquez (antoniov)
Bastien Montagne (mont29)
David (david.hillard)
Jay Edwards (JayE01)
Juris Kolangs (Aiduss)
Ray Molenkamp (LazyDodo)
Roci (Roci)

Description

System Information
Windows 10, Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz, NVIDIA GeForce 940MX

Blender Version
Broken: 3733c529858
Worked: Yes

Repeatedly adding, going into edit mode and deleting cylinder multiple time causes blender to crash.

-add a cylinder

-go to edit more

-go back to object mode

-repeat this procedure a couple of time and it will eventually lead to a crash

Revisions and Commits

rB Blender
rBd483dfd03db1 Fix T56717: crash removing/adding objects.

Related Objects

Mentioned Here
P780 T56717 Crash adding cylinder
T56719: Crashing while adding objects + "Incorrect" scaling
rB3733c5298587: Merge branch 'master' into blender2.8

Event Timeline

Jay Edwards (JayE01) created this task.Sep 7 2018, 10:04 PM
Bastien Montagne (mont29) lowered the priority of this task from 90 to 30.Sep 8 2018, 3:43 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Works OK for me, tried to do so at least 30 times… We need an easily reproducible case to investigate.

Alessio Monti di Sopra (a.monti) added a subscriber: Alessio Monti di Sopra (a.monti).Sep 8 2018, 5:25 PM

This also happens to me, not only with cylinders though, it seems to happen with any kind of primitive (also lamps, curves, ecc), and also without the need of toggling edit mode.

The way to reproduce the crash for me is:

  • add primitive
  • delete it
  • add another primitive
  • delete it
  • repeat until the crash happens

Sometimes it occurs even on the first iteration, more often on the 2nd or the 3rd one.

(I'm on Windows 8.1 64 bit, Intel i7 4700MQ, GT 740M)

Bastien Montagne (mont29) raised the priority of this task from 30 to Normal.Sep 8 2018, 5:33 PM
Bastien Montagne (mont29) added a subscriber: Ray Molenkamp (LazyDodo).

Same issue as T56719 then I bet, will merge. And looks like we need some dev to check that on windows, @Ray Molenkamp (LazyDodo) maybe?

Bastien Montagne (mont29) merged a task: T56719: Crashing while adding objects + "Incorrect" scaling.Sep 8 2018, 5:34 PM
Bastien Montagne (mont29) added a subscriber: Roci (Roci).
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).EditedSep 8 2018, 5:44 PM

I got a crash after adding/delete several times

I just compiled the last source code.

Here the log: P780

The error in in line 687 of layer.c: int object_restrict = base->object->restrictflag;

The value of object variable is invalid.

Looking at the debug, the variable cob->ob is right, but the base that you get in BLI_ghash_lookup() has an invalid object value.

Antonio Vazquez (antoniov) added a comment.Sep 8 2018, 5:49 PM

Antonio Vazquez (antoniov) triaged this task as 50 priority.Sep 8 2018, 5:50 PM
Brecht Van Lommel (brecht) claimed this task.Sep 10 2018, 3:01 PM
Brecht Van Lommel (brecht) merged a task: T56740: Crash When operating with Spot Light Lapm.
Brecht Van Lommel (brecht) added a subscriber: Juris Kolangs (Aiduss).
Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rBd483dfd03db1: Fix T56717: crash removing/adding objects..Sep 10 2018, 4:10 PM
Brecht Van Lommel (brecht) added a commit: rBd483dfd03db1: Fix T56717: crash removing/adding objects..
Brecht Van Lommel (brecht) merged a task: T56746: Crash on delete cube, add monkey, delete monkey, add cube.Sep 10 2018, 7:53 PM
Brecht Van Lommel (brecht) added a subscriber: David (david.hillard).