Maniphest T58307

Multires Modifier - No smooth shading and no rotation depth.
Closed, Resolved
Actions

Assigned To
Sergey Sharybin (sergey)
Authored By
Daniel Aubert (Daniel.Aubert)
Nov 30 2018, 2:38 PM
Tags
  • BF Blender
Subscribers
Addison Chrystie (achrystie)
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Daniel Aubert (Daniel.Aubert)
Enrique Barranco (ebarranco)
Martin Capitanio (capnm)
Sebastian Parborg (zeddb)
2 More Subscribers
Tokens
"The World Burns" token, awarded by capnm.

Description

System Information
Operating system: Windows 10
Graphics card: NVidia Geforce 940mx

Blender Version
Broken: blender-2.80.0-git.26d5a3625ed-windows64
(example: 2.79b release)
(example: 2.80, edbf15d3c044, blender2.8, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error
With Multires modifier in sculpt mode, the object only shows as flat shaded and the "auto depth" navigation function doesn't seem to work, so when you rotate the view it doesn't pivot from the point on the surface you click, but rather from the middle of the object.

Exact steps for others to reproduce the error
Create an object - add multires modifier - add at least one subdivision - be sure object is shaded smooth - enter sculpt mode - rotate the view (auto depth must be enabled in settings) - compare to the rotation outside sculpt mode.

It is a small thing. If this is not regarded as a bug, just let me know. I want to help as much as possible in the evolution of Blender 2.8 Beta

Related Objects

Mentioned In
rB3b132778deaa: Multires: Support smooth shading when sculpting
Mentioned Here
rB2f8d8b5e5e4b: GPUBuffer: Fix fast navigate in on smoooth multires grid
rB779860d34e26: readfile: disable delayed data reading for WIN32
rBedbf15d3c044: Defaults: left click select is now the default.
rB26d5a3625ed8: Texture Paint: fix artifacts when using masks with symmetry.

Event Timeline

Daniel Aubert (Daniel.Aubert) created this task.Nov 30 2018, 2:38 PM
Addison Chrystie (achrystie) added a subscriber: Addison Chrystie (achrystie).Nov 30 2018, 3:44 PM

I have a feeling that my bug is similar to this one. I'm on an Intel i3 2 core/ 4 thread, and have a GTX 750ti with the latest Nvidia drivers on Windows 10 64 bit. If I do the same procedure above, with just one multires level, the model disappears completely when rotating in sculpt mode.

Martin Capitanio (capnm) awarded a token.Dec 1 2018, 11:37 AM
Martin Capitanio (capnm) added a subscriber: Martin Capitanio (capnm).EditedDec 1 2018, 11:55 AM

with just one multires level, the model disappears completely when rotating in sculpt mode.

(Linux, git blender2.8 tip) It depends on the option "Number of subdivisions in sculpt mode".
For >1, it shows only one division during the view-port movement. The automatic depth positioning for the center point works only when sculpting the 'visible' subdiv #1 mesh points.

Sebastian Parborg (zeddb) lowered the priority of this task from 90 to 50.Dec 7 2018, 4:37 PM
Sebastian Parborg (zeddb) added subscribers: Brecht Van Lommel (brecht), Sebastian Parborg (zeddb).

@Brecht Van Lommel (brecht), I don't know who to assign this to.

Brecht Van Lommel (brecht) assigned this task to Sergey Sharybin (sergey).Dec 11 2018, 7:59 PM
Brecht Van Lommel (brecht) added a subscriber: Sergey Sharybin (sergey).

This one is kind of random to assign, issues could be in different parts of the code. @Sergey Sharybin (sergey), feel free to reassign.

Brecht Van Lommel (brecht) merged a task: T60100: Smooth shading is not working in Sculpt Mode.Jan 3 2019, 6:35 PM
Brecht Van Lommel (brecht) added a subscriber: Enrique Barranco (ebarranco).
Brecht Van Lommel (brecht) merged a task: T60423: No smooth shading when sculpting with multiresolution in 2.8.Jan 11 2019, 4:31 PM
Brecht Van Lommel (brecht) added a subscriber: Thomas Volkmann (knekke).
Sergey Sharybin (sergey) reassigned this task from Sergey Sharybin (sergey) to Clément Foucault (fclem).Jan 17 2019, 6:15 PM
Sergey Sharybin (sergey) added a subscriber: Clément Foucault (fclem).

The smooth shading is more for @Clément Foucault (fclem), AFAIR he did majority of the new code.

Rotation depth i am not sure what's going on, @Clément Foucault (fclem), after fixing the smooth shading, feel free to re-assign back to me.

Clément Foucault (fclem) removed Clément Foucault (fclem) as the assignee of this task.Jan 17 2019, 8:40 PM

For >1, it shows only one division during the view-port movement.

This is caused of the fast navigate option in the toolbar. This is not a bug.

@Sergey Sharybin (sergey) In GPU_pbvh_grid_buffers_update(), grid_flag_mats is currently NULL and leads to a Null pointer dereferencing. So I think it is not comming from the drawing code.

William Reynish (billreynish) added a subscriber: William Reynish (billreynish).Jan 17 2019, 8:48 PM

@Clément Foucault (fclem):At least here, multires objects in Sculpt Mode are always drawn as flat shaded objects, regardless of Fast Navigate being on.

Sergey Sharybin (sergey) claimed this task.Jan 17 2019, 8:58 PM

@Clément Foucault (fclem), ah, if it's matter of filling in a flags array it should be a simple task :)

Sergey Sharybin (sergey) mentioned this in rB3b132778deaa: Multires: Support smooth shading when sculpting.Feb 22 2019, 5:07 PM
Sergey Sharybin (sergey) added a comment.Feb 22 2019, 5:28 PM

Shading is now fixed. The auto-depth i can't really see a difference between object and sculpt mode. Is it still an issue?

Enrique Barranco (ebarranco) added a comment.Feb 23 2019, 10:43 PM

Hi Sergey Sharybin, smooth shading is working in multires modifier now but I have some new artifacts when I zoom/rotate and the mesh changes to lowres. I'm using hash: 779860d34e26
Watch here the behavior.

Clément Foucault (fclem) added a comment.Feb 23 2019, 11:03 PM

@Enrique Barranco (ebarranco) I fixed this already in 2f8d8b5e5e4b

Enrique Barranco (ebarranco) added a comment.Feb 23 2019, 11:54 PM

Great! @Clément Foucault (fclem) Thanks.

Sebastian Parborg (zeddb) changed the task status from Unknown Status to Resolved.Feb 25 2019, 12:03 PM

I'll mark this as resolved as I don't see any issue with auto depth either.