Maniphest T58508

Node Editor: Some nodes lack red line when muted
Closed, Duplicate
Actions

Assigned To
None
Authored By
Michael P. (forest-house)
Dec 2 2018, 12:32 PM
Tags
  • Nodes
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)
Michael P. (forest-house)
William Reynish (billreynish)

Description

Node Editor: Some nodes lack red line when muted

System Information
System: Windows 7 64bit
RAM: 4096 MB
renderer: 'GeForce GTX 760/PCIe/SSE2'
vendor: 'NVIDIA Corporation'
version: '4.5.0 NVIDIA 364.72'

Blender Version
Broken: blender-2.80.0-git.0f5b53ba4dc-windows64

Short description of error
Node Editor: Some nodes lack red line when muted

Exact steps for others to reproduce the error

  1. Open the node editor
  2. Add nodes from the screenshots
  3. Press "M" to mute them
  4. Some nodes have the red crossed through line, others don't

Expected:

  1. Should be consistent (even if it's not a bug)
  2. I can't tell which node is muted and which ones are not

I didn't find any indication in the properties either,
and the changed colors of the node header don't tell anything

Related Objects

Mentioned Here
rB0f5b53ba4dc0: Revert "Win32: Use the nicer looking blender-drawn confirmation message box…

Event Timeline

Michael P. (forest-house) created this task.Dec 2 2018, 12:32 PM
Jacques Lucke (JacquesLucke) added subscribers: William Reynish (billreynish), Brecht Van Lommel (brecht), Jacques Lucke (JacquesLucke).Dec 3 2018, 3:20 PM

The red line indicates which input will be passed on at which output when the node is muted. On some nodes that does not make any sense. E.g. passing on the vector as color in the gradient texture node makes no sense.
Nevertheless I agree that some other indication is necessary here (or it should just not be possible to mute those nodes!).

@Brecht Van Lommel (brecht), @William Reynish (billreynish) what do you think?

William Reynish (billreynish) added a comment.EditedDec 3 2018, 3:33 PM

I think it's best to be consistent. Even if there's only one input and one output, we could still display the red line. The line both helps communicate what happens when a node is disabled, and the fact that it is disabled at all.

I see no immediate downside to just always drawing the red line when disabled. You then also know which socket to use when connecting to a disabled node.

Brecht Van Lommel (brecht) lowered the priority of this task from 90 to 50.Dec 3 2018, 3:44 PM

We could also make the node header properly red and grey out all the buttons in the node.

If we want to draw the red line, I guess it would have to be connected to some arbitrary point on the left side of the node. Some disabled nodes don't even have input sockets.

Brecht Van Lommel (brecht) added a comment.Dec 3 2018, 3:46 PM

Mainly I think the regression compared to 2.7x is the theming, which does not make the header red enough. This should at least be fixed.

William Reynish (billreynish) added a comment.Dec 3 2018, 4:08 PM

Hm, true. Probably better then to just grey out the contents of the node.

The line I see we can't always use, and the theme thing will never be clear enough I don't think.

Brecht Van Lommel (brecht) edited projects, added BF Blender; removed BF Blender: 2.8.Dec 11 2018, 3:08 PM
Brecht Van Lommel (brecht) closed this task as a duplicate of T60719: The header color of muted vs non-muted "Value" nodes is almost exactly the same..Mar 26 2019, 1:55 PM