Maniphest T60194

Sequencer cut loses animation data for the right strip
Closed, ResolvedBUG

Assigned To
Bastien Montagne (mont29)
Authored By
Guillaume M (mathers)
Jan 5 2019, 11:25 AM
Tags
  • BF Blender
  • Video Sequencer
Subscribers
Bastien Montagne (mont29)
Christopher_Anderssarian
Guillaume M (mathers)
Jacques Lucke (JacquesLucke)
Richard Antalik (ISS)

Description

System Information
Operating system: Ubuntu 18.04.1 LTS

Blender Version
Broken: Latest master branch commit : 95736683a96d33a8a7220788502250fa9e109132

When cutting a strip using the VSE (this affects all types of strips), the animation data is duplicated in the resulting right-hand strip, but is not copied to the left-hand strip.

Exact steps for others to reproduce the error
Open the VSE, add a sound strip. Animate the "volume" property using two keyframes.
Open the Graph editor, visualize the "Volume" F-curve.
Soft-cut the sound strip, and examine the F-curves for the two resulting strips :

  • The left strip has no animation data
  • The right strip has TWO identical "Volume" F-curves

Possibly linked to the following code tag :
blenkernel/intern/sequencer.c:5448 (95736683a96d33a8a7220788502250fa9e109132)

static Sequence *seq_dupli(const Scene *scene_src, Scene *scene_dst, Sequence *seq, int dupe_flag, const int flag)
{
        Sequence *seqn = MEM_dupallocN(seq);

        seq->tmp = seqn;
        seqn->strip = MEM_dupallocN(seq->strip);

        seqn->stereo3d_format = MEM_dupallocN(seq->stereo3d_format);

        /* XXX: add F-Curve duplication stuff? */

Revisions and Commits

rB Blender
Abandoned

Related Objects

Mentioned In
T60370: Keyframes on Cut-ted strips
D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence
Mentioned Here
rBbb98e83b99e6: Fix T55668: Volume Keyframe on Cut-ted Metastrip.
T60370: Keyframes on Cut-ted strips
rB95736683a96d: UI: length now scales proportionally w/ multi-but

Event Timeline

Guillaume M (mathers) created this task.Jan 5 2019, 11:25 AM
Guillaume M (mathers) added a comment.Jan 5 2019, 12:28 PM

Hi,
After investigation, I believe I can submit a patch that solves this issue. Please let me know what you think and how much testing this requires

Christopher_Anderssarian added a subscriber: Christopher_Anderssarian.EditedJan 6 2019, 11:30 AM

Mind adding the Video Sequencer tag?

CC @Richard Antalik (ISS)

Christopher_Anderssarian added a subscriber: Richard Antalik (ISS).Jan 6 2019, 11:48 AM
Guillaume M (mathers) added a project: Video Sequencer.Jan 6 2019, 12:38 PM
Richard Antalik (ISS) claimed this task.Jan 9 2019, 12:19 AM
Richard Antalik (ISS) lowered the priority of this task from 90 to High.

@Guillaume M (mathers) Thanks for patch!

You can post patch for review or I can do it instead if you want.
I will look at it tomorrow.

Richard Antalik (ISS) added a subscriber: Bastien Montagne (mont29).Jan 9 2019, 10:18 PM

I looked at this.

Your patch would undo some changes in bb98e83b99e63348e0396a5ffe5bb2a20ff1607a by @Bastien Montagne (mont29).

If I understood it correctly, problem was that meta strips did generate non-unique names
Not totally sure, what removal of SEQ_DUPE_UNIQUE_NAME solved, as this caused all strips to generate non-unique name.

Will try to reproduce and patch actual problem.

Guillaume M (mathers) added a comment.Jan 10 2019, 12:12 AM

After applying my patch, I was unable to reproduce T55668. It looks like each strip its given a unique name properly, even with nested Meta-Strips.

I was able however to find a similar bug, reported as T60370, but I believe it is unrelated.

Therefore I am submitting patch D4186

Guillaume M (mathers) added a comment.EditedJan 10 2019, 11:24 AM

After a bit more testing, it looks like this patch indeed solves this bug, but also introduces a new minor bug T60194.

I don't see how to solve T60370, has anyone experienced this type of problem ? Maybe there is a flag to set on the newly animated strip, or some kind of cache to clear ?

Youtube video demonstrating the problem

Bastien Montagne (mont29) claimed this task.Jan 10 2019, 10:34 PM

rBbb98e83b99 is indeed a wrong fix (breaking animation), need to redo that in another way that also handles animation well… :/

Bastien Montagne (mont29) mentioned this in T60370: Keyframes on Cut-ted strips.Jan 11 2019, 7:52 PM
Bastien Montagne (mont29) merged a task: T60370: Keyframes on Cut-ted strips.
Bastien Montagne (mont29) added a subscriber: Jacques Lucke (JacquesLucke).
Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rB1ded3d2f7c04: Fix T55668: Volume Keyframe on Cut-ted Metastrip (re-doing the fix in better….Jan 11 2019, 8:03 PM
Bastien Montagne (mont29) added a commit: rB1ded3d2f7c04: Fix T55668: Volume Keyframe on Cut-ted Metastrip (re-doing the fix in better….