Maniphest T60607

The tool system's "Spin" and "Spin (Duplicate)" operators are the same
Closed, Resolved
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Jesse Yurkovich (deadpin)
Jan 18 2019, 1:16 AM
Tags
  • BF Blender
Subscribers
Campbell Barton (campbellbarton)
Jesse Yurkovich (deadpin)
Joel Godin (FloridaJo)
Roberto Lopes (XDroid)
William Reynish (billreynish)

Description

System Information
Operating system: Win10
Graphics card: nVidia Quadro 600

Blender Version
Broken: 2.80 (sub 41), branch: master, commit date: 2019-01-16 19:04, hash: 8ba86020cc50
Worked: N/A

Short description of error
The tool system's "Spin" and "Spin (Duplicate)" operators are the same. In other words they do the same thing by default. I believe that "Spin (Duplicate)" should have the "Dupli" option checked/set to True, but this is not the case.

Additionally, it would be best to spell out "Dupli" in the UI -- "Use Duplicates" would be my suggestion.

Exact steps for others to reproduce the error

  • Start with default .blend
  • Go to Edit mode on cube
  • Try to use the Spin or Spin (Duplicate) operators from the new T-panel
  • Observe that, by default, they both do the same thing and have the same settings

Revisions and Commits

rB Blender
rBc1f8268734af Fix T60607: Spin tool duplicates after Spin Duplicate

Related Objects

Mentioned In
T71098: Tool shelf - identical tools Spin and Spin Duplicate
Mentioned Here
rBe45cfb574ee7: Solidify Modifier: support non-manifold input
rB8ba86020cc50: GP: Display Stroke for Fill Alt mode always

Event Timeline

Jesse Yurkovich (deadpin) created this task.Jan 18 2019, 1:16 AM
Jacques Lucke (JacquesLucke) lowered the priority of this task from 90 to 50.Jan 18 2019, 12:00 PM
Jacques Lucke (JacquesLucke) added a subscriber: Campbell Barton (campbellbarton).Jan 18 2019, 12:04 PM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).Jan 18 2019, 2:43 PM

Apart from the bug itself, I agree we should revise the naming here.

'Spin (Duplicate)' -> 'Spin Duplicates'
'Dupli' -> 'Use Duplicates'

No need to be needlessly cryptic.

Joel Godin (FloridaJo) added a subscriber: Joel Godin (FloridaJo).Jan 30 2019, 2:30 AM

Not sure its a bug, but rather a naming issue.
If you look at the panel, you have to check 'Dupli' for it to duplicate.


Otherwise it just spins.
So like in 2.79 there is just 'spin' then you click 'dupli' for duplicate. There is not 'spin' and 'spin (duplicate)'.

Joel Godin (FloridaJo) added a comment.Jan 30 2019, 7:02 PM

Correction; it is a bug.
Spin (Duplicate) should open with 'dupli' set to True and it is not.

As you can see from the code, it is supposed to be defaulted to 'True', but it either is getting
overwritten on window update or something else. Will dig further.

def km_3d_view_tool_edit_mesh_spin(params):
    return (
        "3D View Tool: Edit Mesh, Spin",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'}, None),
        ]},
    )


def km_3d_view_tool_edit_mesh_spin_duplicate(params):
    return (
        "3D View Tool: Edit Mesh, Spin (Duplicate)",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'},
             {"properties": [("dupli", True)]}),
        ]},
    )
Joel Godin (FloridaJo) claimed this task.Jan 31 2019, 1:09 AM
Joel Godin (FloridaJo) removed Joel Godin (FloridaJo) as the assignee of this task.Feb 4 2019, 2:04 PM
William Reynish (billreynish) assigned this task to Campbell Barton (campbellbarton).Feb 4 2019, 3:40 PM

I think this one is for you, @Campbell Barton (campbellbarton) :)

Jesse Yurkovich (deadpin) mentioned this in T71098: Tool shelf - identical tools Spin and Spin Duplicate.Oct 25 2019, 7:59 PM
Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rBc1f8268734af: Fix T60607: Spin tool duplicates after Spin Duplicate.Nov 1 2019, 1:26 AM
Campbell Barton (campbellbarton) added a commit: rBc1f8268734af: Fix T60607: Spin tool duplicates after Spin Duplicate.
Jesse Yurkovich (deadpin) added a comment.Nov 1 2019, 6:44 PM

I believe this is still an issue. Here's a gif that shows the issue -- The initial invocation of the Spin (Duplicate) tool still does not have the correct option set:

Campbell Barton (campbellbarton) added a comment.Nov 3 2019, 4:40 AM

I can't redo this - the setting is always set correctly in 6db9b443bb5b893b2807850a43de56e81c77160e

Jesse Yurkovich (deadpin) added a comment.Nov 4 2019, 8:25 AM

Tried again with today's build of master (e45cfb574ee7) using --factory-startup plus a completely clean preferences directory: it still repro's for me. At least one other person on blender-coders was also able to confirm the issue still happens for them as well. Is there anything for me to try and debug on my side (I have debug build available to set breakpoints as well)

Joel Godin (FloridaJo) added a comment.Nov 18 2019, 5:39 AM

I can verify that 'duplicates' still does not work.
Before it at least worked when you checked the box manually, but now it don't work at all. The checkbox 'duplicates' unchecks upon initiating action.

Campbell Barton (campbellbarton) added a comment.Nov 18 2019, 6:53 AM

It's more of an implementation detail that spin and spin-duplicate share an operator.

If you start a new spin or spin-duplicate operation, it's going to use the option based on the tool set.

Joel Godin (FloridaJo) added a comment.Nov 18 2019, 12:49 PM

Spin and Spin Duplicate do the same thing is the main thing I'm pointing out.
No difference. Bug.

Roberto Lopes (XDroid) added a subscriber: Roberto Lopes (XDroid).Apr 5 2022, 11:18 AM

Bug still present in 3.1.2.