Maniphest T60753

Graph Editor showing cache curves regardless of filters
Closed, Resolved
Actions

Assigned To
Joshua Leung (aligorith)
Authored By
Pablo Vazquez (pablovazquez)
Jan 22 2019, 4:34 PM
Tags
  • BF Blender
Subscribers
Joshua Leung (aligorith)
Pablo Vazquez (pablovazquez)
Tokens
"Like" token, awarded by billreynish.

Description

System Information
Operating system: Ubuntu Linux 18.04
Graphics card: NVIDIA RTX Quadro 6000

Blender Version
Broken: 2.8 master 22 January 2019 (185c2487a681)

Short description of error
It may be the case for other animation types, but at least animating the offset in Mesh Sequence Cache modifier makes the curve to show up in the Graph Editor, regardless of the filtering or if the "Only Selected" is on. As shown in the following image:

It makes it really hard to tweak curves in other objects when there are dozens or hundreds of other, unrelated curves.

Even with all filters off:

Exact steps for others to reproduce the error

graph_editor_cache_curves.blend799 KBDownload

(Note: the cache file is missing because it can't be packed, but the curve is there)

  • Open .blend file, all three objects have animation.
  • Select each object, notice how the "Frame Offset" curve is always visible, even when toggling off all filters.

Revisions and Commits

rB Blender
rB65340ad73f4c Fix T60753: Graph Editor showing cache curves regardless of filters

Related Objects

Mentioned Here
rB185c2487a681: Fix T60737: Crash workbench rendering

Event Timeline

Pablo Vazquez (pablovazquez) created this task.Jan 22 2019, 4:34 PM
Pablo Vazquez (pablovazquez) added a subscriber: Joshua Leung (aligorith).Jan 22 2019, 4:37 PM

Besides getting the "Only Selected" to work, maybe we need a new Filter type for cache files as well? What do you think @Joshua Leung (aligorith)?

William Reynish (billreynish) awarded a token.Jan 22 2019, 4:40 PM
Jacques Lucke (JacquesLucke) lowered the priority of this task from 90 to 50.Jan 22 2019, 5:16 PM
Joshua Leung (aligorith) claimed this task.Jan 23 2019, 2:39 AM

Yes, a new filter type for this case makes sense.

On a related note, I've always found that the way the Cache Files stuff was added to the animation filtering code has always been quite hacky.

Pablo Vazquez (pablovazquez) added a comment.Jan 23 2019, 12:12 PM
In T60753#604717, @Joshua Leung (aligorith) wrote:

Yes, a new filter type for this case makes sense.

On a related note, I've always found that the way the Cache Files stuff was added to the animation filtering code has always been quite hacky.

Time for tidying it up! :D But yes, can imagine, I also want to give the filters UI a pass as well since now it's two columns mixing Datablocks, Object Types, Modifiers etc.

For now, being able to hide all the Cache animation stuff would help so much! On Spring we are using Alembic files a lot in 100+ plants so it gets really hard to tweak any other kind of curves like nodes or cameras, when all other Cache curves are visible.

Joshua Leung (aligorith) added a comment.Jan 23 2019, 12:54 PM

@Pablo Vazquez (pablovazquez) Could you recommend any files in particular with quite a few cache files present? I was looking for a test file so that I could check if the cleanups I had in mind would losing any functionality.

The current layout of the toggles could use some tweaks yes. It's currently in a hand-picked order to minimise the vertical size of that popover, while ensuring that the toggles won't change order too often when certain types of data suddenly become available in the scene.

Joshua Leung (aligorith) changed the task status from Unknown Status to Resolved by committing rB65340ad73f4c: Fix T60753: Graph Editor showing cache curves regardless of filters.Feb 3 2019, 12:56 PM
Joshua Leung (aligorith) added a commit: rB65340ad73f4c: Fix T60753: Graph Editor showing cache curves regardless of filters.