Maniphest T60816

Bisect uses meters for the plane point
Closed, Resolved
Actions

Assigned To
Jacques Lucke (JacquesLucke)
Authored By
David Hill (davidwhill)
Jan 24 2019, 1:27 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
David Hill (davidwhill)
Jacques Lucke (JacquesLucke)
William Reynish (billreynish)

Description

System Information
Operating system: Windows 10
Graphics card: nVidia 960 GX

Blender Version
Broken: 2.80 Beta, 7f40d553f903, 2019-01-22 01:09
(example: 2.79b release)
(example: 2.80, edbf15d3c044, blender2.8, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error
With units set to "Imperial" and inches, while using Bisect, the units on the plane point are in meters.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).
Set units to Imperial and inches. Bisect a model. To alter the plane point, inches have to be converted to meters for correct results.

Revisions and Commits

rB Blender
D4248rB6b5416909ef4 Fix T60816: Specify subtype for some properties of mesh operators

Related Objects

Mentioned Here
T60824: List of Properties that should use the Units system
rBb78641610613: Fix T59151 Bevel modifier has bad input width for percent.
D4248: Fix T60816: Specify subtype for plane_co in mesh.bisect operator
rB7f40d553f903: Cleanp: use single global for draw manager

Event Timeline

David Hill (davidwhill) created this task.Jan 24 2019, 1:27 PM
Jacques Lucke (JacquesLucke) lowered the priority of this task from 90 to 50.Jan 24 2019, 3:01 PM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

It uses Blender units to be precise, but yes, the unit should be the one selected in the Units panel.
Checking...

Jacques Lucke (JacquesLucke) claimed this task.Jan 24 2019, 3:16 PM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).EditedJan 24 2019, 4:57 PM

@Jacques Lucke (JacquesLucke) FYI, there are a few other operators that still use Blender Units.

For example:

  • Bevel Amount
  • Randomize Amount

Probably there are more

There are also properties that should be made aware of units still, such as:

Force Fields:

  • field.distance_min
  • field.distance_max
  • field.radial_min
  • field.radial_max

Particles:

  • root_radius
  • tip_radius
  • mass

Cloth:

  • modifiers["Cloth"].settings.mass

Softbody:

  • modifiers["Softbody"].settings.mass
Jacques Lucke (JacquesLucke) added a comment.Jan 24 2019, 5:04 PM

Started fixing those here: D4248

@William Reynish (billreynish): Feel free to create a new task for that and assign me.

William Reynish (billreynish) added a comment.Jan 24 2019, 5:11 PM

@Jacques Lucke (JacquesLucke) Ok, will do :)

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Jan 24 2019, 5:16 PM

Note "Bevel Amount" depends is not always a distance, see rBb78641610613: Fix T59151 Bevel modifier has bad input width for percent..

Jacques Lucke (JacquesLucke) changed the task status from Unknown Status to Resolved by committing rB6b5416909ef4: Fix T60816: Specify subtype for some properties of mesh operators.Jan 24 2019, 5:41 PM
Jacques Lucke (JacquesLucke) added a commit: rB6b5416909ef4: Fix T60816: Specify subtype for some properties of mesh operators.
William Reynish (billreynish) added a comment.Jan 24 2019, 6:03 PM

@Jacques Lucke (JacquesLucke) I've tried to make a comprehensive list here: T60824

Jacques Lucke (JacquesLucke) added a comment.Jan 24 2019, 6:05 PM

I could not not notice it haha (notifications)
Thanks :)

William Reynish (billreynish) added a comment.Jan 24 2019, 6:44 PM

@Brecht Van Lommel (brecht) Hmm grumble grumble. You are right. We are using the same property to mean a percentage and length in different cases for that one. Really I suppose we should make them two independent properties, and show the correct ones when applicable?