Maniphest T61117

It takes too many extra clicks to change selection between bones and objects
Closed, ResolvedBUG
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Wo!262 (wo262)
Feb 1 2019, 11:39 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Wo!262 (wo262)

Description

Blender Version
Broken: blender-2.80.0-git.552b2287db86-windows64
Worked: 2.79

Description of the error and steps

It takes one extra click on each case to change selection between an object and bone and viceversa.

In 2.8, with Lock Object Modes turned off, this scenario takes 6 Clicks in total. It works like this:
-One click on BoneA puts you into Pose mode, but if another bone was selected you have to click on BoneA again. From Pose mode, one click on an Object puts you into Object mode, but it doesn't select the objecet, the armature is selected instead, so you have to click the object again. Now click on BoneB and youll be back in pose mode, except BoneA will be selected from your last time in pose mode, so you need an extra click. *

In 2.79 the same scenario takes 3 Clicks in total. It worked like this:
-From Object mode, one click on BoneA selects BoneA putting you into Pose mode directly, one click on an Object selects that object alone and puts you in back Object mode, a click on BoneB selects BoneB, and only BoneB, not the previously selected BoneA, and puts you into Pose mode again.

Try it with this file in 2.79 and then in 2.8

bug10.blend506 KBDownload

Revisions and Commits

rB Blender
rB0b4c0472a3aa Fix T61117: Selecting an armature doesn't select the bone

Related Objects

Event Timeline

Wo!262 (wo262) created this task.Feb 1 2019, 11:39 PM
Sebastian Parborg (zeddb) assigned this task to Brecht Van Lommel (brecht).Feb 4 2019, 11:32 AM
Sebastian Parborg (zeddb) lowered the priority of this task from 90 to 50.
Brecht Van Lommel (brecht) reassigned this task from Brecht Van Lommel (brecht) to Campbell Barton (campbellbarton).Feb 4 2019, 12:18 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Wo!262 (wo262) added a comment.Jul 14 2019, 5:58 PM

Any updates on this?

Campbell Barton (campbellbarton) added a comment.Jul 17 2019, 8:10 AM

Looking into this at the moment, relates to T66949

Campbell Barton (campbellbarton) added a comment.EditedJul 17 2019, 12:54 PM

There was a change in 2.8x that makes selecting bones only work on the active object. You can't select an armature and bone at the same time.

Changing this is simple, however this is a fairly big change to make so close to release, see patch:

diff --git a/source/blender/draw/intern/draw_armature.c b/source/blender/draw/intern/draw_armature.c
index f97efa9aed9..657bf81e469 100644
--- a/source/blender/draw/intern/draw_armature.c
+++ b/source/blender/draw/intern/draw_armature.c
@@ -1992,7 +1992,7 @@ static void draw_armature_pose(Object *ob, const float const_color[4])
 
   // if (!(base->flag & OB_FROMDUPLI)) // TODO
   {
-    if ((draw_ctx->object_mode & OB_MODE_POSE) || (ob == draw_ctx->object_pose)) {
+    if (ob->mode & OB_MODE_POSE) {
       arm->flag |= ARM_POSEMODE;
     }

This check probably needs to also skip dupli/set-scene objects for eg.

Campbell Barton (campbellbarton) raised the priority of this task from 50 to High.Jul 17 2019, 1:43 PM
Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rB0b4c0472a3aa: Fix T61117: Selecting an armature doesn't select the bone.Jul 18 2019, 7:48 AM
Campbell Barton (campbellbarton) added a commit: rB0b4c0472a3aa: Fix T61117: Selecting an armature doesn't select the bone.