Maniphest T63079

Collapsed nodes should not shrink
Closed, ResolvedTO DO
Actions

Assigned To
None
Authored By
William Reynish (billreynish)
Mar 29 2019, 10:31 AM
Tags
  • BF Blender: 2.8
  • User Interface
Subscribers
Alexander Dumproff (A.Lex_3D)
Brent Lio (remotecrab131)
Campbell Barton (campbellbarton)
Charlie Jolly (charlie)
Christoph Lohr (Thane5)
David (activemotionpictures)
Joep Peters (Joep)
9 More Subscribers
Tokens
"Like" token, awarded by sebastian_k.

Description

Closing nodes by default often makes them too narrow, so that you cannot read the header text. The user must then go through each node and resize it back to a reasonable length.

By default, the node becomes this short:

Instead, we should not shorten the length of the node, but keep the length the same as when the node was open:

Revisions and Commits

rB Blender
D4617rBf54db0fa057e UI: Collapsed nodes have the same width as uncollapsed nodes

Related Objects
Search...

StatusSubtypeAssignedTask
 ConfirmedTO DONoneT56950 UI Paper Cuts (Parent Task)
 ResolvedTO DONoneT63079 Collapsed nodes should not shrink

Event Timeline

William Reynish (billreynish) lowered the priority of this task from 90 to Normal.Mar 29 2019, 10:31 AM
William Reynish (billreynish) created this task.
William Reynish (billreynish) mentioned this in T56950: UI Paper Cuts (Parent Task).
Sebastian Koenig (sebastian_k) awarded a token.Mar 29 2019, 10:48 AM
Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).EditedMar 29 2019, 8:37 PM

This seems to be caused by line 586 in node_draw.c.

node->totr.xmax = locx + 3 * hiddenrad + node->miniwidth;

This causes xmax to be smaller than locx + NODE_WIDTH(node);. I've also noticed that resizing a hidden/closed node doesn't work properly, it only hides the label without shrinking the box.

Robert Guetzkow (rjg) added a comment.Mar 29 2019, 10:05 PM

The resizing of the node is weird in general. Increasing the size of the hidden node also doesn't increase the size of the node when not hidden. Once it's unhidden it returns to the original size.

Robert Guetzkow (rjg) added a revision: D4617: Collapsed nodes don't shrink.Mar 29 2019, 10:08 PM
Jacques Lucke (JacquesLucke) changed the task status from Unknown Status to Resolved by committing rBf54db0fa057e: UI: Collapsed nodes have the same width as uncollapsed nodes.Apr 2 2019, 4:45 PM
Jacques Lucke (JacquesLucke) added a commit: rBf54db0fa057e: UI: Collapsed nodes have the same width as uncollapsed nodes.
Mateusz (brezdo) removed a subscriber: Mateusz (brezdo).May 18 2020, 3:33 PM