Maniphest T64438

Collection Instance object highlight wrong
Closed, Resolved
Actions

Assigned To
Dalai Felinto (dfelinto)
Authored By
Sebastian Koenig (sebastian_k)
May 10 2019, 2:57 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Dalai Felinto (dfelinto)
Michael Soluyanov (crantisz)
Philipp Oeser (lichtwerk)
Sebastian Koenig (sebastian_k)
Sebastian Parborg (zeddb)
Tokens
"Party Time" token, awarded by crantisz.

Description

System Information
Operating system: elementaryOS 0.4.1
Graphics card: GTX 1080

Blender Version
Broken: 2.80, 259ebdd01725

Worked: did work couple of revisions back

Short description of error
Objects in nested Collections are highlighted wrong when selected. In one case the Empty Axis itself is highlighted correctly, while the outline is not highlighted. In the other case the object gets highlighted when the collection instance is highlighted, even though the object instance isn't even part of the collection. It's kinda hard to describe...

Exact steps for others to reproduce the error
Open this file.

collection_selection_hightlight.blend660 KBDownload

The scene 'Scene.001' is open, where I have created 2 collection instances.
Notice how the object 'cube_instance' has a highlighted origin, but not the outline.
However, if you select the object 'supergroup', there are two cubes highlighted, even though only one of them is actually part of the collection.
The Objects and Collections are setup in the other scene 'Scene'.
Somehow the nesting messes up the selection highlighting.

Revisions and Commits

rB Blender
rB57c26453f8aa Fix T66295 Collection instance duplicates don't have selection outline

Related Objects

Mentioned In
T66295: Collection instance duplicates don't have selection outline
rB5df4c0a4693c: Outliner: Fix selecting collections in view layer selecting original objects
Mentioned Here
T66295: Collection instance duplicates don't have selection outline
rBb6b3a57c2241: DRW: Add DRW_duplidata_get to create fast path for duplis
rB6df7946f7360: Object Overlay: Add dupli fast path
rB259ebdd01725: Fix failing tests when Cycles is enabled

Event Timeline

Sebastian Koenig (sebastian_k) created this task.May 10 2019, 2:57 PM
Sebastian Koenig (sebastian_k) added a subscriber: Dalai Felinto (dfelinto).May 16 2019, 9:08 AM

Found an interesting twist to this bug.
I have created a collection instance of the collection 'supergroup' in the first Scene, called 'supergroup_instance'.
If you open this file

collection_selection_hightlight.blend657 KBDownload
,
'supergroup_instance' is selected. But only the Empty crosses of it are highlighted, not the outline.
Now if you exclude the collection 'supergroup' from the viewlayer with the checkmark toggle, 'supergroup_instance' becomes highlighted.
Sounds like something for @Dalai Felinto (dfelinto)? :)

Dalai Felinto (dfelinto) claimed this task.May 16 2019, 4:43 PM
Dalai Felinto (dfelinto) added a subscriber: Brecht Van Lommel (brecht).May 24 2019, 5:22 PM

Before getting into your more complicated file I reproduce some strange behaviour that I will look at it first:

instance_collection_select.blend119 KBDownload

To reproduce the bug just select the "A - I have a torus" collection that is INSIDE the "B - I instanced a torus"

What to expect: Nothing gets selected.
What we get: The torus gets selected.

Note: The camera is there so you can reliably reset the selected object.

Dalai Felinto (dfelinto) added a comment.May 24 2019, 7:56 PM

My suggestion which I will look at:

  1. In View Layer clicking in a collection NEVER select its objects.
  2. In Scenes and Blender File we can keep this behaviour.
  3. Selecting the instance (Empty) itself should should the instanced collection as selected..
Dalai Felinto (dfelinto) mentioned this in rB5df4c0a4693c: Outliner: Fix selecting collections in view layer selecting original objects.May 24 2019, 11:51 PM
Sebastian Parborg (zeddb) lowered the priority of this task from 90 to 50.Jun 11 2019, 3:39 PM
Sebastian Parborg (zeddb) added a subscriber: Sebastian Parborg (zeddb).

I'll mark this as confirmed as it seems like it has been reproduced and a partial fix has already made it in.

Michael Soluyanov (crantisz) added a subscriber: Michael Soluyanov (crantisz).Jun 12 2019, 1:50 PM

Affects me to.
here the step, were it was broken:

Broken: version: 2.80 (sub 74), branch: blender2.7, commit date: 2019-06-11 21:45, hash: rBd93a7290e506
Broken: version: 2.80 (sub 61), branch: blender2.7, commit date: 2019-05-12 22:25, hash: rB05f1451d7248
Worked: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: rB3dc9da3a74ee

beetween 60 and 61 subversions.

here my test file:

instance selection test.blend658 KBDownload

Looks like instance outlines only if first instance selected also,

Sebastian Koenig (sebastian_k) mentioned this in T66295: Collection instance duplicates don't have selection outline.Jul 1 2019, 11:40 AM
Philipp Oeser (lichtwerk) added subscribers: Clément Foucault (fclem), Philipp Oeser (lichtwerk).Jul 1 2019, 12:24 PM

Just bisected a seemingly related task (T66295), and that one was broken by rB6df7946f7360, rBb6b3a57c2241, so adding @Clément Foucault (fclem) here... [not quite sure if these are indeed duplicates...]

Clément Foucault (fclem) changed the task status from Unknown Status to Resolved by committing rB57c26453f8aa: Fix T66295 Collection instance duplicates don't have selection outline.Jul 2 2019, 4:04 PM
Clément Foucault (fclem) added a commit: rB57c26453f8aa: Fix T66295 Collection instance duplicates don't have selection outline.
Michael Soluyanov (crantisz) awarded a token.Jul 2 2019, 4:42 PM