Maniphest T65360

Failure to install add-on with multiple dots in filename
Closed, Resolved
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
brothermechanic (brothermechanic)
May 31 2019, 7:29 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
brothermechanic (brothermechanic)
Philipp Oeser (lichtwerk)
stephen leger (stephen_leger)

Description

System Information
Operating system:
Graphics card:

Blender Version
Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen)
Worked: 2.79*

Short description of error
Please see my screencast

Related Objects

Event Timeline

brothermechanic (brothermechanic) created this task.May 31 2019, 7:29 PM
Brecht Van Lommel (brecht) lowered the priority of this task from 90 to 30.May 31 2019, 7:31 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Please provide all the requested information in the bug submission template, and exact steps to reproduce the issue.

If it's a specific add-on that fails, attach the add-on.

brothermechanic (brothermechanic) renamed this task from Can't load addon from Alternate path to Can't load addon from User and Alternate paths.May 31 2019, 7:49 PM
brothermechanic (brothermechanic) renamed this task from Can't load addon from User and Alternate paths to Can't load addon from User path.
stephen leger (stephen_leger) added a subscriber: stephen leger (stephen_leger).Jun 1 2019, 8:27 PM

Multiple dots in filename make it fails, try to rename your .zip into Modeling-clothing-28.zip

Brecht Van Lommel (brecht) renamed this task from Can't load addon from User path to Failure to install add-on with dot in name.Jun 6 2019, 6:12 PM
Brecht Van Lommel (brecht) renamed this task from Failure to install add-on with dot in name to Failure to install add-on with multiple dots in filename.
Brecht Van Lommel (brecht) raised the priority of this task from 30 to 50.
Brecht Van Lommel (brecht) assigned this task to Philipp Oeser (lichtwerk).Jul 3 2019, 6:22 PM
Brecht Van Lommel (brecht) added a subscriber: Philipp Oeser (lichtwerk).

@Philipp Oeser (lichtwerk), is this one you could look into?

Philipp Oeser (lichtwerk) added a comment.Jul 3 2019, 6:46 PM

Yes, will check...

Philipp Oeser (lichtwerk) added a comment.Jul 18 2019, 6:16 PM

Checked this, and it is not the . in the zipfile name, offending is the . in the foldername inside that zipfile...
2.79 also didnt allow for this (not sure why the report suggests this was working there?)

  • folder Modeling-Cloth-2.8-master in Modeling-Cloth-2.8-master.zip -> failure
  • folder Modeling-Cloth-2_8-master in Modeling-Cloth-2.8-master.zip -> success

As the folder will be the python package: pretty sure python doesnt allow for top level packages to contain a .?

For sure bpy.path.module_names() doesnt allow this [which is why this addon then wont be loaded]

What we could do here though is to check inside the .zip if we would find offending package names prior to copying this to the addons folder and tell the user that the installation failed.

Philipp Oeser (lichtwerk) mentioned this in T68966: Addons not showing in list.Aug 21 2019, 1:12 PM
Philipp Oeser (lichtwerk) mentioned this in D6140: Notify the user when blender tries to load a module directory with a '.' in it.Oct 28 2019, 2:14 PM
Rune Morling (ermo) mentioned this in D6144: Raise a more explanatory exception when failing to enable an Addon module from a directory containing a '.'.Oct 28 2019, 9:33 PM
Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved.Oct 29 2019, 9:32 AM

This has now been addressed/clarified by rB9267e6275cc9, closing...