Maniphest T65598

Material shadows not updated with rna_Material_draw_update
Closed, DuplicateBUG
Actions

Assigned To
None
Authored By
Ulysse Martin (youle)
Jun 7 2019, 10:22 AM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Alexey (tombambadil)
Clément Foucault (fclem)
Firepal64
Philipp Oeser (lichtwerk)
Sergey Sharybin (sergey)
Ulysse Martin (youle)

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: master (modified), commit date: 2019-06-07 06:39, hash: rBa232d27bbaca
Worked: (optional)

Short description of error
When we change material shadow mode, for example, the shadows are not updated in the viewport

Exact steps for others to reproduce the error

Steps:

  • open this .blend:

Material_shadow_mode.blend641 KBDownload

with last 2.8

  • go in "rendered" shading mode with eevee
  • change shadow mode from opaque to alpha hashed for example

-> the shadows are not updated

Note:

This patch (which is not a fix):

p.diff876 BDownload

forces the shadows update when we switch several times between shadow modes.

Related Objects

Event Timeline

Ulysse Martin (youle) created this task.Jun 7 2019, 10:22 AM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Jun 7 2019, 10:57 AM
Philipp Oeser (lichtwerk) added subscribers: Clément Foucault (fclem), Sergey Sharybin (sergey), Philipp Oeser (lichtwerk).

Can confirm that above patch enforces an update.

However I assume this has a significant performance hit, so if this is the only way to update it correctly, I gues it would be better to introduce something like rna_Material_shadow_update (which does the fancy DEG_relations_tag_update) and use it for shadow_method only?

@Clément Foucault (fclem), @Sergey Sharybin (sergey): maybe there are better ways to properly have updates?

Sergey Sharybin (sergey) added a comment.Jun 7 2019, 11:06 AM

@Philipp Oeser (lichtwerk), i am not sure why shadows needs relation update. I don't remember any code in dependency graph which does anything related on shading settings.
To me it seems that the issue is somewhere else. Either wrong recalc tag is used or some ID doesn't get tagged when needed.

Brecht Van Lommel (brecht) merged a task: T67519: Shadow settings for textures with alpha not updated correctly in viewport (Eevee).Jul 23 2019, 5:06 PM
Brecht Van Lommel (brecht) added a subscriber: Alexey (tombambadil).
Brecht Van Lommel (brecht) merged a task: T68663: EEVEE Alpha Clip/Hashed shadows don't auto-refresh every frame in the viewport.Aug 14 2019, 11:46 PM
Brecht Van Lommel (brecht) added a subscriber: Firepal64.
Philipp Oeser (lichtwerk) added a project: Eevee.Sep 13 2019, 11:50 AM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.Dec 23 2019, 4:34 PM
Clément Foucault (fclem) changed the subtype of this task from "Report" to "Bug".Jan 17 2020, 7:51 PM
Clément Foucault (fclem) edited projects, added EEVEE & Viewport; removed Tracker Curfew.
Clément Foucault (fclem) closed this task as a duplicate of T68165: EEVEE: Material update does not trigger shadowmap update.
Clément Foucault (fclem) removed a project: Eevee.Jun 19 2020, 11:06 PM