Maniphest T65824

The span keyword in mesh.fill_grid is not working in 2.80
Closed, Resolved

Assigned To
Campbell Barton (campbellbarton)
Authored By
nBurn (nBurn)
Jun 15 2019, 2:45 AM
Tags
  • BF Blender
  • Add-ons (BF-Blender)
Subscribers
nBurn (nBurn)

Description

Blender Version
Broken: 2.80 (Windows 64, 8ac0fef4dfd1)
Worked: 2.79 (Windows 64), 2.80 (Windows 64, dc3b5024be1a)

Short description of error

There is no difference in the geometry that is created regardless of what the "span" value is changed to when running bpy.ops.mesh.fill_grid(). I have verified this both in scripts and the Python Console.

The span keyword used to work in Blender 2.80 the same as it did in 2.79, but the keyword appears to have stopped working after this commit was applied:

rB3d8cbb534f8277840b51f0ec7003f77ee2391f16

-            if (RNA_property_is_set(op->ptr, prop_span)) {
+            /* Only reuse on redo because these settings need to match the current selection.
+             * We never want to use them on other geometry, repeat last for eg, see: T60777. */
+            if ((op->flag & OP_IS_REPEAT) &&
+                RNA_property_is_set(op->ptr, prop_span))
+            {

Exact steps for others to reproduce the error

  • Add a cylinder with 32 vertices, and set the cap fill type to nothing
  • With the cylinder selected, switch to edit mode
  • Make sure only the top edge ring on the cylinder is selected
  • Switch to the scripting workspace / tab (so the python console is available)
  • Paste the following code into the python console and execute it
  • bpy.ops.mesh.fill_grid('INVOKE_DEFAULT', span=3, offset=0, use_interp_simple=False)

The bottom 2 screenshots show the differing results after running the above command in both 2.79 and 2.80

2.79 results:

2.80 results:

Revisions and Commits

rB Blender
Abandoned

Related Objects

Mentioned In
D5119: Possible fix for T65824
Mentioned Here
rB3d8cbb534f82: Fix T60777: Grid fill fails when run via Repeat Last
T60777: grid fill bug on repeat last operation
rB1cbe3b6e0388: Multi-Object-Editing : Support for Grid Fill by Falk David
rB8ac0fef4dfd1: Cleanup: sort structs

Event Timeline

nBurn (nBurn) created this task.Jun 15 2019, 2:45 AM
nBurn (nBurn) added a subscriber: Dalai Felinto (dfelinto).
nBurn (nBurn) updated the task description.Jun 15 2019, 2:51 AM
nBurn (nBurn) added a project: Add-ons (BF-Blender).
nBurn (nBurn) updated the task description.Jun 15 2019, 2:54 AM
nBurn (nBurn) updated the task description.Jun 15 2019, 4:42 AM
nBurn (nBurn) assigned this task to Campbell Barton (campbellbarton).Jun 16 2019, 9:17 AM
nBurn (nBurn) updated the task description.
nBurn (nBurn) removed a subscriber: Dalai Felinto (dfelinto).
nBurn (nBurn) updated the task description.Jun 16 2019, 9:21 AM
Sebastian Parborg (zeddb) lowered the priority of this task from 90 to 50.Jun 20 2019, 2:42 PM
nBurn (nBurn) updated the task description.Jun 20 2019, 8:51 PM
nBurn (nBurn) updated the task description.Jun 22 2019, 8:32 AM
Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rB1c94030238bb: Fix T65824: Span property ignored in mesh.fill_grid.Jun 24 2019, 1:44 PM
Campbell Barton (campbellbarton) added a commit: rB1c94030238bb: Fix T65824: Span property ignored in mesh.fill_grid.