Maniphest T65899

Crash on add workspace via /+\ tab
Closed, Resolved

Assigned To
Brecht Van Lommel (brecht)
Authored By
Gavin Scott (Zoot)
Jun 18 2019, 2:36 AM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Gavin Scott (Zoot)
Jacques Lucke (JacquesLucke)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.17

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-06-17 21:07, hash: rB741641f4c3b8

Short description of error
Crash creating an additional workspace from /+\ workspace tab. It's intermittent in a production build but 100% reproducible here in a debug build (tested with an empty ...\2.80\config dir as well)

Exact steps for others to reproduce the error
Start Blender, and from the /+\ menu in the workspace tab list, select General->Layout.

Blender will often crash at this point. In a debug build it happens every time I try it. VSCode backtrace:

blender.exe!WM_event_get_keymap_from_toolsystem(wmWindowManager * wm, wmEventHandler_Keymap * handler) Line 3663 (g:\bdev\blender\source\blender\windowmanager\intern\wm_event_system.c:3663)
blender.exe!WM_event_get_keymap_from_handler(wmWindowManager * wm, wmEventHandler_Keymap * handler) Line 4912 (g:\bdev\blender\source\blender\windowmanager\intern\wm_event_system.c:4912)
blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2693 (g:\bdev\blender\source\blender\windowmanager\intern\wm_event_system.c:2693)
blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2947 (g:\bdev\blender\source\blender\windowmanager\intern\wm_event_system.c:2947)
blender.exe!wm_event_do_handlers(bContext * C) Line 3390 (g:\bdev\blender\source\blender\windowmanager\intern\wm_event_system.c:3390)
blender.exe!WM_main(bContext * C) Line 420 (g:\bdev\blender\source\blender\windowmanager\intern\wm.c:420)
blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 502 (g:\bdev\blender\source\creator\creator.c:502)
blender.exe!invoke_main() Line 79 (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79)
blender.exe!scrt_common_main_seh() Line 288 (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
blender.exe!
scrt_common_main() Line 331 (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331)
blender.exe!mainCRTStartup() Line 17 (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
kernel32.dll!00007ff856894034() (Unknown Source:0)
ntdll.dll!00007ff858a53691() (Unknown Source:0)

Code:

Trap at wm_event_system.c:3663 >

/** Follow #wmEventHandler_KeymapDynamicFn signiture. */
wmKeyMap *WM_event_get_keymap_from_toolsystem(wmWindowManager *wm, wmEventHandler_Keymap *handler)
{
  ScrArea *sa = handler->dynamic.user_data;
  handler->keymap_tool = NULL;
  bToolRef_Runtime *tref_rt = sa->runtime.tool ? sa->runtime.tool->runtime : NULL;
> if (tref_rt && tref_rt->keymap[0]) {

sa->runtime.tool fields are all 0xdd filled or otherwise nonsense at this point.

Revisions and Commits

rB Blender

Event Timeline

Gavin Scott (Zoot) created this task.Jun 18 2019, 2:36 AM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Jun 18 2019, 3:25 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Getting this, too (happening when you add the same workspace type you are in [and only if this contains a timeline])

BLI_assert failed: /blender/source/blender/editors/interface/interface.c:3587, ui_def_but(), at 'width >= 0 && height >= 0'`

1  raise                                                    0x7ffff1bb1eb5 
2  abort                                                    0x7ffff1b9c895 
3  ui_def_but                        interface.c       3587 0x2a58f18      
4  ui_def_but_rna                    interface.c       4145 0x2a5a84d      
5  uiDefButR_prop                    interface.c       4744 0x2a5b802      
6  uiDefAutoButR                     interface_utils.c 225  0x2ac7e0e      
7  ED_time_scrub_channel_search_draw time_scrub_ui.c   199  0x30d0e1a      
8  action_channel_region_draw        space_action.c    284  0x2fe2218      
9  ED_region_do_draw                 area.c            567  0x2eb4819      
10 wm_draw_window_offscreen          wm_draw.c         596  0x23c16b1      
11 wm_draw_window                    wm_draw.c         732  0x23c1c30      
12 wm_draw_update                    wm_draw.c         895  0x23c213c      
13 WM_main                           wm.c              423  0x23be2b8      
14 main                              creator.c         500  0x1d7bf86
Philipp Oeser (lichtwerk) assigned this task to Brecht Van Lommel (brecht).Jun 18 2019, 3:27 PM
Philipp Oeser (lichtwerk) added subscribers: Jacques Lucke (JacquesLucke), Brecht Van Lommel (brecht).

@Jacques Lucke (JacquesLucke), @Brecht Van Lommel (brecht): ideas?

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rB0a3e73a91fb0: Fix T65899, T66314, T61808: various issues appending workspaces.Jul 3 2019, 8:45 PM
Brecht Van Lommel (brecht) added a commit: rB0a3e73a91fb0: Fix T65899, T66314, T61808: various issues appending workspaces.