Maniphest T66026

CTest/Cycles subdiv related failures
Closed, Resolved

Assigned To
Ray Molenkamp (LazyDodo)
Authored By
Ray Molenkamp (LazyDodo)
Jun 22 2019, 8:16 PM
Tags
  • Cycles
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Ray Molenkamp (LazyDodo)

Description

System Information
Operating system: Win/Mac
Graphics card: N/A

Blender Version
Broken: 953419c
Worked: day before... possibly..

Short description of error

In last nights test I had one fail on mac (cycles_reports/T50655) and one on windows (cycles_displacement/true_displacement_image) running both with the debug heap (kinda like asan, but not quite) i was able to repro both crashes with virtually identical callstacks

 Index  Function
--------------------------------------------------------------------------------
 1      blender.exe!OpenSubdiv::v3_3_3::Osd::CpuPatchTable::CpuPatchTable(class OpenSubdiv::v3_3_3::Far::PatchTable const *)
*2      blender.exe!OpenSubdiv::v3_3_3::Osd::CpuPatchTable::Create(const OpenSubdiv::v3_3_3::Far::PatchTable * patchTable, void * deviceContext)
 3      blender.exe!opensubdiv_capi::`anonymous namespace'::VolatileEvalOutput<OpenSubdiv::v3_3_3::Osd::CpuVertexBuffer,OpenSubdiv::v3_3_3::Osd::CpuVertexBuffer,OpenSubdiv::v3_3_3::Far::StencilTable,OpenSubdiv::v3_3_3::Osd::CpuPatchTable,OpenSubdiv::v3_3_3::Osd::CpuEvaluator,void>::VolatileEvalOutput<OpenSubdiv::v3_3_3::Osd::CpuVertexBuffer,OpenSubdiv::v3_3_3::Osd::CpuVertexBuffer,OpenSubdiv::v3_3_3::Far::StencilTable,OpenSubdiv::v3_3_3::Osd::CpuPatchTable,OpenSubdiv::v3_3_3::Osd::CpuEvaluator,void>(const OpenSubdiv::v3_3_3::Far::StencilTable * vertex_stencils, const OpenSubdiv::v3_3_3::Far::StencilTable * varying_stencils, const std::vector<OpenSubdiv::v3_3_3::Far::StencilTable const *,std::allocator<OpenSubdiv::v3_3_3::Far::StencilTable const *> > & all_face_varying_stencils, const int face_varying_width, const OpenSubdiv::v3_3_3::Far::PatchTable * patch_table, OpenSubdiv::v3_3_3::Osd::EvaluatorCacheT<OpenSubdiv::v3_3_3::Osd::CpuEvaluator> * evaluator_cache, void * device_context)
 4      blender.exe!opensubdiv_capi::CpuEvalOutput::CpuEvalOutput(const OpenSubdiv::v3_3_3::Far::StencilTable * vertex_stencils, const OpenSubdiv::v3_3_3::Far::StencilTable * varying_stencils, const std::vector<OpenSubdiv::v3_3_3::Far::StencilTable const *,std::allocator<OpenSubdiv::v3_3_3::Far::StencilTable const *> > & all_face_varying_stencils, const int face_varying_width, const OpenSubdiv::v3_3_3::Far::PatchTable * patch_table, OpenSubdiv::v3_3_3::Osd::EvaluatorCacheT<OpenSubdiv::v3_3_3::Osd::CpuEvaluator> * evaluator_cache)
 5      blender.exe!openSubdiv_createEvaluatorInternal(OpenSubdiv_TopologyRefiner * topology_refiner)
 6      blender.exe!openSubdiv_createEvaluatorFromTopologyRefiner(OpenSubdiv_TopologyRefiner * topology_refiner)
 7      blender.exe!BKE_subdiv_eval_begin(Subdiv * subdiv)
 8      blender.exe!BKE_subdiv_eval_update_from_mesh(Subdiv * subdiv, const Mesh * mesh)
 9      blender.exe!BKE_subdiv_to_mesh(Subdiv * subdiv, const SubdivToMeshSettings * settings, const Mesh * coarse_mesh)
 10     blender.exe!subdiv_as_mesh(SubsurfModifierData * smd, const ModifierEvalContext * ctx, Mesh * mesh, Subdiv * subdiv)
 11     blender.exe!applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh)
 12     blender.exe!modwrap_applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * me)
 13     blender.exe!mesh_calc_modifiers(Depsgraph * depsgraph, Scene * scene, Object * ob, int useDeform, const bool need_mapping, const CustomData_MeshMasks * dataMask, const int index, const bool use_cache, const bool allow_shared_mesh, Mesh * * r_deform, Mesh * * r_final)
 14     blender.exe!mesh_build_data(Depsgraph * depsgraph, Scene * scene, Object * ob, const CustomData_MeshMasks * dataMask, const bool need_mapping)
 15     blender.exe!makeDerivedMesh(Depsgraph * depsgraph, Scene * scene, Object * ob, BMEditMesh * em, const CustomData_MeshMasks * dataMask)
 16     blender.exe!BKE_object_handle_data_update(Depsgraph * depsgraph, Scene * scene, Object * ob)
 17     blender.exe!BKE_object_eval_uber_data(Depsgraph * depsgraph, Scene * scene, Object * ob)
 18     [External Code]
 19     blender.exe!DEG::deg_task_run_func(TaskPool * pool, void * taskdata, int thread_id)
 20     blender.exe!task_scheduler_thread_run(void * thread_p)
 21     [External Code]
 22     blender.exe!invoke_thread_procedure(unsigned int(*)(void *) procedure, void * const context)
 23     blender.exe!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void * const parameter)
 24     [External Code]

running the whole cyles test revealed the following failures, i sampled a few and it seems safe to assume it's all the same bug.

60: [  FAILED  ] true_displacement_image
68: [  FAILED  ] tangent_missing_uv
68: [  FAILED  ] tangent_render_uv
68: [  FAILED  ] tangent_specific_uv_other
68: [  FAILED  ] tangent_specific_uv_render
68: [  FAILED  ] tangent_triangles
71: [  FAILED  ] T42475_1
71: [  FAILED  ] T42475_2
71: [  FAILED  ] T43156
71: [  FAILED  ] T50655

Exact steps for others to reproduce the error

Load or render any of the files above. (will probably need an asan build or debug heap on windows) to repro.

Related Objects

Mentioned In
T66025: RBG node crashes Blender 2.8
T63766: Multiresolution behavior when using crease edge
Mentioned Here
rBae6300a8b74b: Fix T66022: crash adding subdivision surface modifier to some meshes
rB953419c641a7: macOS: install license files inside Blender.app bundle

Event Timeline

Ray Molenkamp (LazyDodo) created this task.Jun 22 2019, 8:16 PM
Ray Molenkamp (LazyDodo) edited projects, added Cycles; removed BF Blender.
Ray Molenkamp (LazyDodo) updated the task description.Jun 22 2019, 8:38 PM
Brecht Van Lommel (brecht) added a project: BF Blender.Jun 22 2019, 11:45 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Possibly solved by rBae6300a8b74b: Fix T66022: crash adding subdivision surface modifier to some meshes, though I could not reproduce the crash.

Ray Molenkamp (LazyDodo) changed the task status from Unknown Status to Resolved.Jun 23 2019, 12:41 AM
Ray Molenkamp (LazyDodo) claimed this task.

Just pulled, it's fixed now.

Alessio Monti di Sopra (a.monti) mentioned this in T66025: RBG node crashes Blender 2.8.Jun 23 2019, 11:55 AM