Maniphest T66146

Node Editor: Node Actions not started from the mouse are directly confirmed
Closed, ResolvedBUG
Actions

Assigned To
Sebastian Parborg (zeddb)
Authored By
Jeroen Bakker (jbakker)
Jun 26 2019, 10:35 AM
Tags
  • BF Blender
Subscribers
Bartosz Moniewski (monio)
Jeroen Bakker (jbakker)
Sebastian Koenig (sebastian_k)
Sebastian Parborg (zeddb)

Description

System Information
Operating system: Linux-4.15.0-52-generic-x86_64-with-Ubuntu-18.04-bionic 64 Bits
Graphics card: AMD Radeon (TM) Pro WX 7100 Graphics ATI Technologies Inc. 4.5.13542 Core Profile Context FireGL 18.50.1.418

Blender Version
Broken: version: 2.80 (sub 74), branch: Unknown, commit date: Unknown Unknown, hash: rBUnknown
Worked: (optional)

Short description of error
When performing actions on mouse from a keyboard ('G' or 'Shift-D' for example), the actions are confirmed directly. I was able to reproduce this issue in any node editor. (Shader, Compositor etc)

Exact steps for others to reproduce the error

  1. Open a node editor
  2. Select a node
  3. Perform an action starting from a key stroke (Shift-D for example)

The node is duplicated but depending on actual type of node the node might be placed exactly on top of the previous node. I would expect that the user could move the node around and confirm it by himself.

Related Objects

Mentioned Here
D5139: Fix T66146: Node Editor: Node Actions not started from the mouse are directly confirmed
rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts

Event Timeline

Jeroen Bakker (jbakker) created this task.Jun 26 2019, 10:35 AM
Sebastian Koenig (sebastian_k) added a subscriber: Sebastian Koenig (sebastian_k).Jun 26 2019, 10:54 AM

This is rather new though. Pretty sure it didn't confirm until 1 or 2 days ago.

Jeroen Bakker (jbakker) renamed this task from Node Editor: Duplicate Nodes Automatically Confirms Action to Node Editor: Node Actions not started from the mouse are directly confirmed.Jun 26 2019, 11:22 AM
Jeroen Bakker (jbakker) updated the task description.
Jeroen Bakker (jbakker) added a comment.Jun 26 2019, 11:25 AM

Seems to be introduced by rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts

Brecht Van Lommel (brecht) assigned this task to Sebastian Parborg (zeddb).Jun 26 2019, 11:39 AM
Brecht Van Lommel (brecht) lowered the priority of this task from 90 to High.
Sebastian Parborg (zeddb) added a comment.Jun 26 2019, 4:00 PM

The issue here is that the key map ships with "Confirm on Release" for the g shortcuts in the node editor. However, for the node.translate_attach binding, this setting isn't visible and no options can be changed from this operator...
So besides just having messed up default keybindings that came to light after my fix, we also have a bug with shortcuts.

Sebastian Parborg (zeddb) added a comment.Jun 26 2019, 5:01 PM

I've posted a fix here: D5139

Sebastian Parborg (zeddb) changed the task status from Unknown Status to Resolved.Jun 26 2019, 6:00 PM
Sebastian Parborg (zeddb) merged a task: T66160: Node editor - broken Grab operator behaviour.Jun 27 2019, 9:15 AM
Sebastian Parborg (zeddb) added subscribers: Bartosz Moniewski (monio), Sebastian Parborg (zeddb).