Maniphest T66282

Make Instances Real: Keep Hierarchy option has no effect when duplicates are collection instances
Closed, Resolved
Actions

Assigned To
Bastien Montagne (mont29)
Authored By
Daniel (bestdani)
Jun 30 2019, 7:55 PM
Tags
  • BF Blender
Subscribers
Bastien Montagne (mont29)
Daniel (bestdani)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.39

Blender Version
Broken: version: 2.80 (sub 74), branch: blender2.8, commit date: 2019-06-30 15:32, hash: rB7c8bf77e1351

Short description of error
When using the make instance real function the hierarchy of the objects gets lost even if the keep hierarchy option is ticked which affects both the grouping of the objects inside the original collection as well as any object parenting that is involved in the collection.

Exact steps for others to reproduce the error
In the uploaded blender file execute the "Make Instance Real" operation and ensure "Keep Hierarchy" is ticked.

keep hiearchy bug.blend615 KBDownload

Revisions and Commits

rB Blender
rB699193713fc0 Fix T66282: Make Instances Real: Keep Hierarchy option broken with recursive…

Related Objects

Event Timeline

Daniel (bestdani) created this task.Jun 30 2019, 7:55 PM
Daniel (bestdani) renamed this task from Make Instances Real: Keep Hiearchy option has no effect when duplicates are collection instances to Make Instances Real: Keep Hierarchy option has no effect when duplicates are collection instances.Jul 1 2019, 8:11 AM
Daniel (bestdani) updated the task description.
Philipp Oeser (lichtwerk) assigned this task to Bastien Montagne (mont29).Jul 1 2019, 10:33 AM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.
Philipp Oeser (lichtwerk) added subscribers: Bastien Montagne (mont29), Philipp Oeser (lichtwerk).

asking @Bastien Montagne (mont29) for advice here: not 100% sure how instances are handled in this case, but the way it is handled atm. looks a little weird [duplicating collection instance contents as well as collection instances as well?]

Will confirm for the time being...

Daniel (bestdani) mentioned this in T66327: Outliner: Empty keeps being symbolized as a collection instance after the "Make Instances Real" operation..Jul 2 2019, 8:48 AM
Bastien Montagne (mont29) added a comment.Jul 3 2019, 2:06 PM

The behavior of creating object copies is working as expected (Collection copies are mere empties, not duplicollections anymore).

The problem is with re-parenting, that one is broken for anything but simplest cases, and reading the code, has been broken for years (it's trying to get parent object's new copy using child persistent_id...). Still trying to figure out the proper solution here.

Bastien Montagne (mont29) added a comment.Jul 5 2019, 6:09 PM

Pffff… this has been a nightmare to understand fully, and incoming fix only partially addresses the issue, which basically was that this code was not designed to handle recursive instancing at all.

The incoming commit, which extends/pushes a bit forward current code, is going to add some minimal support for recursive parenting (the case reported here will be working as expected e.g.), however it wont work fully in all complex cases. That would require some refactor, which is out of scope of this task, and not to be done before 2.80 is released anyway.

Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rB699193713fc0: Fix T66282: Make Instances Real: Keep Hierarchy option broken with recursive….Jul 5 2019, 6:38 PM
Bastien Montagne (mont29) added a commit: rB699193713fc0: Fix T66282: Make Instances Real: Keep Hierarchy option broken with recursive….
Philipp Oeser (lichtwerk) mentioned this in T71199: Child-parent relationships arent kept after you make instances real.Oct 30 2019, 10:36 AM