Maniphest T66327

Outliner: Empty keeps being symbolized as a collection instance after the "Make Instances Real" operation.
Closed, Resolved
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Daniel (bestdani)
Jul 2 2019, 8:38 AM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)
Daniel (bestdani)
Germano Cavalcante (mano-wii)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.39

Blender Version
Broken: version: 2.80 (sub 74), branch: blender2.8, commit date: 2019-06-30 15:32, hash: rB7c8bf77e1351
Worked: (optional)

Short description of error
(This screenshot in combination with the title)


Edit: I just noticed this symbol also stays the same when just switchting between None and Collection in the properties panel. While it might makes sense from a users perspective in this case it is at least odd when keeping left with this after the mentioned operation. Also see my comment below.

Exact steps for others to reproduce the error
Select a collection instance and execute the "Make Instances Real" operation. For example in this blend file:

instance still shown.blend609 KBDownload

Revisions and Commits

rB Blender
ClosedD5169 Fix "Make instance real" and outliner duplicollections representation
rB784121d62abf Fix T66327 2/2: Make instance real does not clear collection
rB68c39e2b4117 Fix T66327 1/2: Outliner dupli empty is shown as collection when a different…

Related Objects

Event Timeline

Daniel (bestdani) created this task.Jul 2 2019, 8:38 AM
Daniel (bestdani) added a comment.EditedJul 2 2019, 8:48 AM

I just noticed this also keeps happening when just switching between "Collection" an "None" in the Instancing property setting unless the value where the instanced collection can be selected is cleared, so maybe this is the actual bug or that the value is not cleared after the operation is performed.

I'll keep the original bug report since I think the whole behavior is a bit weird, not sure if it's rather a paper cut or not.

There are also weird things going on regarding collection instances and the "Make Instances Real" operation in other combinations, so this is probably also somehow related to: https://developer.blender.org/T66282

Daniel (bestdani) updated the task description.Jul 2 2019, 8:52 AM
Germano Cavalcante (mano-wii) assigned this task to Brecht Van Lommel (brecht).Jul 2 2019, 4:57 PM
Germano Cavalcante (mano-wii) added subscribers: Dalai Felinto (dfelinto), Brecht Van Lommel (brecht), Germano Cavalcante (mano-wii).

@Brecht Van Lommel (brecht) or @Dalai Felinto (dfelinto), is that a bug?

Brecht Van Lommel (brecht) added a comment.Jul 2 2019, 5:02 PM

I think so, two potential issues here:

  • Make Instances Real not clear the group pointer on the object.
  • The outliner not checking the instancing type and only looking at the group pointer.
Brecht Van Lommel (brecht) lowered the priority of this task from 90 to 50.Jul 2 2019, 5:02 PM
Dalai Felinto (dfelinto) added a comment.Jul 2 2019, 8:33 PM

We have the same issue in 2.79 it seems.
The fix is easy though, and I think we should tackle it both ways (outliner to take instancing type into consideration, and make instance real to set group/collection pointer to null).

Dalai Felinto (dfelinto) added a revision: D5169: Fix "Make instance real" and outliner duplicollections representation.Jul 2 2019, 11:20 PM
Dalai Felinto (dfelinto) changed the task status from Unknown Status to Resolved by committing rB68c39e2b4117: Fix T66327 1/2: Outliner dupli empty is shown as collection when a different….Jul 5 2019, 5:29 PM
Dalai Felinto (dfelinto) added a commit: rB68c39e2b4117: Fix T66327 1/2: Outliner dupli empty is shown as collection when a different….
Dalai Felinto (dfelinto) added a commit: rB784121d62abf: Fix T66327 2/2: Make instance real does not clear collection.