Maniphest T66630

X-Ray + Subdivision surface Face select problem
Closed, ResolvedBUG
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Andrey Rusnak (AndreyRusnak)
Jul 9 2019, 11:36 PM
Tags
  • BF Blender
Subscribers
andrew lane (jamesponge)
Andrey Rusnak (AndreyRusnak)
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Craig Dolphin (craigdolphin)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 580/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 391.35

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-09 12:03, hash: rBdb45aaafab8c
Worked: (optional)

Short description of error
I cannot select faces when X-ray mode is on, if the Subsurface modifier is enabled on the object (with the number of subdivisions in viewport > 0).

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Revisions and Commits

rB Blender
AbandonedD5215 Selection: Face selection with XRay and Subdiv
rB6f1190cbf0ea Fix T66630 X-Ray + Subdivision surface Face select problem

Related Objects

Mentioned In
T66632: blender 2.8 edit mode error (face select)
T66636: When X-Ray active selection not work
Mentioned Here
rB226c6f086aa2: Fix T62941 Subdivision Modifier Showing all face dots

Event Timeline

Andrey Rusnak (AndreyRusnak) created this task.Jul 9 2019, 11:36 PM
Jeroen Bakker (jbakker) mentioned this in T66636: When X-Ray active selection not work.Jul 10 2019, 8:38 AM
Jeroen Bakker (jbakker) claimed this task.EditedJul 10 2019, 8:44 AM
Jeroen Bakker (jbakker) lowered the priority of this task from 90 to High.

I am able to reproduce it. I raised it as high prio as this is core functionality.

T66630.blend609 KBDownload

Jeroen Bakker (jbakker) added a comment.EditedJul 10 2019, 8:56 AM

Commit that broke this is {226c6f086aa255bb71e554c860545bb435c06756}

The selection seems to be a state error.

when in mesh_foreachScreenFace the flag ME_VERT_FACEDOT is not set so it will never check the facedots.

Brecht Van Lommel (brecht) added subscribers: Clément Foucault (fclem), Brecht Van Lommel (brecht).Jul 10 2019, 11:08 AM

CC @Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a revision: D5215: Selection: Face selection with XRay and Subdiv.Jul 10 2019, 11:10 AM
Philipp Oeser (lichtwerk) mentioned this in T66632: blender 2.8 edit mode error (face select).Jul 10 2019, 11:33 AM
Philipp Oeser (lichtwerk) merged a task: T66632: blender 2.8 edit mode error (face select).
Philipp Oeser (lichtwerk) added subscribers: andrew lane (jamesponge), Philipp Oeser (lichtwerk), Craig Dolphin (craigdolphin).
Clément Foucault (fclem) changed the task status from Unknown Status to Resolved by committing rB6f1190cbf0ea: Fix T66630 X-Ray + Subdivision surface Face select problem.Jul 10 2019, 12:13 PM
Clément Foucault (fclem) added a commit: rB6f1190cbf0ea: Fix T66630 X-Ray + Subdivision surface Face select problem.