Maniphest T66645

Vertex color painting. Syringe is screen-color dependent.
Closed, Archived
Actions

Assigned To
Pablo Dobarro (pablodp606)
Authored By
Vyacheslav (hitrpr)
Jul 10 2019, 7:06 AM
Tags
  • BF Blender
  • Tracker Curfew
Subscribers
Clément Foucault (fclem)
Germano Cavalcante (mano-wii)
Jeroen Bakker (jbakker)
Pablo Dobarro (pablodp606)
Philipp Oeser (lichtwerk)
Tokens
"Love" token, awarded by hitrpr.

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: sculpt-mode-features, commit date: 2019-07-08 14:21, hash: rB3539cd38a454

Short description of error
As I am picking color from viewport pixels, not from VCOL data, it is almost impossible to match color (even with flat shading) and syringe become useless.

Exact steps for others to reproduce the error
Toggle vertex color mode, try to paint any color, then pick it with S and paint again

vp.blend679 KBDownload

Related Objects

Event Timeline

Vyacheslav (hitrpr) created this task.Jul 10 2019, 7:06 AM
Vyacheslav (hitrpr) added a comment.Jul 10 2019, 7:42 AM

texture painting checked, all is okay, it takes color right from bitmap.

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Jul 10 2019, 1:37 PM
Philipp Oeser (lichtwerk) added subscribers: Clément Foucault (fclem), Jeroen Bakker (jbakker), Philipp Oeser (lichtwerk).

Even though this is not my area, I'm enrapt to confirm this.

@Jeroen Bakker (jbakker), @Clément Foucault (fclem): mind sharing your wisdom how we are displaying VCOLs?
Solid, Flat, Color set to Vertex doesnt end up displaying the same values we painted it seems? (at least glReadPixels in paint_sample_color doesnt read the same back)
Colormanagement should not take affect here, right?

Jeroen Bakker (jbakker) added a comment.Jul 10 2019, 2:14 PM

The color is differnet. For example the overlay is multiplied on top of the shaded model. In the example file the transparency is set to 0.8 what will do the next mix

linear_to_srgb(0.8 * srgb_to_linear(color) + 0.2 * white) * shaded color from render engine.

When setting setting the opacity of the vertex paint overlay to 0.0 it should give the right colors. We know that this part is still lacking some final tweaks.

Philipp Oeser (lichtwerk) added a comment.Jul 10 2019, 2:39 PM

OK, get it, thx for clarifying, it is a bit confusing though.

Would it be good to force

  • Viewport Shading Color to Vertex + Viewport Overlay Vertex Paint Opacity = 0.0 or
  • Viewport Shading Color to Single white + Viewport Overlay Vertex Paint Opacity = 1.0 then?

Sorry if this has been discussed before, is there a task for it? (this somehow slipped under my radar...)

Philipp Oeser (lichtwerk) added a comment.Jul 10 2019, 2:41 PM

In any case, I think this report can be closed then? (would still be good to know the "other task" where above mentioned final tweaks are discussed...)

Germano Cavalcante (mano-wii) lowered the priority of this task from 50 to Low.EditedJul 10 2019, 3:45 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

I made an experimental code that proposes to fix this.
It still needs to be optimized and deduplicated:

P1032 Fix T66645 - picking vertex color through the CPU
1diff --git a/source/blender/editors/sculpt_paint/paint_utils.c b/source/blender/editors/sculpt_paint/paint_utils.c
2index c8ad1b5781d..16b36b934ab 100644
3--- a/source/blender/editors/sculpt_paint/paint_utils.c
4+++ b/source/blender/editors/sculpt_paint/paint_utils.c
5@@ -484,7 +484,7 @@ void paint_sample_color(
6 palette->active_color = BLI_listbase_count(&palette->colors) - 1;
7 }
8
9- if (CTX_wm_view3d(C) && texpaint_proj) {
10+ if (CTX_wm_view3d(C)) {
11 /* first try getting a color directly from the mesh faces if possible */
12 ViewLayer *view_layer = CTX_data_view_layer(C);
13 Object *ob = OBACT(view_layer);
14@@ -504,12 +504,68 @@ void paint_sample_color(
15 unsigned int faceindex;
16 unsigned int totpoly = me->totpoly;
17
18- if (CustomData_has_layer(&me_eval->ldata, CD_MLOOPUV)) {
19- ED_view3d_viewcontext_init(C, &vc);
20-
21- view3d_operator_needs_opengl(C);
22-
23- if (imapaint_pick_face(&vc, mval, &faceindex, totpoly)) {
24+ ED_view3d_viewcontext_init(C, &vc);
25+ view3d_operator_needs_opengl(C);
26+
27+ if (imapaint_pick_face(&vc, mval, &faceindex, totpoly)) {
28+ if (!texpaint_proj && CustomData_has_layer(&me_eval->ldata, CD_MLOOPCOL)) {
29+ float matrix[4][4], proj[4][4];
30+ GLint view[4];
31+
32+ const MLoopTri *looptri = BKE_mesh_runtime_looptri_ensure(me_eval);
33+ const int tottri = me_eval->runtime.looptris.len;
34+
35+ const MVert *mvert = me_eval->mvert;
36+ const MPoly *mpoly = me_eval->mpoly;
37+ const MLoop *mloop = me_eval->mloop;
38+ struct MLoopCol *mloopcol = me_eval->mloopcol;
39+
40+ /* get the needed opengl matrices */
41+ GPU_viewport_size_get_i(view);
42+ GPU_matrix_model_view_get(matrix);
43+ GPU_matrix_projection_get(proj);
44+ view[0] = view[1] = 0;
45+ mul_m4_m4m4(matrix, matrix, ob_eval->obmat);
46+ mul_m4_m4m4(matrix, proj, matrix);
47+
48+ /* loop over all looptri's for a given polygon: i */
49+ MPoly *mp = &mpoly[faceindex];
50+ MLoopTri *lt = &looptri[poly_to_tri_count(faceindex, mp->loopstart)];
51+ int j, lt_tot = ME_POLY_TRI_TOT(mp);
52+
53+ float p[2], w[3], absw, minabsw = 1e10;
54+ for (j = 0; j < lt_tot; j++, lt++) {
55+ unsigned int vtri[3] = {
56+ mloop[lt->tri[0]].v,
57+ mloop[lt->tri[1]].v,
58+ mloop[lt->tri[2]].v,
59+ };
60+ float tri_co[3][3];
61+ copy_v3_v3(tri_co[0], mvert[vtri[0]].co);
62+ copy_v3_v3(tri_co[1], mvert[vtri[1]].co);
63+ copy_v3_v3(tri_co[2], mvert[vtri[2]].co);
64+
65+ p[0] = mval[0];
66+ p[1] = mval[1];
67+ imapaint_tri_weights(matrix, view, UNPACK3(tri_co), p, w);
68+ absw = fabsf(w[0]) + fabsf(w[1]) + fabsf(w[2]);
69+ if (absw < minabsw) {
70+ float col1[4], col2[4], col3[4];
71+ rgba_uchar_to_float(col1, (char *)&mloopcol[lt->tri[0]]);
72+ rgba_uchar_to_float(col2, (char *)&mloopcol[lt->tri[1]]);
73+ rgba_uchar_to_float(col3, (char *)&mloopcol[lt->tri[2]]);
74+ mul_v4_fl(col1, w[0]);
75+ mul_v4_fl(col2, w[1]);
76+ mul_v4_fl(col3, w[2]);
77+ add_v4_v4(col1, col2);
78+ add_v4_v4(col1, col3);
79+ rgba_float_to_uchar((char *)&col, col1);
80+
81+ minabsw = absw;
82+ }
83+ };
84+ }
85+ else if (CustomData_has_layer(&me_eval->ldata, CD_MLOOPUV)) {
86 Image *image;
87
88 if (use_material) {

Vyacheslav (hitrpr) awarded a token.Jul 10 2019, 3:51 PM
Jeroen Bakker (jbakker) added a comment.Jul 10 2019, 4:01 PM

@Philipp Oeser (lichtwerk)
Could be that there is no task yet. It was discussed last week T66421: TexturePaint: Force Workbench Color mode to Texture

Philipp Oeser (lichtwerk) added a comment.Jul 10 2019, 4:13 PM

@Germano Cavalcante (mano-wii): that's pretty cool and nice code to have, however I am unsure if there are situations where you actually want to sample not just the raw VCOLs (but actually want to sample whatever is drawn on the screen? -- same is true for texpaint as well imho)
Maybe we could trigger sampling in two modes: one for "screen truth" and one for "data truth" (defaulting to "data truth" -- as it is for texpaint atm....)?

Vyacheslav (hitrpr) added a comment.Jul 10 2019, 5:23 PM

@Philipp Oeser (lichtwerk)
Data-true will give you the same predictable result on the screen.
Screen-true will give you (right after drawing) unpredictable result.

I see the only one way to use screen color: adding it to 2d pallete, when I want exactly this one color, that I suddenly got on the screen, not for now but just as good sample (from matcaps or procedure mixes i.e.) So the default should be data-true, as for texture painting.

Sam Van Hulle (sam_vh) mentioned this in T68926: Color Management Improvements.Sep 5 2019, 12:48 PM
Philipp Oeser (lichtwerk) mentioned this in D5775: Fix T69752: Texture paint sampling colors always 'merged down'.Sep 12 2019, 2:17 PM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.Dec 23 2019, 4:33 PM
Pablo Dobarro (pablodp606) closed this task as Archived.Jan 10 2020, 4:28 PM
Pablo Dobarro (pablodp606) claimed this task.
Pablo Dobarro (pablodp606) added a subscriber: Pablo Dobarro (pablodp606).

A painting sample color operator should always pick the true color data, not the shaded color from the viewport, regardless of the viewport rendering mode. This is currently a design limitation of how the color picker was designed and there are plans to provide also the painting color picker implementation in T71947, which will complement the current design that can be used for sampling colors form a reference image or a color palette. So I consider this a feature request, not a bug.

Vyacheslav (hitrpr) removed a subscriber: Vyacheslav (hitrpr).Jan 11 2020, 1:03 AM