Maniphest T66707

Modifying bone's 'Custom Object' reference shape causes blender to crash
Closed, ResolvedBUG
Actions

Assigned To
Clément Foucault (fclem)
Authored By
Ash Curkpatrick (curkas)
Jul 11 2019, 1:53 PM
Tags
  • BF Blender
Subscribers
Ash Curkpatrick (curkas)
Clément Foucault (fclem)
Gavin Scott (Zoot)
Jeroen Bakker (jbakker)
Sebastian Parborg (zeddb)
Sergey Sharybin (sergey)
Sophia (Zophiekat)
1 More Subscribers

Description

System Information
Operating system: macOS 10.14.5
Graphics card: Radeon Pro Vega 48 8 GB

Blender Version
Broken: 2.80 Beta macOS 64bit　bb7b741d2f1c

Stable
141.42MB

Short description of error

Editing the custom shapes for a bone whilst actively being referenced will crash blender and close the application. Removing the custom bone shape and editing the reference shape before re-referencing it again will work.

Exact steps for others to reproduce the error
・Create a bone
・Create an object to reference as a custom shape
・Add the object on the bone as a 'Custom Object' for the bone shape
・Select the custom object
・Go in to Edit Mode for the object
・Select the vertices
・Move the vertices
・The application will crash

Revisions and Commits

rB Blender
rB4404a0dcd4c5 Fix T66707 Modifying bone's 'Custom Object' reference shape causes blender to…

Related Objects

Mentioned In
T66991: Crash when deleting edit bones when pchan is referenced by bendybone
T66721: 2.8 Crashing while modifying widgets on MacOS
Mentioned Here
rBbb7b741d2f1c: Fix T66654: wireframe overlay crash in vertex paint in some cases

Event Timeline

Ash Curkpatrick (curkas) created this task.Jul 11 2019, 1:53 PM
Sebastian Parborg (zeddb) added subscribers: William Reynish (billreynish), Sergey Sharybin (sergey), Sebastian Parborg (zeddb).Jul 11 2019, 2:33 PM

I can see the bone flickering when editing the object, but no crashes and ASAN doesn't complain about anything either.

@Sergey Sharybin (sergey) @William Reynish (billreynish) can you reproduce this on a mac?

William Reynish (billreynish) lowered the priority of this task from 90 to High.Jul 11 2019, 2:35 PM

Yes indeed I can reproduce this crash.

Sergey Sharybin (sergey) added a comment.Jul 11 2019, 2:37 PM

Can someone upload .blend file?

Jeroen Bakker (jbakker) lowered the priority of this task from High to 30.Jul 11 2019, 2:38 PM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).

Hello @Ash Curkpatrick (curkas)

I am not able to reproduce. Could you provide an example file to make sure I execute the steps in exactly the same way as you describe it.

Thanks.

Jeroen Bakker (jbakker) raised the priority of this task from 30 to High.Jul 11 2019, 2:39 PM
Sebastian Parborg (zeddb) added a comment.Jul 11 2019, 2:43 PM

This is the example I came up with (note that I couldn't get it to crash):

untitled.blend614 KBDownload

William Reynish (billreynish) added a comment.EditedJul 11 2019, 2:44 PM

Here's the crash log I get, when I move those verts in Edit mode:

untitled-2.crash.txt1 KBDownload

macOS Mojave 10.14.5

Sergey Sharybin (sergey) added a subscriber: Clément Foucault (fclem).Jul 11 2019, 2:58 PM

@William Reynish (billreynish), do you have crash with the file from Sebastian?

Can reproduce the flickering on my mac. Maybe it's same source of crash.

@Clément Foucault (fclem), the backtrace shows drawing code is involved. Do you have any ideas?

William Reynish (billreynish) added a comment.Jul 11 2019, 2:59 PM

@Sergey Sharybin (sergey) yes that file crashes if I enter edit mode on the mesh object and begin to move the verts. I have no flickering, only a crash here.

Gavin Scott (Zoot) mentioned this in T66721: 2.8 Crashing while modifying widgets on MacOS.Jul 12 2019, 3:13 AM
Ash Curkpatrick (curkas) added a comment.Jul 12 2019, 4:16 AM

@Jeroen Bakker (jbakker) I can't get it to always happen in a new file (though it does occur), but it will invariably occur in this file particular file here

Host02.blend1 MBDownload

You can see the result here in this screen recording.

Sebastian Parborg (zeddb) merged a task: T66721: 2.8 Crashing while modifying widgets on MacOS.Jul 12 2019, 10:17 AM
Sebastian Parborg (zeddb) added subscribers: Volodymyr (linosia), Gavin Scott (Zoot).
Sergey Sharybin (sergey) added a comment.Jul 12 2019, 4:47 PM

@Clément Foucault (fclem), i can not see anything obviously wrong in the dependency graph logs. My speculation here is that editing vertex causes draw batch to be invalidated, and armature somehow uses old draw batch, which gets re-created by the mesh object. At lest that's my understanding why flickering happens and why backtrace goes to the draw code.

Clément Foucault (fclem) mentioned this in T66991: Crash when deleting edit bones when pchan is referenced by bendybone.Jul 15 2019, 2:26 PM
Clément Foucault (fclem) claimed this task.Jul 15 2019, 3:46 PM

I can reproduce the flickering and this is exactly what @Sergey Sharybin (sergey) was suggesting.

Sebastian Parborg (zeddb) merged a task: T66932: Bones with custom boneshapes with shapekeys causes flickering.Jul 15 2019, 5:03 PM
Sebastian Parborg (zeddb) added a subscriber: Sophia (Zophiekat).
Clément Foucault (fclem) changed the task status from Unknown Status to Resolved by committing rB4404a0dcd4c5: Fix T66707 Modifying bone's 'Custom Object' reference shape causes blender to….Jul 15 2019, 7:28 PM
Clément Foucault (fclem) added a commit: rB4404a0dcd4c5: Fix T66707 Modifying bone's 'Custom Object' reference shape causes blender to….