Maniphest T66798

copy modifiers (ctrl + L) doesnt work for physics modifiers, also changing multiple values with the alt key is broken.
Closed, Archived

Assigned To
Philipp Oeser (lichtwerk)
Authored By
michael campbell (3di)
Jul 12 2019, 7:20 PM
Tags
  • BF Blender
Subscribers
Brad Clark (RiggingDojo)
michael campbell (3di)
Philipp Oeser (lichtwerk)
Tokens
"100" token, awarded by RiggingDojo.

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: rB06312c6d2db8
Worked: (optional)

Short description of error
copy modifiers (ctrl + L) doesnt work for physics modifiers, and also changing the value of multiple selected objects with the ALT key is also broken.

Video of the problem here:

https://www.dropbox.com/s/0c94til2wbc2gpq/copy%20modifiers%20and%20change%20multiple%20values%20bug.mp4?dl=0

Event Timeline

michael campbell (3di) created this task.Jul 12 2019, 7:20 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Jul 14 2019, 6:17 PM
  • regarding the builtin make links > modifiers: will check on that
  • regarding the copy attributes addon copy modifiers functionality: will check on that, too

(these two might have limitations and might even work as expected -- even though it looks a bit weird at first sight... like I said, will check code in a bit...)

regarding "changing the value of multiple selected objects with the ALT key is also broken": this is working for me.
[you seem to be using it differently though: I think you are supposed to be holding ALT before clicking in the number field, whereas you are clicking in the number field and press ALT just before confirming with RETURN]
[the former works for me all the time, whereas the later kinda works, too, but fails if one of the "participants" has a value of 0.0... -- but like I said, the recommended way is to press ALT prior to clicking in the number field...]

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 80.Jul 14 2019, 6:34 PM
michael campbell (3di) added a comment.EditedJul 14 2019, 7:05 PM

Hi Philipp, i've figured out the alt key issue, it seems to be a designed behaviour. If you press the alt key before clicking the box, then the values all change to be the new value, but if you press alt whilst pressing enter then the value is changed relative to each objects current value. So for example if they're all set to 0, and you then change one of them to 0.5, then change it to 0.6, but this time pressing alt when pressing enter, then it will change to 0.6 but the others will change to 0.1 (increasing by the same amount as the active object).

This is a really handy behaviour now I know of it's existence, so please dont try to fix that one :D

The problem with make links was an issue in 2.79, I think I recall blender guru pointing the bug out in one of his videos, but he was able to use the copy attributes menu addon succesfully.

Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Unknown Status.Jul 18 2019, 2:55 PM
Philipp Oeser (lichtwerk) claimed this task.

Coming back to this, one thing I noticed in your video was that you'd expect to have ALT+click working on Collision in the Physics tab. This however is an operator, ALT+click only works for properties...

In T66798#721652, @michael campbell (3di) wrote:

Hi Philipp, i've figured out the alt key issue, it seems to be a designed behaviour. If you press the alt key before clicking the box, then the values all change to be the new value, but if you press alt whilst pressing enter then the value is changed relative to each objects current value. So for example if they're all set to 0, and you then change one of them to 0.5, then change it to 0.6, but this time pressing alt when pressing enter, then it will change to 0.6 but the others will change to 0.1 (increasing by the same amount as the active object).

This is a really handy behaviour now I know of it's existence, so please dont try to fix that one :D

Thanx for making me aware! Thats indeed handy...

The problem with make links was an issue in 2.79, I think I recall blender guru pointing the bug out in one of his videos, but he was able to use the copy attributes menu addon succesfully.

reg. make_links > modifiers:

  • from the Physics panel, Forcefield, Ridgid Body, Ridgid Body Constraint are no real modifiers, so these wont be copied
  • Collision is explicitly excluded in code [this could be made working, needs some care because data related to collisions is stored in PartDeflect which has other stuff in it too, cant just copy it, will look into it but that's for later...]
  • the others seem to be working fine
  • so no bug here

reg. the Addon:

  • that copies the collision modifier in a way that its settings are not preserved, thats true, this could be made better, but this would also not be considered a bug at this point...

That leaves us with the workaround: use the Addon, use ALT+click to change all values at the same time...

Will archive this report for now... thx for the report anyways.

Brad Clark (RiggingDojo) added a subscriber: Brad Clark (RiggingDojo).Dec 27 2021, 2:07 AM

This is still an issue and it seems to be a bug by choice..still a problem in blender 3.0, and by problem I mean, setting up lots of collision objects and adjusting settings, to find no way to copy that easily after the fact with two different tools that seem like they could do that is not a great experience.

I see arguments here about what is a modifier to copy or not but at this point but if the argument is Collision isn't a modifier that can be copied easily.. aka it was excluded in the code.. then the copy should not remove collision on the target.

The bug is that it half does something... so the fix for it to copy All modifiers would be amazing, but if it really can't be, then it shouldn't remove collision on the target and the documentation, to me, should be updated to list limitations since it doesn't say.. copy-some modifiers as a tool name, and cause a bug hunt and a "why isn't this working, what am I doing wrong" user loop...it was a journey to get here.

But since we agree that Collision is a modifier, it is added as a modifier, ctrl-c- copy selected modifiers sees it as a modifier (but doesn't copy value/settings) then we are stuck with no existing way to do this.

Thank you.

Brad Clark (RiggingDojo) awarded a token.Dec 27 2021, 2:07 AM