Maniphest T67032

Collections: Appending scene links random collections to existing scene - Need to change policy on 'orphaned' objects in link/append code
Closed, ResolvedTO DO

Assigned To
Bastien Montagne (mont29)
Authored By
Wayne Dixon (waylow)
Jul 16 2019, 4:15 AM
Tags
  • BF Blender
Subscribers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Wayne Dixon (waylow)

Description

System Information
Operating system: Darwin-17.2.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.27.6 378.10.10.10.20.109

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-15 20:44, hash: rBaf51988115d4
Worked: (optional)

Short description of error
When appending a scene from another file Blender will link some random collections at 0,0,0

Exact steps for others to reproduce the error
Start a fresh file
Append the 'BG' scene from the 'treasure-chest-BG' file.
It will link some of the collections to the current scene in the working file.

See attached video and files

Revisions and Commits

rB Blender

Event Timeline

Wayne Dixon (waylow) created this task.Jul 16 2019, 4:15 AM
Bastien Montagne (mont29) claimed this task.Jul 16 2019, 8:52 PM
Bastien Montagne (mont29) lowered the priority of this task from 90 to 50.
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

There is something wrong here indeed... think it's related to non-instanced objects, but still investigating.

Bastien Montagne (mont29) added a comment.Jul 16 2019, 10:36 PM

Yeah, this is not a bug in fact. Your treasure-chest-BG.blend file has several objects which are not in any scene (the ones in fern collection e.g.)… Blender used to forbid this, and hence those 'orphaned' objects/collections are forcefully added to the current scene when linking/appending.

We can probably consider changing this policy, now that any collection can be instantiated in a view layer at any time, as long as an object belongs to at least one collection, things should be OK…

Will keep that task open as a TODO, we'll have to wait for after 2.80 release to address this anyway.

Bastien Montagne (mont29) renamed this task from Collections: Appending scene links random collections to existing scene to Collections: Appending scene links random collections to existing scene - Need to change policy on 'orphaned' objects in link/append code.Jul 16 2019, 10:37 PM
Bastien Montagne (mont29) edited a custom field.
Bastien Montagne (mont29) mentioned this in T63728: Data, Assets & I/O Module.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Aug 12 2019, 1:33 PM

I think it should only instance the objects or collections that were selected by the user in the file browser, all the indirect stuff indeed does not need to be instanced.

Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rB37b4384b59c0: Fix T67032: Do not systematically link 'orphaned' indirectly linked objects to….Aug 12 2019, 3:44 PM
Bastien Montagne (mont29) added a commit: rB37b4384b59c0: Fix T67032: Do not systematically link 'orphaned' indirectly linked objects to….