Maniphest T67048

Adding archimesh stairs object to the scene flips normals of all other objects in scene
Closed, Resolved
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Ludvik Koutny (rawalanche)
Jul 16 2019, 12:25 PM
Tags
  • Add-ons (Community)
Subscribers
Ludvik Koutny (rawalanche)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.64

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: rB06312c6d2db8
Worked: (optional)

Short description of error
When adding a stairs object from archimesh (addon bundled with Blender), once stairs object is added, it flips normals of all the other objects in scene.

Exact steps for others to reproduce the error

  1. Enable archimesh addon
  2. Enable backface culling in viewport setting to see the normal orientation
  3. Add archimesh stairs to the scene

Result: Normals of all the scene objects are flipped
Expected: Normals of other scene objects remain unaffected

Revisions and Commits

rBA Blender Add-ons
D5282rBA184f7341bd17 Archimesh: fix usages of bpy.ops.object.select_all

Event Timeline

Ludvik Koutny (rawalanche) created this task.Jul 16 2019, 12:25 PM
Philipp Oeser (lichtwerk) edited projects, added Add-ons (Community); removed BF Blender.Jul 16 2019, 12:43 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 30.Jul 16 2019, 12:48 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Cannot reproduce here.
[Stairs themselves have flipped normals on the side :), but thats another story... existing objects remain untouched afaict...]
[also dont see any recent commits that might have changed this...]

Do you have a .blend for us where this happens?

Ludvik Koutny (rawalanche) added a comment.Jul 16 2019, 12:52 PM
In T67048#723751, @Philipp Oeser (lichtwerk) wrote:

Cannot reproduce here.
[Stairs themselves have flipped normals on the side :), but thats another story... existing objects remain untouched afaict...]
[also dont see any recent commits that might have changed this...]

Do you have a .blend for us where this happens?

Yes, but it's a job file. Can't share it publicly, but I can send you privately. Where to?

Philipp Oeser (lichtwerk) added a comment.Jul 16 2019, 1:04 PM

This is not reproducable with a sharable file?

otherwise: are you on https://blender.chat/channel/blender-coders? (think we can send files one-to-one there...)

Philipp Oeser (lichtwerk) added a comment.Jul 16 2019, 1:23 PM

also, does this still happen with Factory Settings and just Archimesh enabled?

Ludvik Koutny (rawalanche) added a comment.EditedJul 16 2019, 2:02 PM
In T67048#723774, @Philipp Oeser (lichtwerk) wrote:

This is not reproducable with a sharable file?

otherwise: are you on https://blender.chat/channel/blender-coders? (think we can send files one-to-one there...)

I am unable to access that site. It just keeps loading infinitely.

Try following:

  1. Enable archimesh addon
  2. In an empty, new .blend file select default cube, go to edit mode, and recalculate normals inside (Mesh>Normals>Recalculate Inside)
  3. Exit edit mode back to object mode, and enable backface culling in Viewport Shading settings. Now you should see interior faces of the cube, as normals are inverted
  4. Add Archimesh Stairs object, and you should observe the face rendering immediately flip, so that you see outside faces despite normals being inside.
Philipp Oeser (lichtwerk) raised the priority of this task from 30 to 50.Jul 16 2019, 2:43 PM

OKi, can repro now...

Philipp Oeser (lichtwerk) claimed this task.EditedJul 16 2019, 5:04 PM

Bad usages of bpy.ops.object.select_all() in archimesh it seems, I wonder why it is not complaining if called with False...
All is good if you do bpy.ops.object.select_all(action='DESELECT'), this might not be needed even (stuff is deselected prior anyways...).
Will check on all this in a bit...

Philipp Oeser (lichtwerk) added a revision: D5282: Archimesh: fix usages of bpy.ops.object.select_all.Jul 17 2019, 4:07 PM
Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved by committing rBA184f7341bd17: Archimesh: fix usages of bpy.ops.object.select_all.Jul 17 2019, 4:36 PM
Philipp Oeser (lichtwerk) added a commit: rBA184f7341bd17: Archimesh: fix usages of bpy.ops.object.select_all.