Maniphest T67091

Sculpt mask not showing with deformation modifiers
Closed, ResolvedTO DO

Assigned To
Pablo Dobarro (pablodp606)
Authored By
Konrad (Czteryk)
Jul 17 2019, 12:46 AM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
  • Modifiers
Subscribers
Andrew Black (BitRot)
Brecht Van Lommel (brecht)
carlos campos (carlosgc)
Dalai Felinto (dfelinto)
Jeroen Bakker (jbakker)
Konrad (Czteryk)
Marcelievsky (Marcelievsky)
1 More Subscribers

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GT 730/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 411.63

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: rB06312c6d2db8
Worked: (optional)

Short description of error
Masking in sculpting mode looks working but it is not visible even if those option is on.
Mask is appear only in Dyntopo mode.

Exact steps for others to reproduce the error

Select object and change for sculpting mode. Try mask brush or use shift+ctrl+LMB to select part of object.
Visually nothing happens. When you change for any other brush you can check so mask is there.

When you turn on dyntopo mode and after view port rotation, mask is appearing.

Regards

Related Objects

Mentioned In
T80298: sculpt mode _ mask no color
Mentioned Here
rBf070bdd7c9c4: Fix T63802: textured lights not working with OSL
rB2f77175fecc7: Fix sculpt mask not visible in EEVEE
rBa36a44bb811d: Fix paint curve not drawing selection colors properly

Event Timeline

Konrad (Czteryk) created this task.Jul 17 2019, 12:46 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Jul 17 2019, 2:01 AM

I cannot reproduce this (Linux here), either in the mention commit or in the latest 2.8 (a36a44bb811d8).
Steps I'm doing:

  • Switch to the Sculpting Workspace
  • Shift+Ctrl+LMB

The mask shows up right away (the dark areas in the cube):

Konrad (Czteryk) added a comment.Jul 17 2019, 2:37 AM

Thank you for quick reply.

As you mention I have done some tests and I have found what is going on.

I have character which is rigged so as long as armature modifier is on object, mask is not showing in sculpt mode.

Everything goes back to normal when armature modifier is applied or removed from object.

Best regards

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Jul 17 2019, 1:17 PM

You dont have to apply the modifier, you can just turn it off for the viewport (show_viewport).

That being said, I can confirm mask is not showing on a effective deforming modifer, however I am unsure what the current status of "crazy-space" sculpting actually is?
It seems to not be working properly?

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Jul 17 2019, 1:35 PM
Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, Modifiers.
Philipp Oeser (lichtwerk) added a subscriber: Pablo Dobarro (pablodp606).

It seems to not be working properly?

scratch that, was testing on a inapproriate mesh... So yeah, if we fully support sculpting on deforming modifiers, shouldnt the mask also be carried over?
Suppose this is a modifier [not a drawing] issue, since this also didnt work in 2.79...

@Pablo Dobarro (pablodp606): is this possibly working in your branch already?

Philipp Oeser (lichtwerk) renamed this task from Masking in sculpting mode not working properly. to Sculpt mask not showing with deformation modifiers.Jul 17 2019, 1:35 PM
Pablo Dobarro (pablodp606) added a comment.Jul 17 2019, 2:45 PM

I disabled the mask display with modifiers in this commit rB2f77175fecc7. That is necessary in order to render the mask while sculpting with EEVEE enabled. I'm not sure if modifiers_active takes into consideration if the modifier is deformation only.

Philipp Oeser (lichtwerk) added subscribers: Jeroen Bakker (jbakker), Brecht Van Lommel (brecht).Jul 17 2019, 3:35 PM

Hi Pablo!

This seems to have been working prior to your commit at some point -- both deformed and undeformed, also in lookdev and eevee (have an old build, namely rBf070bdd7c9c4)
So there seems to be a solution for both? If that somehow is not possible anymore because something under the hood changed, then I am not sure what is more important here: showing the mask while sculpting with EEVEE or the feature of showing the mask when sculpting on a rigged model? Anyways, just saying... @Pablo Dobarro (pablodp606): really looking forward to the work in your branch btw :)

CC @Brecht Van Lommel (brecht), @Jeroen Bakker (jbakker)

Pablo Dobarro (pablodp606) added a comment.Jul 17 2019, 3:53 PM

There was a refactor commit including the BKE_sculptsession_use_pbvh_draw function among other changes to solve some viewport update issues, maybe that was the thing that broke this. I prefer showing the mask in EEVEE and not in the modifiers. If sculpt mode detects that there are only deformation modifiers active that rendering code should work as it is now, but probably it will cause problems somewhere else. I'm not sure if we should try to fix this now, viewport updates are working fine and I didn't find any weird artifacts with the mask

Brecht Van Lommel (brecht) added a comment.Jul 17 2019, 4:16 PM

This wasn't supported in 2.79 either, masks don't show on deforming modifiers there.

I wouldn't consider this a bug, making masks work correctly with modifiers is a to do item.

Philipp Oeser (lichtwerk) edited a custom field.Jul 17 2019, 7:30 PM
Konrad (Czteryk) added a comment.Jul 18 2019, 12:16 AM

Thank you Lads for bending over this problem :) Hopefully you will find solution in future. Regards

Marcelievsky (Marcelievsky) added a subscriber: Marcelievsky (Marcelievsky).Jan 9 2020, 4:45 PM
In T67091#724625, @Konrad (Czteryk) wrote:

Thank you for quick reply.

As you mention I have done some tests and I have found what is going on.

I have character which is rigged so as long as armature modifier is on object, mask is not showing in sculpt mode.

Everything goes back to normal when armature modifier is applied or removed from object.

Best regards

It's been two years I'm looking fon this answers and I found the problem now when I read about the armature. Thank you!

carlos campos (carlosgc) added a subscriber: carlos campos (carlosgc).EditedMar 24 2020, 4:14 PM

I got it to work. I was having the same issue in 2.82. It happens to me on rigged meshes, basic primitives seems to work fine. the Overlays mask setting was checked on, but still could not see my mask. I turned on dynotopo, then turned it off, then turned off the mask setting in the overlays menu and turned it back on. Hope this helps someone out there.

Although, this is temporary fix, i have to do this every time I want to use the mask tool.

Andrew Black (BitRot) added a subscriber: Andrew Black (BitRot).EditedJul 22 2020, 6:10 PM

For what it's worth, I can also reproduce this with the mirror modifier on an unrigged mesh, blender 2.83 (win64).

Steps to reproduce:

  1. Fire up new project
  2. Move default cube ~3m up the X axis
  3. Apply mirror modifier
  4. Enter Sculpt mode
  5. Ctrl+Shift+Drag and select some verts to mask
  6. Error reproduced: Mask is applied at this point, but is not visible. Can test by trying to push some masked-out verts around to no effect.
  7. Apply mirror modifier
  8. Mask is now visible

Also, for context, using the mirror modifier instead of sculpt symmetry here is especially nice for me, as I'm mostly poly modeling and just occasionally using sculpt brushes to push verts around in an organic way.

Philipp Oeser (lichtwerk) mentioned this in T80298: sculpt mode _ mask no color.Sep 1 2020, 1:42 PM
Pablo Dobarro (pablodp606) closed this task as Resolved.Jan 5 2021, 5:27 PM
Pablo Dobarro (pablodp606) claimed this task.