Maniphest T67305

highlighted wireframe in sculpt mode
Closed, ResolvedBUG

Assigned To
Jeroen Bakker (jbakker)
Authored By
Daniele Viagi (d.viagi)
Jul 20 2019, 11:10 AM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Clément Foucault (fclem)
Daniele Viagi (d.viagi)
Germano Cavalcante (mano-wii)
matc (matc)
ronan ducluzeau (zeauro)

Description

System Information
Operating system: Windows 10
Graphics card: nvidia 1060 Ti

Blender Version
2.8 RC2
Short description of error
If you are in sculpt mode with the wireframe overlay active and create a shape key or add a modifier, the mesh becomes highlighted which is not convenient in sculpt mode.

Exact steps for others to reproduce the error
-Add UV Sphere
-Sculpt mode
-Activate wireframe overlay
-Add a shapekey or a modifier like Subdivision Surface

Revisions and Commits

rB Blender

Event Timeline

Daniele Viagi (d.viagi) created this task.Jul 20 2019, 11:10 AM
ronan ducluzeau (zeauro) added a subscriber: ronan ducluzeau (zeauro).Jul 20 2019, 4:51 PM

I confirm. Same thing happens on ubuntu 18.04 nvidia titan black.

Germano Cavalcante (mano-wii) assigned this task to Clément Foucault (fclem).Jul 22 2019, 7:16 PM
Germano Cavalcante (mano-wii) lowered the priority of this task from 90 to 50.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Basically the BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d) returns false in these cases.

matc (matc) added a subscriber: matc (matc).Jul 28 2019, 11:32 AM

If DRW_object_use_pbvh_drawing returns true, then the modifier isn't visible. This should do the trick for this case.

diff --git a/source/blender/draw/modes/overlay_mode.c b/source/blender/draw/modes/overlay_mode.c
index a5b1133abf4..b9048b4bed4 100644
--- a/source/blender/draw/modes/overlay_mode.c
+++ b/source/blender/draw/modes/overlay_mode.c
@@ -405,7 +405,7 @@ static void overlay_cache_populate(void *vedata, Object *ob)
       const bool is_wire = (ob->dt < OB_SOLID);
       const bool is_xray = (ob->dtx & OB_DRAWXRAY);
       const bool use_coloring = (pd->show_overlays && !is_edit_mode && !use_sculpt_pbvh &&
-                                 !has_edit_mesh_cage);
+                                 !has_edit_mesh_cage && ob->mode != OB_MODE_SCULPT);
       DRWShadingGroup *shgrp = NULL;

       struct GPUBatch *geom;
Philipp Oeser (lichtwerk) added a project: GPU / Viewport.Sep 12 2019, 6:02 PM
Dalai Felinto (dfelinto) removed Clément Foucault (fclem) as the assignee of this task.Dec 23 2019, 4:33 PM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.
Dalai Felinto (dfelinto) added a subscriber: Clément Foucault (fclem).
Jeroen Bakker (jbakker) claimed this task.Jan 10 2020, 1:31 PM
Jeroen Bakker (jbakker) changed the subtype of this task from "Report" to "Bug".
Jeroen Bakker (jbakker) removed a project: Tracker Curfew.
Germano Cavalcante (mano-wii) added a project: EEVEE & Viewport.Jan 10 2020, 1:36 PM
Jeroen Bakker (jbakker) closed this task as Resolved by committing rB162cb7432030: Fix T67305: Sculptmode Wireframe Coloring.Jan 13 2020, 12:58 PM
Jeroen Bakker (jbakker) added a commit: rB162cb7432030: Fix T67305: Sculptmode Wireframe Coloring.
Clément Foucault (fclem) removed a project: GPU / Viewport.Jun 19 2020, 11:06 PM