Maniphest T68018

Being able to set the same location of proxies to source is not allowed in the filesystem
Closed, ResolvedBUG

Assigned To
Richard Antalik (ISS)
Authored By
Christopher_Anderssarian
Jul 31 2019, 8:59 PM
Tags
  • Images & Movies
  • Video Sequencer
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Christopher_Anderssarian
Mal Duffin (mal_cando)
Philipp Oeser (lichtwerk)

Description

Title:

System Information
Operating system: Windows 7
GPU: Radeon Vega 64, Divider version: 19.4.1
CPU: Intel Core i7-5960X

Blender Version
Broken: All of them
Worked: None

Short description of error

The settings in the proxy panel allow for the Proxies to be saved in the same location as the source.
It is not possible to create a folder that has the same name as a file (including extension), so Blender crashes.

Exact steps for others to reproduce the error

From T67535#741176:

Callback:

N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64>N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64\blender.exe --debug
Switching to fully guarded memory allocator.
Blender 2.81 (sub 0)
Build: 30/07/2019 17:01 Windows Release
argv[0] = N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64\blender.exe
argv[1] = --debug

Note: No (valid) 'C:\Users\admin\AppData\Roaming\Blender Foundation\Blender\2.81\config\startup.blend' found, fall back to built-in default.

read file
  Version 280 sub 39 date unknown hash unknown
AL lib: (EE) UpdateDeviceParams: Failed to set 48000hz, got 96000hz instead
found bundled python: N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64\2.81\python
drop file F:\Blender\BugFinds\T67535 VSE crash and failure to update\Cat.blend
Read blend: F:\Blender\BugFinds\T67535 VSE crash and failure to update\Cat.blend
read file F:\Blender\BugFinds\T67535 VSE crash and failure to update\Cat.blend
  Version 280 sub 75 date 2019-07-29 14:47 hash f6cb5f54494e
Starting work on proxy: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\proxy_25_part.avi
Couldn't open outputfile! Proxy not built!
Starting work on proxy: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\proxy_50_part.avi
Couldn't open outputfile! Proxy not built!
Starting work on index: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\record_run.blen_tc
Couldn't open index target: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\record_run.blen_tc_part! Index build broken!
Starting work on index: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\free_run.blen_tc
Couldn't open index target: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\free_run.blen_tc_part! Index build broken!
Starting work on index: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\interp_free_run.blen_tc
Couldn't open index target: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\interp_free_run.blen_tc_part! Index build broken!
Starting work on index: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\record_run_no_gaps.blen_tc
Couldn't open index target: F:\Blender\BugFinds\T67535 VSE crash and failure to update\VID_201907_trimmed.mkv\record_run_no_gaps.blen_tc_part! Index build broken!
Error   : EXCEPTION_ACCESS_VIOLATION
Address : 0x000000013F6B067F
Module  : N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64\blender.exe

N:\Temp\Blender\blender-2.81.0-git.af4dcc6073fa-windows64>

Exact steps for others to reproduce the error from scratch

  • Factory Start-up
  • Add video
  • In proxy settings select Project
  • In the directory set to the same location as the source video
  • Build Proxies
  • Crash

Also see: T67535#741176

Revisions and Commits

rB Blender
D6148

Related Objects

Mentioned In
rB95a60fe84d5e: Fix errors in fix for T68018
rBb5244cd5dc1a: Fix errors in fix for T68018
Mentioned Here
T67535: VSE crash and failure to update

Event Timeline

Christopher_Anderssarian created this task.Jul 31 2019, 8:59 PM

@Richard Antalik (ISS) If you have a better title, please feel free to change it...

Christopher_Anderssarian added a comment.Jul 31 2019, 9:28 PM

Wouldn't a simple way to fix this be to not include the extension full stop?
Only downside would be the consistency in naming.
Maybe as a dirty fix; could be to check to see if the proxy is set to the source dir and if it is: skip having the full stop...

Richard Antalik (ISS) lowered the priority of this task from 90 to Normal.Jul 31 2019, 11:28 PM

Thanks for report.

As for fix I will have to think about that.
It's a bit struggle working with paths in C. I will come up with something, just could not resist to sigh loudly :)

Richard Antalik (ISS) triaged this task as High priority.Jul 31 2019, 11:30 PM

Changing priority to high mainly because it will also crash Blender

Mal Duffin (mal_cando) added a subscriber: Mal Duffin (mal_cando).Aug 1 2019, 9:46 AM

Hi @Richard Antalik (ISS),

It's a bit struggle working with paths in C.

If you need a hand with any C, just let me know - I'm too busy with work to take on big tasks, but I can def find time to assist you with any C issues you're having.

Philipp Oeser (lichtwerk) edited projects, added BF Blender (2.81); removed BF Blender.Sep 6 2019, 12:23 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Sep 6 2019, 12:41 PM

@Richard Antalik (ISS) : I have added this to 2.81 milestone (since it was set to "High"), mind checking again?

Richard Antalik (ISS) added a comment.Sep 6 2019, 5:27 PM
In T68018#770575, @Philipp Oeser (lichtwerk) wrote:

@Richard Antalik (ISS) : I have added this to 2.81 milestone (since it was set to "High"), mind checking again?

That is correct.
I am focused on new features untill Sep 13 so I haven't really touched bugtracker.

Dalai Felinto (dfelinto) removed projects: Images & Movies, Video Sequencer.Oct 7 2019, 12:37 PM
Dalai Felinto (dfelinto) added projects: Images & Movies, Video Sequencer.Oct 8 2019, 1:19 AM
Brecht Van Lommel (brecht) edited projects, added BF Blender; removed BF Blender (2.81).Oct 25 2019, 5:20 AM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

I see no reason for this to be a 2.81 blocker even if can be considered high prio.

Richard Antalik (ISS) changed the task status from Unknown Status to Resolved by committing rB8ab6ef30ab28: Fix T68018: Crash on building movie proxy.Nov 3 2019, 5:51 AM
Richard Antalik (ISS) added a commit: rB8ab6ef30ab28: Fix T68018: Crash on building movie proxy.
Campbell Barton (campbellbarton) mentioned this in rBb5244cd5dc1a: Fix errors in fix for T68018.Nov 3 2019, 8:03 AM
Campbell Barton (campbellbarton) mentioned this in rB95a60fe84d5e: Fix errors in fix for T68018.Nov 4 2019, 11:15 PM