Maniphest T68021

GPencil: After using eraser when draw primitives, next primitive has missing handles
Closed, Resolved

Assigned To
Antonio Vazquez (antoniov)
Authored By
mobin (mobin.artworks)
Jul 31 2019, 10:44 PM
Tags
  • BF Blender
Subscribers
Antonio Vazquez (antoniov)
Campbell Barton (campbellbarton)
Charlie Jolly (charlie)
mobin (mobin.artworks)

Description

System Information
Operating system:Windows 10
Graphics card:msi gtx 1050ti

Blender Version
Broken: blender-2.81.0-git.af4dcc6073fa-windows64
Worked: (optional)

Short description of error
problems in the Curve / Line / Circle / Arc / Box tool why handles sometimes appear and sometimes disappear. Of course I'm sure Show Gizmo options are active and I don't use shortcuts
Exact steps for others to reproduce the error

Draw an object with the Curve tool

Handles are present early but disappear after a while

To reproduce:

  1. Add a Arc primitive. Move control points.
  2. Confirm with MMB
  3. Select Eraser Tool and erase some parts.
  4. Select Arc primitive again and draw something-> Handles are missing.

Revisions and Commits

rB Blender
D5403

Related Objects

Mentioned In
T67921: Draw mod"deformable handels"
Mentioned Here
D5403: GPencil: Proposed fix for T68021
rBaf4dcc6073fa: DRW manager: select engine: create generic draw_select_id_mesh

Event Timeline

mobin (mobin.artworks) created this task.Jul 31 2019, 10:44 PM
Antonio Vazquez (antoniov) lowered the priority of this task from 90 to 30.Jul 31 2019, 11:03 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

What do you mean with

after a while

...as soon you confirm the primitive, the handles cannot be enabled again. They are only for creation, not to edit later. Maybe you expect to have handles all the time and edit the figure after confirming.

mobin (mobin.artworks) added a comment.Aug 1 2019, 2:52 PM

No I know this

 But when the shape has not yet been confirmed, the handles will disappear but the angles can be changed without the handle

Only the handles disappear for no reason

Antonio Vazquez (antoniov) added a subscriber: Charlie Jolly (charlie).Aug 1 2019, 4:11 PM

@Charlie Jolly (charlie) Can you reproduce it? I cannot.

Charlie Jolly (charlie) added a comment.Aug 1 2019, 6:51 PM

@mobin (mobin.artworks) I'm unable to reproduce the issue. Are the control points for the start and end points still visible?

mobin (mobin.artworks) added a comment.Aug 1 2019, 11:53 PM

No No points are visible

You should work with this tool for at least ten minutes to find out. I suggest drawing a simple character with it

Can I upload a photo or video here to show you?

Charlie Jolly (charlie) added a comment.Aug 2 2019, 1:12 AM

Yes, more information the better.

mobin (mobin.artworks) added a comment.Aug 2 2019, 11:15 AM

@Charlie Jolly (charlie) Jolly (charlie)

I was able to figure out the cause of this problem!
 First, draw a few simple lines with the Curve tool and change the angles with the handles
Then select the Eraser tool and clear a section of lines with it
And now if you choose Curve again and you will notice the disappearance of the handles!
I was able to record a movie from that. How do I send it to you?

Antonio Vazquez (antoniov) added a comment.EditedAug 2 2019, 11:37 AM

@mobin (mobin.artworks) How you sue the Eraser tool? select in he toolbar?

I cannot select the Eraser tool (I need press Enter or MMB before)...if you do that..you have confirmed the curve, so you will never get the handles again. If you get the eraser using othe rmodes, tell me how you did it.

To clarify, the primitive tools are not like tools in other softwares where you can create, delete, edit again, etc. This is not supported, maybe in future relases, but now after the creation it converts in a normal stroke and you must modify with sculpt tools or common edit tools like hand drawing strokes.

PS: You can put the video in Dropbox/Youtube, etc and put here the link.

mobin (mobin.artworks) added a comment.Aug 2 2019, 11:56 AM

No, you haven't noticed!

Yes, you press Enter, then select Eraser and clear a part of the line drawn with the Curve tool!

Then select the Curve tool again and start dragging.

The handles no longer exist

mobin (mobin.artworks) added a comment.Aug 2 2019, 11:57 AM

Antonio Vazquez (antoniov) added a comment.Aug 2 2019, 11:59 AM

Ok, this give us a clue of the problem...the handles are not visible in the "next" arc

Antonio Vazquez (antoniov) claimed this task.Aug 2 2019, 12:00 PM
Antonio Vazquez (antoniov) raised the priority of this task from 30 to 50.
mobin (mobin.artworks) added a comment.Aug 2 2019, 12:00 PM

Yes that's right

Antonio Vazquez (antoniov) renamed this task from Gp handels to GPencil: After using eraser when draw primitives, next primitive has missing handles.Aug 2 2019, 12:02 PM
Antonio Vazquez (antoniov) updated the task description.
Charlie Jolly (charlie) added a comment.Aug 2 2019, 12:09 PM

Confirmed.

Not entirely sure why this is happening but if you select the draw tool then the arc tool the control points are visible again.

mobin (mobin.artworks) added a comment.Aug 2 2019, 12:20 PM

Yes, that's why I said that it appears for no reason and disappears again

Antonio Vazquez (antoniov) added a comment.Aug 2 2019, 12:20 PM

I have seen the reason...fixing it

Antonio Vazquez (antoniov) added a subscriber: Campbell Barton (campbellbarton).EditedAug 2 2019, 12:39 PM

I have found the reason.

When you draw a primitive, by default the current brush->gpencil_tool is DRAW, so the following variable is true:

const bool is_paint_tool = (bool)((brush) && (brush->gpencil_tool == GPAINT_TOOL_DRAW));

The problem when you use the erase, the tool change to GPAINT_TOOL_ERASE and the variable above will be false.

To solve the issue, we need set the gpencil_tool to GPAINT_TOOL_DRAW for all primitives. This is the reason when you select again Draw tools, the handles back again.

@Campbell Barton (campbellbarton) How we can set this value and change the brush when select the Primitive Tools (Line, Arc, Box, Curve)? The logic would be set the same Brush used in Draw mode.

mobin (mobin.artworks) added a comment.Aug 2 2019, 12:45 PM

I hope you find a solution

Thank you very, very much

Antonio Vazquez (antoniov) added a comment.EditedAug 2 2019, 12:46 PM

@mobin (mobin.artworks) Thanks to you for catching the bug and be able to reproduce it.

mobin (mobin.artworks) added a comment.Aug 2 2019, 12:58 PM

you're welcome. You're great because you make Blender users not alone with their problems and it makes a great sense❤?

Antonio Vazquez (antoniov) added a comment.Aug 2 2019, 1:24 PM

I have seen this bug has other potential bug "inside". As the primitive is using the current brush, if the material is pinned, the primitive will use the current material and not the pinned material because the active brush is not the same used in Draw Tool.

Charlie Jolly (charlie) added a comment.Aug 2 2019, 2:14 PM

Same bug appears when switching from 'Fill Tool' to "Primitives".

Antonio Vazquez (antoniov) added a comment.Aug 2 2019, 4:10 PM

Proposed fix: D5403

Antonio Vazquez (antoniov) changed the task status from Unknown Status to Resolved by committing rB455a1e210bcc: Fix T68021: GPencil After using eraser when draw primitives, next primitive has….Aug 2 2019, 4:26 PM
Antonio Vazquez (antoniov) added a commit: rB455a1e210bcc: Fix T68021: GPencil After using eraser when draw primitives, next primitive has….
Philipp Oeser (lichtwerk) mentioned this in T67921: Draw mod"deformable handels".Aug 12 2019, 7:57 AM