Maniphest T68350

Sculpt/Paint Brush Menus, update to 2.8
Closed, ResolvedPATCH

Assigned To
Brendon Murphy (meta-androcto)
Authored By
Ryan Inch (Imaginer)
Aug 7 2019, 8:02 AM
Tags
  • Add-ons (Community)
Subscribers
Ryan Inch (Imaginer)

Description

Task to port the Sculpt/Paint Brush Menus addon, created by Imaginer and meta-androcto, to 2.8.

Related Objects

Mentioned In
rBAce1c8aaa50ac: Dynamic Brush Menus: add warning/options for missing uvs: T68350
rBAdea35721d24e: Dynamic Brush Menus: add interactive mode to default actions: T68350
rBAa40886c44f41: Dynamic Brush Menus: remove duplicate default actions: T68350
rBA6ed2b0e2b5b3: space_view3d_brush_menus: add default spacebar menu actions: T68350
rBAc63bb5abce16: Dynamic Brush Menus: return to release: T68350 T63750 437e41a06681
rBACe479f81053ba: Dynamic Brush Menus: move to release: T68350 T63750 437e41a06681
rBACc2c8c2ff3fb1: Dynamic Brush Menu: Fix Tools position and add to particle mode T68350
rBACae463584af8d: space_view3d_brush_menus: add Tools menu, move to Spacebar T68350
rBAC9b4eb64de707: space_view3d_brush_menus: initial update to 2.8 series : T68350
Mentioned Here
T67350: CUDA error: Illegal address in cuCtxSynchronize(), line 1800

Event Timeline

Ryan Inch (Imaginer) lowered the priority of this task from 90 to Normal.Aug 7 2019, 8:02 AM
Ryan Inch (Imaginer) created this task.
Ryan Inch (Imaginer) updated the task description.
Ryan Inch (Imaginer) mentioned this in rBAC9b4eb64de707: space_view3d_brush_menus: initial update to 2.8 series : T68350.Aug 18 2019, 4:33 AM
Brendon Murphy (meta-androcto) added a comment.EditedAug 23 2019, 3:59 AM

hi, I've tested the addon and all seems well. I do think we can greatly improve this as far as layout and usability.
edited.

Brendon Murphy (meta-androcto) added a comment.Aug 30 2019, 10:46 AM

hi @Ryan Inch (Imaginer)
Your brush menu's relate to your help with the dynamic context menu in 2.79. I'm currently working on the dynamic context menu's and I've decided to remove the brush modes from the spacebar/context menu as your addon does a much better job. Keeping this in mind, I've made a couple of changes:
Name change: Dynamic Brush Menus
Hotkey change: Spacebar in Sculpt and Paint modes.
Menu's change: I've added in the Tools menus, Whilst there's some duplicity here it's important to give access to the built in Tools Menu on such an important key.
I'm taking the following course of action:
Commit my changes to contrib, remove the addon from contrib, restore the addon to release per T67350
After which we can discuss any polish and further changes in irc or blender.chat

Brendon Murphy (meta-androcto) mentioned this in rBACae463584af8d: space_view3d_brush_menus: add Tools menu, move to Spacebar T68350.Aug 30 2019, 12:00 PM
Ryan Inch (Imaginer) mentioned this in rBACc2c8c2ff3fb1: Dynamic Brush Menu: Fix Tools position and add to particle mode T68350.Aug 31 2019, 6:07 AM
Ryan Inch (Imaginer) mentioned this in rBACe479f81053ba: Dynamic Brush Menus: move to release: T68350 T63750 437e41a06681.
Ryan Inch (Imaginer) mentioned this in rBAc63bb5abce16: Dynamic Brush Menus: return to release: T68350 T63750 437e41a06681.
Brendon Murphy (meta-androcto) added a comment.Sep 2 2019, 10:45 AM

@Ryan Inch (Imaginer) hi, I guess to only thing outstanding at this point in time is to do Search, Tools, Quick Favorites and Interactive Mode in order at the top to bring into line with the Dynamic Spacebar addon and pair them up correctly. I'll look at this soon before closing the task.

Brendon Murphy (meta-androcto) added a comment.Sep 2 2019, 12:09 PM

hi, a couple of thing nqr, it's interesting that the Dynamic Spacebar works in particle edit mode and the dynamic brushes work in particle hair, we should discuss how best to fix this. Next on I found was in texture paint mode if the object is not unwrapped, it needs to be. So whilst the missing textures part is solved nicely, maybe we need a check to see if the object is unwrapped? or just add in the unwrap menu in case?

Brendon Murphy (meta-androcto) mentioned this in rBA6ed2b0e2b5b3: space_view3d_brush_menus: add default spacebar menu actions: T68350.Sep 2 2019, 12:12 PM
Ryan Inch (Imaginer) mentioned this in rBAa40886c44f41: Dynamic Brush Menus: remove duplicate default actions: T68350.Sep 4 2019, 7:42 AM
Ryan Inch (Imaginer) mentioned this in rBAdea35721d24e: Dynamic Brush Menus: add interactive mode to default actions: T68350.
Ryan Inch (Imaginer) mentioned this in rBAce1c8aaa50ac: Dynamic Brush Menus: add warning/options for missing uvs: T68350.
Brendon Murphy (meta-androcto) added a comment.Sep 5 2019, 2:55 AM

Closing as resolved. @Ryan Inch (Imaginer) we can work out anything else in due course if needed. Thanks for your help and support.

Brendon Murphy (meta-androcto) changed the task status from Unknown Status to Resolved.Sep 5 2019, 2:57 AM