Maniphest T68401

Improve Interior Face Selection Method
Closed, ResolvedTO DO
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
RobHue (RobHue)
Aug 8 2019, 8:46 AM
Tags
  • BF Blender
Subscribers
Andreas Broerken (dadriel)
Campbell Barton (campbellbarton)
Evan Wilson (EAW)
Patrick (patnard)
RobHue (RobHue)
Tokens
"Love" token, awarded by bnzs.

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.35

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: rBf6cb5f54494e
Worked: (optional)

Short description of error
Select > Select By Trait > Interior Faces also selects outer faces

Exact steps for others to reproduce the error

Open up

mengerSponge.blend4 MBDownload

which contains a menger sponge at level 3; also contains a script to generate menger sponges

0.) go into edit mode
1.) select all
2.) merge by distance (aka remove doubles; merge dist: 0.0001m)
3.) deselect all
4.) Select > Select By Trait > Interior Faces

Result of Interior Face Selection: Does also select additional faces on the outside of the mesh (as shown below in picture01)

  • picture01 showing, that not only the interior faces are selected

  • picture02 showing, that interior face selection works for the menger sponge at level 1

Revisions and Commits

rB Blender
rBa9dbc2ef4a73 Edit Mesh: select interior faces now detects regions

Related Objects

Event Timeline

RobHue (RobHue) created this task.Aug 8 2019, 8:46 AM
Campbell Barton (campbellbarton) mentioned this in T63731: Modeling Module.Aug 8 2019, 9:05 AM
RobHue (RobHue) added a comment.Aug 8 2019, 9:36 AM

Could also relate to the problem referred to in the blender source code comment:

C:\blender-git\blender\source\blender\editors\mesh\editmesh_select.c

/** \name Select Interior Faces

bool EDBM_select_interior_faces(BMEditMesh *em)

Campbell Barton (campbellbarton) renamed this task from Interior Face Selection also selects outer faces to Improver Interior Face Selection Method.Aug 8 2019, 9:42 AM
Campbell Barton (campbellbarton) lowered the priority of this task from 90 to 50.
Campbell Barton (campbellbarton) edited a custom field.
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

This is a known todo, listed it here T63731: Modeling Module

Campbell Barton (campbellbarton) renamed this task from Improver Interior Face Selection Method to Improve Interior Face Selection Method.Aug 8 2019, 9:45 AM
RobHue (RobHue) added a comment.Aug 8 2019, 9:59 AM

The description of the Interior Face Selection Method does what it should be doing:
"Select faces where all edges have more than 2 face users" not sure what users are. Someone said that it could be also refered to as "connected faces".

So yes; it would be rather an improvement than a bug fix.

A more minimal example of interior face selection: (a simple plus made out of 5 boxes merged)

moreMinimalExampleOfInteriorFaceSelectionImprovement.blend610 KBDownload

Bastien Montagne (mont29) merged a task: T68337: Improve Interior Face Selection Method #2.Aug 8 2019, 3:30 PM
Bastien Montagne (mont29) added subscribers: Andreas Broerken (dadriel), Evan Wilson (EAW), Patrick (patnard).
B (bnzs) awarded a token.Aug 26 2019, 9:13 PM
Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved by committing rBa9dbc2ef4a73: Edit Mesh: select interior faces now detects regions.Sep 8 2019, 5:50 PM
Campbell Barton (campbellbarton) claimed this task.
Campbell Barton (campbellbarton) added a commit: rBa9dbc2ef4a73: Edit Mesh: select interior faces now detects regions.